2017-02-06 UTC
sebsel, miklb_, KevinMarks, tantek and [dgold] joined the channel
KevinMarks_ joined the channel
mblaney and KartikPrabhu joined the channel
# 02:15 ben_thatmustbeme finally, after several weeks or working on it, i'm starting to get something useful for my laravel rewrite of my site # 02:17 ben_thatmustbeme and hopefully i can bundle some things up as libs that others can use, like webmention with vouch # 02:18 ben_thatmustbeme its a little sad to be starting over from scratch, doing it all while maintaining all my permalinks has been the biggest concern thus far KevinMarks and KevinMarks_ joined the channel
tantek joined the channel
# 03:41 GWG I agree with the conclusions to a point. But it is also an issue. # 03:41 GWG The plugin could degrade gracefully. KevinMarks joined the channel
# 03:43 aaronpk I'm pro not having the plugin register functions in the global namespace. That's how PHP gor itself a bad name long ago. # 03:43 martymcguire[m] Wow that thread ended up being a lot of discussion for a one line array syntax sugar change to keep backwards compatibility. # 03:44 GWG aaronpk: What is the middle solution? # 03:45 aaronpk You could bundle the mf2 parser with the webmention plugin by doing a sort of manual release of it # 03:45 GWG aaronpk: You mean a backcompat fork? # 03:46 aaronpk Kind of.. it wouldn't take much to make a process for backporting the parser code for 5.2 # 03:46 aaronpk luckily the plugin is really just a bunch of functions that happen to be in the \mf2 namespace # 03:46 GWG aaronpk: That I know nothing about. # 03:47 GWG How to create such a process, I mean. # 03:48 aaronpk Would it help if I made a script in the mf2 parser repo that would export a 5.2 compatible version of the code? # 03:48 GWG aaronpk: Yes. I would certainly use it in my plugin, and I'd imagine pfefferle would do the same for Semantic Linkbacks. # 03:48 GWG But it would only solve one problem. # 03:48 GWG The rest still have to be figured out # 03:57 aaronpk i know on ubuntu i can install multiple versions now # 03:58 aaronpk also 5.2 is officially unsupported. looks like it’s not available via homebrew # 04:06 tantek presumably it is supported by various hosting companies, otherwise WordPress wouldn't stick to it KevinMarks_ joined the channel
# 04:19 aaronpk dreamhost is being proactive and appropriately dropping support for old versions tantek joined the channel
# 04:24 aaronpk i can’t even figure out how to get something to install 5.2 # 04:27 aaronpk can’t even figure out if travis-ci.org supports it # 04:27 GWG aaronpk: And this is, as I said, the tip of the WP iceberg. This is just making sure the library meets minimum standards. # 04:27 GWG aaronpk: I'm almost certain it does # 04:27 aaronpk i’d like to be able to test it. know where i can find a host that supports 5.2? # 04:29 aaronpk travis-ci does support 5.2! so at least i can “run” it there tantek joined the channel
tantek joined the channel
tantek and jaduncan[m] joined the channel
KevinMarks joined the channel
# 05:12 GWG What properties do you store from a webmention? # 05:22 GWG aaronpk: I feel like I sent you down a rabbit hole KevinMarks, tantek and KevinMarks_ joined the channel
# 12:12 GWG Jonnybarnes, WordPress has a PHP5.2 compatibility we were discussing # 12:13 jonnybarnes which is just silly, when was the last time 5.2 got a security update? # 12:15 GWG You can't abandon the WordPress user base just because of that though. The better question is what features of the newer PHP version do you need? # 12:16 jonnybarnes if i remember correctly 5.3 had a few things that were going to be in PHP6, like autoloading and stuff # 12:18 GWG We briefly lost 5.3 support over short array notation # 12:18 GWG A code shortcut is not a reason to bump a version either # 12:19 GWG Changing minimum support requirements only makes sense when you need a feature only provided by a newer version cweiske and pfefferle joined the channel
# 13:11 GWG Good morning, pfefferle. We were talking about Semantic Linkbacks in your absence. # 13:39 GWG It started elsewhere. I was thinking about your comments # 13:41 GWG You said that Semantic Linkbacks was a bit hacky. I was trying to figure out how to make it less so [cdevroe], singpolyma and tantek joined the channel
# 15:32 aaronpk trying to figure out how to install corresponding old version of phpunit to run the tests # 15:44 tantek can't be sure because his local php is 5.5.x and webhost has been auto-upgrading it for a while # 15:44 aaronpk i have a VM with 5.2 on it if you’d like me to test it # 15:46 aaronpk actually the js one doesn’t. the compacted .php version does # 15:48 aaronpk if i take out the one at the top of the file then it parses fine # 15:49 aaronpk hm, running auto_link outputs a bunch of the JS comments # 15:49 tantek aaronpk - yeah you have to use output buffering # 15:50 aaronpk yikes. no wonder i didn’t want to use cassis until i made the php-only version # 15:51 aaronpk the php-only one is what’s included from composer, and it’s part of the repository which also includes the post-process script to create it, so might not be that important to worry about # 16:04 aaronpk oh boy okay this isn’t going to be as easy as i’d hoped # 16:15 aaronpk other than that, it looks like it’s parsing my home page okay! (the HTML values are missing because of that difference) # 16:17 tantek aaronpk, still looking into "date_get_rfc3339 is defined twice" - it should only be defined once for PHP then once for JS # 16:18 tantek yeah exactly - the PHP parser should not be seeing that second one! # 16:19 aaronpk then why is there a if(js()) check in the second one? # 16:21 tantek ok you're right, that version is inconsistent in that way from what I'm running on my site! Argh, must have missed fixing this KartikPrabhu and KevinMarks joined the channel
# 16:51 tantek finds all kinds of new functions he's been testing in production that need to be committed # 17:04 tantek checks his local server before blanking his homepage and all permalinks # 17:05 Loqi aaronpk has 33 karma in this channel (1205 overall) KevinMarks_ joined the channel
# 17:24 tantek uses IRC to keep track of his multi-tasking state # 17:34 tantek discovers pi to 3 digits in sexagesimal epoch days and an ordinal date! # 17:37 tantek aaronpk, great catch of that duplicate function definition # 17:38 tantek cassis.js updated on master - aaronpk - can you try again? (php 5.2) KevinMarks joined the channel
# 17:40 tantek (or rather, was that what you were using for the parse test?) # 17:40 aaronpk it still outputs when the function is run, but the php-only version solves that # 17:41 tantek yeah - I noted that in the header comments :) # 17:41 tantek (I mean, from before even, not a new comment) # 17:45 tantek aaronpk better? if you see this or "/// var" in the browser, you need to wrap your PHP include of cassis.js and use of functions therein with calls to ob_start and ob_end_clean, e.g.: # 17:46 aaronpk yeah. and maybe show two examples. one of the include and another of just the function call # 17:46 tantek I this was good enough (instead of mentioning a specific function) // your code that calls CASSIS functions goes here KevinMarks joined the channel
# 17:49 tantek well, fixed one bug for today, even if it was a PHP 5.2-only parse bug. # 17:49 tantek though I did ship (open source) a couple new functions in CASSIS that previously I'd only been testing privately # 17:49 aaronpk that wasn’t just a 5.2 problem actually! I tried it on 5.6 and it was the same thing # 18:00 pfefferle aaronpk I am not sure if this would be the main problem... # 18:02 pfefferle aaronpk I think we should start the discussion to include the webmention plugin and then iterate... or is there a discussion that this is the last step to integrate all of the plugins? # 18:02 aaronpk well my understanding was no plugin would be able to include the microformats parser unless it was compatible with 5.2, so i figured i would see what it would take to make it compatible # 18:05 pfefferle aaronpk I think we should start to integrate on plugin after another and if the mf2 lib is a problem, they would tell us... # 18:05 pfefferle aaronpk it is no problem to release the plugin in the official repo, so I see no need atm. KevinMarks joined the channel
# 18:07 pfefferle aaronpk I have not seen a official discussion about integrating the plugin into core, so I would wait until we get such a feedback... # 18:08 aaronpk okay, well i did all the “easy” stuff to make it work with 5.2, but hit a snag with domdocument and I don’t have a quick fix for that # 18:08 aaronpk so I won’t bother continuing until I know if it’s going to be worth the effort # 18:10 pfefferle aaronpk It would have been awesome if this was the least thing to do to integrate it into core :) :( pfefferle, pfefferle_, KevinMarks and KevinMarks_ joined the channel
# 18:31 tantek aaronpk - perhaps capture the snag with domdocument as an issue with how far you got? # 18:31 tantek cool, that way you've externalized that internal state and can clear your local cache ;) # 18:31 aaronpk i think i might commit the other changes to the main branch too, since they’re forwards-compatible and certainly don’t make the code any worse # 18:32 tantek feel free to create an issue for "PHP 5.2.4 backcompat" to link them to # 18:32 tantek tries to externalize this kind of state as much as he can KevinMarks joined the channel
KartikPrabhu joined the channel
pfefferle and tantek joined the channel
KevinMarks, KevinMarks_, KartikPrabhu, tantek, miklb, petermolnar, prtksxna and mindB joined the channel
# 23:46 GWG aaronpk: I told you it was only one problem. KevinMarks joined the channel
tantek.com edited /DDOS (+944) "Pingback DDOS example on Krebs noted in Ars Technica article" (view diff)
ben_thatmustbeme finally, after several weeks or working on it, i'm starting to get something useful for my laravel rewrite of my site
GWG Or this from jonnybarnes: https://github.com/indieweb/php-mf2/issues/104
martymcguire[m] Wow that thread ended up being a lot of discussion for a one line array syntax sugar change to keep backwards compatibility.
KartikPrabhu does php not have something like a virtual environment?
david.shanske.com edited /Wordpress_Webmention_Plugin (+525) "/* Issues and Brainstorming */" (view diff)
aaronpk i made progress. i have to wade through these docs now https://github.com/php-build/php-build
jonnybarnes my sites on laravel too: https://github.com/jonnybarnes/jonnybarnes.uk
Loqi It looks like we don't have a page for "main problem" yet. Would you like to create it?_S
loqi.me edited /Accelerated_Mobile_Pages (+68) "KevinMarks added "https://amphtml.wordpress.com/2017/02/06/whats-in-an-amp-url/amp/" to "See Also"" (view diff)