#dev 2020-04-16

2020-04-16 UTC
[chrisaldrich], bear_, eeril, [Kevin_Faaborg] and [prtksxna] joined the channel
#
vilhalmer static since before there was a word for it™
hs0ucy and beko joined the channel
#
GWG These unit tests for WordPress Micropub aren't working because for some reason, it is pinging the real Indieauth.com instead of returning the responses I mocked up.
geoffo joined the channel
#
Salt[m] vilhalmer: static since before there were sites™ :P
geoffo, gRegorLove and [LewisCowles] joined the channel
#
[LewisCowles] GWG what happened with PHP7.4 and isset?
#
[LewisCowles] Derick Rethans (author of xdebug and others) gave a talk at a local group I attended and they only mentioned the array methods for checking keys are set on objects breaking.
[fluffy], ashaibani_, gxt_, swentel, loicm, [KevinMarks], cweiske, Trendschau, [jgmac1106] and [grantcodes] joined the channel
#
[grantcodes] !tell snarfed - I guess instagram atom got taken out by recent(ish) instagram changes?
#
Loqi Ok, I'll tell them that when I see them next
gxt and hs0ucy joined the channel
#
[jgmac1106] Salt been fooling with dokuwiki to try and add notes to the blog..Can't remove title without digging deep.. Dont care enough to now.
#
[jgmac1106] So been using a datetime stamp as a placeholder
#
Salt[m] that's just what I was thinking as a fall-back automatic title
#
Salt[m] I love these projects using a wiki for indieweb!
#
[jgmac1106] salt here is an example: http://longthoughts.jgregorymcverry.com/doku.php?id=namespace:20200409t1122
#
Loqi namespace:20200409t1122
#
[jgmac1106] dokuwiki makes a great static file CMS in a way, has a lot of xml kruft I haven't had time to dig out, but having fun
#
[jgmac1106] the media upload tools are great, and having every post or page one static is nice, I didn't enable php but I could see building a few resuable snippets...just don't know enough about security to risk it
#
[jgmac1106] I did mess up and put some markup in root files that got overwritten at update, learned how to make a custom file...but right now it is a content project
#
[jgmac1106] using it for long form writing and now our poetry radio show
swentel joined the channel
#
Salt[m] very nice, I'll check it out... when it isn't 4:30a >_>
#
Salt[m] need to stop doing this, not like I'm teaching tomorrow <_<
#
[jgmac1106] teacher myself good night or good morning depending on which side of the sun you are one
#
Salt[m] sun hasn't come up yet, I'm in Seattle, but before long that will become my indicator that I've been up too long
loicm, [KevinMarks] and [Michael_Beckwi] joined the channel
#
GWG Still obsessing about this Micropub problem that cropped up due some weird PHP7.4 and WP5.4 modifications. I hate when something else messes me up and I can't figure it out.
#
swentel GWG, haven't found it yet?
#
GWG I found the fact that in PHP 7.4 you can't do if( $var ) apparently.
#
[Michael_Beckwi] that feels very backwards compat breaking
#
swentel wow
#
swentel yeah
#
swentel or is $var not defined yet?
#
swentel because this would break pretty much every framework out there
hs0ucy joined the channel
#
GWG It seems to fail silently when I do it, but most issues got fixed when I switched it out
#
GWG I could be wrong about the source of my problem
#
GWG But I didn't change anything and I'm still getting errors in the unit tests, so I rewrote a bunch of code.
#
GWG I wish I could use the null coaslescing operator
#
aaronpk There are quite a few breaking changes in 7.4, or at least stricter errors about old features
#
GWG aaronpk: That is what I think happened
#
GWG The strictness
#
GWG A PR I had for IndieAuth that is still waiting for review also had issues
#
GWG Since both failures are IndieAuth related, running them in parallel
#
GWG If I didn't have to support two implementations of IndieAuth, one in Micropub, one in IndieAuth...
#
sknebel aaronpk: apropos indieauth, maybe we should do a remote session trying to fix https://github.com/indieweb/indieauth/issues/35 at some point?
#
Loqi [fluffy-critter] #35 Improve validation rules for the verification response 'me'
#
aaronpk Good idea
#
sknebel cc Zegnat [fluffy] sebsel
#
sknebel I'm flexible with times
#
sebsel pong
#
sebsel most of the times I am flexible with them too
geoffo joined the channel
#
GWG I always love a good tech talk
[grantcodes] joined the channel
#
[grantcodes] Hmm we just updated our wp site to php7.4 with no issue. We might not be on wp5.4 yet though
cweiske joined the channel
#
[KevinMarks] you can't do `if ($var)` any more? What do they want, an !=0
#
aaronpk It was probably how undefined variables are handled
#
GWG You can, but the behavior seems to have changed
#
GWG So I switched to a combination of is_null, isset, empty, is false
#
GWG Stricter
[snarfed] joined the channel
#
[snarfed] [grantcodes] no recent instagram changes i know of. yeah most of instagram-atom's requests these days do get blocked, but some get through! i'm seeing 1-2 successful ones per day on my own ig-atom feed
#
Loqi [snarfed]: [grantcodes] left you a message 4 hours, 36 minutes ago: - I guess instagram atom got taken out by recent(ish) instagram changes?
[Steve_Ellwood] joined the channel
#
[grantcodes] Ah, I tried to update mine with a new sessionid and I can't add it because it doesn't generate a valid feed (not even empty) it tries to load some instagram scripts on the instagram-atom domain or something
#
[snarfed] huh, sorry. thanks for the report. will look!
#
[grantcodes] Yeah no worries, didn't know if it was known or not
#
GWG [snarfed]: I am sorry I broke your beautiful unit tests
#
[grantcodes] I get it with any junk session id in a private tab https://instagram-atom.appspot.com/cookie?sessionid=dfs&format=html - source looks like an instagram login page
#
[snarfed] GWG that's what tests are for!
#
[snarfed] they break all the time, that's good, they're catching things. just have to fix them
#
GWG [snarfed]: What frustrates me is they broke without me doing anything
#
GWG New versions upstream
#
GWG I need to expand testing for that
loicm, [tantek] and [chrisaldrich] joined the channel
#
[snarfed] yup! happens
#
[snarfed] still. it's good! often dependency upgrades break your *code*, not just your tests. tests breaking catches that immediately. that's a good thing!
#
GWG [snarfed]: Just frustrated I haven't figured them all out. And it is code I don't use,, which is why I need the tests
#
[snarfed] tests++
#
Loqi tests has 15 karma in this channel over the last year (17 in all channels)
#
Zegnat sknebel: I am always happy to talk IndieAuth. Less flexible with my time as I still go to the office every day. But can definitely work something out
[LewisCowles] joined the channel
#
[LewisCowles] [GWG] are the errors you are seeing around user_id's?
#
GWG [LewisCowles]: Somewhat, why?
#
[LewisCowles] I've set it up and wanted to check I was looking at the same errors
#
[LewisCowles] I was on a call / meet about 7.4 upgrades yesterday
#
GWG [LewisCowles]: I have a branch in my version of the repo called dep20update where I did some fixes.
#
[LewisCowles] want to see if anything jumps out at me
#
GWG Anything in particular?
#
GWG Okay.
#
GWG I did some fix work already. Not quite done
#
[LewisCowles] I fixed the errors by not calling home_url()
#
[LewisCowles] tiny 2 line patch
#
[LewisCowles] my guess is that two users have that url
#
[LewisCowles] and it's creating confusion around which, so I made an idempotent url
#
[LewisCowles] `'/users/' . static::author_id
#
[LewisCowles] should stop clashes
#
[LewisCowles] want a PR?
[schmarty] joined the channel
#
[LewisCowles] it passes multisite and non-multisite with PHP 7.4.4
jeremych_ and [Aaron_Klemm] joined the channel
#
GWG [LewisCowles]: I'll give it a try manually in my branch
#
[LewisCowles] Cool, I've PR'd with a travis edit to get it to test on 7.4. First attempt failed because of the looking for the right phpunit version. IDK what that's about but I just force pushed a fix
moppy joined the channel
#
[LewisCowles] to my branch
#
[LewisCowles] yeah sea of green here and on travis
hs0ucy and oedmarap joined the channel
#
GWG [LewisCowles]: I did a lot of travis edits on mine as well.
#
GWG I upped to PHPUNIT 7
#
[LewisCowles] ah. TBH I've read the test name. While it might be fixed, Perhaps the test needs to go away or DB put into a known state. Green isn't always better
#
GWG [LewisCowles]: All of the Indieweb plugins use similar travis files. I think it may be time to revisit.
#
GWG [LewisCowles]: Did you see the one in my branch?
#
[LewisCowles] I did. Btw the reason why it was failing is that an admin user is added with that site URL
#
[LewisCowles] I may revise my PR
#
GWG Yes, I fixed that one.
#
GWG But somehow, the testing was querying the real indieauth.com instead of simulating it, so I need to change how I mock up remote calls.
#
GWG It's odd though, again...didn't change anything in that area.
[jgmac1106] and [fluffy] joined the channel
#
[fluffy] Hi I just saw the ping re indie Auth spec issue 35. Is there something that needs to be discussed in that?
#
[fluffy] I have an indieauth endpoint at anyauth.beesbuzz.biz that lets folks test their valuation rules
#
[LewisCowles] I think there is a new signature for add_filter in tests, or at least there is a filter method
#
[LewisCowles] tests_add_filter looks like the same signature as add_filter
#
[fluffy] s/valuation/validation/ stupid autocarrot
#
GWG [LewisCowles]: Got docs?
dckc joined the channel
#
[LewisCowles] http://develop.svn.wordpress.org/tags/5.4/tests/phpunit/includes/functions.php is where it's at
#
[LewisCowles] it has some docs, but I've no idea where they would render to
#
GWG I thought that was testing if a filter works
#
[LewisCowles] it calls add_filter, so IDK
#
[LewisCowles] no it definitely modifies the globals filter uses. It doesn't test anything
#
[LewisCowles] it may not fix the filters you are using. but it seems like because it does two things your failure may be related to only doing one
#
GWG I'm abandoning my branch and starting from scratch with yours.
#
GWG The new master is failing locally for me.
#
GWG Something else is going on.
#
[LewisCowles] home_url test is now fixed to test home_url again. To do that I set admin user home_url to /wp-admin/
#
GWG [LewisCowles]: Wonder if it is thatI'm using PHPUnit 7 as opposed to 6.
#
GWG But the live test isn't working either.
#
[LewisCowles] I'm using PHPUnit6 nd its working pulled from master after merge
leg joined the channel
#
[LewisCowles] let me try PHPUnit7
#
GWG I'm going to try a few more incremental PRs
#
GWG I liked that staging I put in
gRegorLove joined the channel
#
[LewisCowles] 7 is refusing to install for me. Dependency conflicts
cweiske joined the channel
#
[LewisCowles] right I trashed vendor, manually updated composer.json and it worked on 7.5 for me
#
[LewisCowles] I do get a warning now that testsuite name should be required
#
GWG I'm fixing that in a PR
#
[LewisCowles] I think I'm going to bed
#
[LewisCowles] night
#
GWG Night
loicm and [schmarty] joined the channel; oedmarap left the channel
#
GWG !tell [LewisCowles] Did some other testing changes if you have any comments when you awake.
#
Loqi Ok, I'll tell them that when I see them next
#
dansup !tell [snarfed] I fixed the iframe issues on piconic :)
#
Loqi Ok, I'll tell them that when I see them next
[tantek] and [snarfed] joined the channel
#
[snarfed] [dansup] oh! thanks! didn't realize you ran piconic too
#
dansup yeah I opened it in January because a lot of people wanted to join pixelfed.social
#
dansup working on bug fixes for the 4 recent api issues!
#
beko 👍
#
sknebel !tell [fluffy] I thought discussing it and proposed solutions might be a nice topic for a virtual session.
#
Loqi Ok, I'll tell them that when I see them next
[fluffy] joined the channel
#
[fluffy] Howdy
#
[fluffy] Is there an IWC Online happening soon or something? I’ve been a bit out of the loop.
#
sknebel no, just randomly have a session about a specific topic. (I've been missing out on virtual HWCs and remembered that was a thing I wanted to look at :D)
#
[fluffy] Ah okay. :) I’m not sure I have anything to add other than what I already wrote in the issue.
#
[fluffy] And my validation logic in Authl already follows my proposal.
#
sknebel 👍
jamietanna joined the channel
#
jamietanna barryf++ for being super helpful with https://micropublish.net/ yesterday and today with helping me diagnose issues with my Micropub server re edit, and helping push a fix to get me unblocked!
#
Loqi barryf has 1 karma over the last year
[jgmac1106], Jamietanna1 and [Aaron_Klemm] joined the channel
#
[snarfed] apologies for all the pixelfed issues, dansup. thanks for the quick fixes!
vika_nezrimaya and ben_thatmustbeme joined the channel
#
GWG I found another Weather API to add.
#
GWG I'm getting overkill here
gRegorLove, KartikPrabhu and Jaygles joined the channel
#
GWG I need some weather advice.
#
GWG I'm adding Aeris Weather to my list of providers. It allows you to only source from METAR, or from METAR + Personal Weather Stations.
KartikPrabhu joined the channel
#
GWG Wondering if I should source from PWSes.
#
GWG Mine is in there.
Jaygles left the channel