#dev 2021-01-25

2021-01-25 UTC
djmoch and kitt joined the channel
#
GWG Trying to format addresses for display is annoying. I need to figure out what countries use what formats...
[snarfed] joined the channel
#
[snarfed] that way lie dragons
KartikPrabhu and deltab joined the channel
#
GWG [snarfed]: How so?
ShadowKyogre joined the channel
#
aaronpk Oh yeah don't do that
#
vilhalmer https://www.mjt.me.uk/posts/falsehoods-programmers-believe-about-addresses/
#
vilhalmer one of my favorites
#
aaronpk Yup
#
vilhalmer calling it a format is generous
#
GWG vilhalmer, aaronpk, [snarfed]: I'm not trying to go that far
#
GWG I'm doing it for presentation on posts...not trying to mail a letter
#
GWG In this case, I'm converting h-adr to a display format.
#
aaronpk h-adr has a small list of defined properties, that's a much simpler problem
#
GWG I already take the output of reverse geocoding APIs and map it to the defined properties.
KartikPrabhu, gxt, swentel, KartikPrabhu1, schmudde, john-doe, [KevinMarks], [tantek] and [Nicolas_Hoizey] joined the channel
#
[Nicolas_Hoizey] ↩️ Hi, no worry for Bridgy, it was an issue with my HTML, where I had a bad mix of `p-author` and `u-bookmark-of`
MrHyde and oenone joined the channel
#
GWG Good morning, Indieweb
deathrow1, jeremycherfas and sebsel joined the channel
#
@gasull ↩️ Isn't IndieAuth a precursor of this? It uses your own domain too. https://indieweb.org/IndieAuth (twitter.com/_/status/1353701152164986880)
IWSlackGateway and [Nicolas_Hoizey] joined the channel
#
[Nicolas_Hoizey] ↩️ Hi [snarfed], no worry for Bridgy, it was an issue with my HTML, where I had a bad mix of `p-author` and `u-bookmark-of`
DanC, [tantek], KartikPrabhu and schmudde joined the channel
#
@Cambridgeport90 Can't remember the issue number, but quick question for @aaronpk. How do I troubleshoot indieauth and aperture? (twitter.com/_/status/1353718363353010182)
#
aaronpk GWG: did my changes to Aperture's IndieAuth break the Wordpress plugin?
#
aaronpk https://github.com/aaronpk/Aperture/issues/100
#
Loqi [Cambridgeport90] #100 Aperture and Wordpress with Indieauth: authorization code could not be verfied
#
GWG aaronpk: Possibly, but I still have the PR to upgrade IndieAuth pending for a while now
#
GWG https://github.com/indieweb/wordpress-indieauth/pull/186
#
GWG Maybe we should test it with that branch and see if it works
#
Loqi [dshanske] #186 Tries to Adopt some of the New IndieAuth Changes
#
GWG I don't use Aperture myself...
#
GWG Maybe I should set up an account purely for testing
[KevinMarks] joined the channel; ShadowKyogre left the channel
#
aaronpk aha this must be it
#
aaronpk yeah let’s get this merged and shipped!
#
aaronpk you don’t really need to “set up an account”, just try to log in at some point
#
GWG aaronpk: I need an approving review to ship. It isn't fair to pfefferle that he's the one regular approving reviewer who can review my things.
#
GWG The alternative is for us to remove the requirement and leave me breaking things.
[schmarty] joined the channel
#
[schmarty] GWG: what kinds of review or feedback does pfefferle usually give on your PRs? perhaps you can ease the review process with extra details on the PR, such as what summarizing what is changing and why, how it can be tested, the results of your manual testing, any open questions you have that he could help answer, etc.
[pfefferle] joined the channel
#
[pfefferle] there are still some discussions open, that’s why I haven’t had another look
#
[pfefferle] I should not be a blocker and I do not have to review everything, but I would love to keep the (at least) 4 eyes principle
#
Loqi it is probable
#
[pfefferle] it is a critical plugin that let’s people login
#
[pfefferle] and we had a very severe problem in the beginning!
leg joined the channel
#
[tantek] agreed with the at least one reviewer requirement, especially for something security / authentication related!
[chrisaldrich] joined the channel
#
GWG [pfefferle]: That's why I want to keep it, I just feel bad we don't have more people who know the plugin to review it
#
GWG I worry about SPOP or SPOG
#
GWG Either way, I will handle the edge case commented on with the null check and the duplicate code improvement.
#
[tantek] GWG, ABBR is the abbreviation tag in HTML
#
GWG Oh...
#
GWG Missed the reference
#
[tantek] GWG e.g. I use markup like this in my events listing display on my homepage:
#
[tantek] ```<abbr class="p-location location" title="Austin, Texas, USA">Austin, TX</abbr>```
#
[tantek] or just the city name: <abbr class="p-location location" title="San Francisco, California, USA">San Francisco</abbr>
#
GWG I am working on the logic...I think I need a list of locations to test against
#
GWG [tantek]: I also distribute the plugin, so I need to omit the home country of whoever is using it
schmudde joined the channel
#
@MeritzPress Where a flower blooms tonight, Devout and purple, With a rift for a hollow power, That shivers it springs from a root - from Pluck At The Offering, Barbarity. Free excerpts. Order at http://amzn.to/2CF8fts or kindle http://amzn.to/2CV3tw4 #literature #author #indieauth (twitter.com/_/status/1353782703066329090)
[schmarty] and [KevinMarks] joined the channel
#
@ChrisAldrich ↩️ You need to tweak the theme so that Jetpack isn't included in the div with e-content. You can use http://Indiewebify.me to test. Bridgy also has a preview option at https://brid.gy/twitter/Cambridgeport90 (twitter.com/_/status/1353790778175324160)
schmudde, ShadowKyogre, KartikPrabhu, [colinwalker], [timothy_chambe], [eddie], lahacker, [tantek], voxpelli_, genehack, willnorris, gxt, [chrisaldrich] and jjuran joined the channel; ShadowKyogre left the channel