#known 2018-01-20

2018-01-20 UTC
[kevinmarks], [cleverdevil], [snarfed] and [jeremycherfas] joined the channel
#
@mapkyca
Early warning for @withknown devs. It looks like we're going to have to introduce a couple of breaking changes to the class hierarchy to handle PHP 7.2+, especially storage types extending Object. I'll keep you posted...
(twitter.com/_/status/954660303295451136)
tomwolf joined the channel
#
Zegnat
"when that comes out", when what comes out? PHP 7.2? That would be last November 😉
travis-ci joined the channel
#
travis-ci
idno/Known#4341 (master - 39d87d8 : Marcus Povey): The build passed.
[kevinmarks], saas0128, [tantek], [jeremycherfas], raretrack, [jgarber], [schmarty], Jonjon1, [miklb], kingkool68, [joe], tantek, [kingkool68], chrisaldrich, [mattgriffin] and mapkyca joined the channel; travis-ci left the channel
#
mapkyca
For the tape, I'm about to merge in a patch which will migrate Object to BaseObject - this is very similar to that submitted by [cleverdevil] (thanks!) - but does it in a "softer" way so as to not totally break everything without warning!
#
@mapkyca
I've just pushed an important @withknown patch that deprecated Object in favour of BaseObject, for PHP 7.2 support. Plugin authors should update their code to use BaseObject, as Object will be removed in a future release...
(twitter.com/_/status/954765894244323329)
travis-ci joined the channel
#
travis-ci
idno/Known#4346 (master - d1fd2da : Marcus Povey): The build has errored.
travis-ci left the channel
#
@mapkyca
Also made Entity and [Base]Object abstract, since they probably should have been since day one! /cc @withknown
(twitter.com/_/status/954770516639928322)
#
@mrclay_org
@mapkyca @withknown In Elgg 3 all core content have types, but not yet reqd. Too much legacy.
(twitter.com/_/status/954772644141953024)
[eddie], [tantek], [jgarber], [mattgriffin], aaronpk_ and [cleverdevil] joined the channel
#
[cleverdevil]
!tell @mapkyca I just tested your changes and they all work great for me. Thanks!
aaronpk_, jonathanprozzi, [kingkool68], chrisaldrich, [miklb], [colinwalker], plindner, [eddie], jaduncan[m] and khurtwilliams joined the channel
#
@hypeDiscovery
@mrclay_org @mapkyca @withknown You mean to say they have their own concrete class
(twitter.com/_/status/954861452514484225)