#known 2019-02-01
2019-02-01 UTC
[asuh], dmcweeney, [tantek] and chrisaldrich joined the channel
# 
[davidmead] [cleverdevil] can i pull changes you made to the Listen plugin, into what I’ve made?
[cleverdevil] joined the channel
# 
[cleverdevil] They're already merged into [jgmac1106]'s project.
# [cleverdevil] If you're in sync with upstream, you'll have my changes 🙂
# [davidmead] so should i pull from him then? i don’t “github” so I’m out of my depth here
# [cleverdevil] Basically, yes, you'll need to pull in the latest from him first, and then you can make changes.
# [davidmead] ok. i’ll give it a go
# [davidmead] would that be “pull 3 commits from origin remote” by any chance?
# [davidmead] looking at my GitHub desktop
[chrisaldrich], [jgmac1106] and [davidmead] joined the channel
# [davidmead] !tell jgmac1106 seems to be stuff missing from `edit.tpl.php` like the artist field etc. going to try and put that back, see if it’s causing the error
# [davidmead] !tell jgmac1106 big chunks of `Listen.tpl.php` were missing from your commit. I added them back in and my site is now working again
[davidmead], [Serena], [tantek], [zacksiri], [chrisaldrich], [xavierroy], [grantcodes], [kevinmarks] and [jgmac1106] joined the channel
# 
[jgmac1106] davidmead++
# [jgmac1106] I might set up an email address since there is no one author or mantainer of the plugin
# 
@jgmac1106 Hello everyone thanks to the work of https://cleverdevil.io and https://davidjohnmead.com/ we have released a stable version of a Listen plugin for @withknown #knownchat published my first fixed post here: https://quickthoughts.jgregorymcverry.com/2019/02/01/porno-for-pyros (https://quickthoughts.jgregorymcverry.com/s/1WmsVu) (twitter.com/_/status/1091294050249003008)
[davidmead] joined the channel
# [jgmac1106] .aahhh I upgraded to five
# [davidmead] jgmac1106 I saw the icon not pulling in on your Listen post. I realized I used the FontAwesome 4 codes for those as I had been using them to fix the Short Profile plugin…
# [davidmead] …but not everyone has those as the core is FA3
# [jgmac1106] fab fa fas,, silly letters
# [davidmead] yeah
# [jgmac1106] but Known may fall back to three
# [davidmead] I think it does
# [davidmead] I can go through tonight and clean that up
# [davidmead] I put the CDN link to `v5.6.3` in my header so I didn’t even think about - duh
jeremych_ and [jeremycherfas] joined the channel
# 
[jeremycherfas] Glad I checked here again. Will wait for another version bump.
# [jgmac1106] its just a missing font awesome icon
# [jgmac1106] and technically not missing its just Known is written for Font Awseome 3 and we wrote it for 5
[davidmead], [tantek], [kevinmarks], [pfefferle], [eddie], [xavierroy], [schmarty], [jgmac1106], [cleverdevil], [Rose], [chrisaldrich], aaronpk, [asuh] and tantek joined the channel; aaronpk left the channel