#microformats 2017-04-25

2017-04-25 UTC
nitot, KartikPrabhu, [cleverdevil], tantek, [pfefferle], [colinwalker], [kevinmarks], fls-bbx-jonost|O, barpthewire, GWG and rodolfojcj joined the channel
#
ben_thatmustbeme
making some slow progress on fixing up the microformats2-ruby parser
#
ben_thatmustbeme
well maybe not that slow, between last night and a train ride this morning it at least has the children array
#
ben_thatmustbeme
doesn't parse it quite right yet, but its certainly an improvement
nitot joined the channel
#
martymcguire[m]
ben_thatmustbeme++ \o/ ? microformats2-ruby improvements!
#
Loqi
ben_thatmustbeme has 1 karma in this channel (201 overall)
[kevinmarks] joined the channel
#
[kevinmarks]
I wonder if we should take another pass at the 'parse all the tests with all the implementations' thing that we had before
gRegorLove joined the channel
#
ben_thatmustbeme
i'm updating the tests to actually use that repo, so ideally it will be
KartikPrabhu and [jeremycherfas] joined the channel
#
sknebel
is there an mf2-parser that preserves the information where in the source document it got a value from?
#
gRegorLove
sknebel: I don't think so. You mean like it keeps track of the specific HTML tag?
#
ben_thatmustbeme
not that i know of. i think thats because many of the parsers depend on libs that don't keep that around (at least not as HTML)
#
sknebel
yes, I assumed so but wanted to make sure
#
ben_thatmustbeme
looking at the ruby one you parse it into a tree, and then descend the tree to create a new tree, you could keep the nodes around, but i don't think it gives you an easy way to get back the html, at least not that i could tell
#
KartikPrabhu
mf2 parsing is supposed to be tag-agnostic that way
tantek joined the channel
#
gRegorLove
What are you wanting to do with that information, sknebel?
adactio joined the channel
#
sknebel
since I've been helping people debug their sitess I've been thinking about debugging tools
#
sknebel
and it might be helpful to be able to highlight "*this* is where this value comes from"
#
sknebel
I might be able to hack microformats-shiv to annotate the live DOM on a web page while parsing
[colinwalker] joined the channel
#
gRegorLove
Ah, yeah it could be cool to run an extension that adds an overlay in the browser
pniedzielski[m], martymcguire[m], nitot, pfefferle and [chrisaldrich] joined the channel
#
ben_thatmustbeme
martymcguire[m]: if you want to check out my progress github.com/dissolve/microformats2-ruby
[jeremycherfas] and KartikPrabhu joined the channel
#
martymcguire[m]
ben_thatmustbeme: sweet! i like that this mostly looks like simple tweaks/additions.
#
ben_thatmustbeme
well, i'm going to be doing a bunch more yet possibly
#
martymcguire[m]
passing around that "parsing_children" boolean feels "wrong" somehow.
#
ben_thatmustbeme
yes, but then having those in seperate files is sort of a messy way to do it
#
martymcguire[m]
what happens if that check is skipped? the properties get stuffed into a children object?
#
martymcguire[m]
as in, properties end up attached to the wrong things?
#
ben_thatmustbeme
so if you don't have it know if its parsing children or not, you get any h-* child in the children array, whether its a p-* or not
#
ben_thatmustbeme
so like p-author h-card items always end up duplicated in the children array
#
ben_thatmustbeme
it needs to know about its sort of weird the way it works though, its parsing the tree twice
#
ben_thatmustbeme
once for properties, once for children
#
ben_thatmustbeme
because the property_parser can't pass child h-* items up to the format_parser
#
ben_thatmustbeme
which is why it ends up messy and slow because its in mutliple parsers like that
#
martymcguire[m]
ahh, interesting. not proposing this as a code change right now, but would it make sense to do something like parse it all as formats and then collapse the appropriate formats as properties in a second pass?
#
ben_thatmustbeme
well i'd like to remove the second pass altogether
#
ben_thatmustbeme
so i think i'm going to just join those two classes together
#
ben_thatmustbeme
i could make it work this way, but as you can see, there are some messy bits
#
ben_thatmustbeme
well, i'm sort of on the fence with it, it works like this, its not as pretty, but its working now
#
gRegorLove
Does it do backcompat parsing yet? Have to keep the parent element in mind, whether it's mf2 or mf1
#
gRegorLove
I made some recent improvements to php-mf2 along those lines. It's an open PR, not in master yet.
#
ben_thatmustbeme
no, it doesn't do backcompat
#
gRegorLove
Ok, disregard :)
#
ben_thatmustbeme
well, thats something i want to add
#
ben_thatmustbeme
i want to get this thing as done as i can
#
ben_thatmustbeme
i'm not totally sure that the test suite is correct at the moment though
#
gRegorLove
It has some issues in places, but at least we can fix them in one place
#
gRegorLove
Offhand I know we need to get rid of the h-as- in there
#
ben_thatmustbeme
comparing JSON isn't that great, since rels: {} will break the test suite
#
ben_thatmustbeme
i was going to use microformats-tests as an npm module (as a way to just get all the test objects)
#
ben_thatmustbeme
i meant the test suite in the microformats-ruby gem itself
#
ben_thatmustbeme
huh, weird its changing -'s to _'s
#
ben_thatmustbeme
was wondering why things were failing
#
ben_thatmustbeme
ruby methods cannot have -'s in the name can they
[colinwalker] joined the channel
#
@AndrewMiguelez
#microformats question: How do I use #h-entry's #u-photo without an img element? Primary image is outside of the article for design reasons.
(twitter.com/_/status/856926832041578497)
#
tantek
interesting question
#
Loqi
[@aaronpk] @andrewmiguelez The u- prefix tells the parser where to find the value, so you can use a <data> element http://pin13.net/mf2/?id=20170425174631720
#
tantek
that's ok but not great
#
aaronpk
probably worth inviting him to IRC tho for followup questions
#
tantek
better would be to use an <a href> to link to the image
#
aaronpk
that also works. why is it better?
#
tantek
because presumably you still want the person reading the article to be able to view the image
#
tantek
it's better because it's more visible
#
tantek
data element really should be last resort
[mko] joined the channel
#
tantek
not the first to recommend
#
aaronpk
it probably heavily depends on the rest of the site and design consideration
#
aaronpk
hadn't thought about an empty <a> tag, that's probably a better first approach
#
tantek
even better than that is to ask how is the image on the page at all?
#
tantek
and why are you posting a photo post for a photo that's not visible on the page?
#
tantek
because h-entry u-photo means "photo post"
#
tantek
if it's not a photo post, then u-photo is likely being misused
#
tantek
e.g. "outside of the article" is a bit of a red flag
#
tantek
what is the h-entry then? just the article?
#
tantek
what's the image for?
#
tantek
(from a user perspective)
#
tantek
without knowing that, you can't even know if u-photo is the right property to use!
#
tantek
nevermind which element
#
tantek
e.g. is it actually just a featured decorative image for the article?
#
KartikPrabhu
u-photo and u-featured have been confused in the past
#
tantek
KartikPrabhu: rather, u-photo has been confused even more so
#
tantek
all by itself
#
tantek
u-featured was introduced to address *some* of that existing confusion
#
KartikPrabhu
right, that s what I meant. u-photo has been confusingly used for "photo post" and also the featured decorative image
#
[mko]
Yeah. I would use `u-featured` for that use case that he's describing. I imagine the "use case" is that they want to have something akin to Medium's "big photo" at the top and don't know how to wrap that into the article h-entry context without making the entire body the `h-entry`
[eddie] joined the channel
#
[eddie]
Yeah, mko, that’s exactly how I understood his post
#
KartikPrabhu
[mko]: big top photos can easily be inside the article
#
Loqi
[Kartik Prabhu] The Science in Science Fiction
#
[mko]
@kartikPrabhu: I agree. Some people aren't very adept at CSS or have weird DOM requirements for interactions they implement. I'm not saying he's right in implementing it outside the article's `h-entry` just that I consider the use-case to be valid.
#
[eddie]
KartikPrabhu: What’s going on in the light gray area? I’m confused
#
KartikPrabhu
[eddie]: it is an external embedded post
AndrewMiguelez joined the channel
#
[eddie]
ohhh gotcha :thumbsup: Like a custom “Twitter card” type thing
#
KartikPrabhu
[eddie]: yup :) I did it manually though :P
#
AndrewMiguelez
Hey, OP for the u-photo question here. For clarification, I have the featured image of the post as a banner placed in the DOM on the same level as the site header and content area.
#
KartikPrabhu
AndrewMiguelez: welcome. u-photo is used when you are explicitly posting a photo
#
gRegorLove
Welcome, AndrewMiguelez
#
Loqi
[Written by Andrew Miguelez » see all posts Andrew Miguelez Andrew is the owner of Recharge Workshop. He loves to fix and build things, especially with pallet wood. His baby is the best baby out of all the babies. Primarily a web designer, Andrew found a wonderful overlap in blogging about his DIY hobby here on Recharge Workshop. You can follow him socially on facebook, instagram, and twitter. andrewmiguelez.com] DIY Pallet Wood Bunting Written by: Andrew Miguelez March 19, 2017Tutorial If you do a Google search for “pallet wood bunt...
#
KartikPrabhu
for indicating a "Featured" image" you might want to use u-featured instead
#
gRegorLove
h-entry could be on the <body> or even <html>. The properties for child elements (like e-content) will indicate what the actual article's contents are.
#
AndrewMiguelez
I see that I should be using u-featured now. I wasn't considering it because it's in the "proposed" section.
#
KartikPrabhu
AndrewMiguelez: yes. Like gRegorLove said, I'd put the h-entry on the <body> and use "u-featured" for the image
#
gRegorLove
How easy that may be to set up depends on your CMS, though
#
KartikPrabhu
looks like WP
#
AndrewMiguelez
Yeah, not a noob here, let me have it.
#
tantek
welcome AndrewMiguelez!
#
AndrewMiguelez
haha. I am concerned about including too much non-relevant content inside the h-entry. Should I not be worried about that at all?
#
Loqi
ahahahaha
#
gRegorLove
With the class=e-content and class=p-name (or, looks like microformats1 equivalents) only the article's title and body will be parsed.
#
gRegorLove
So the parent h-entry can go anywhere higher in the DOM
#
gRegorLove
I don't know WP theming very well, but my understanding is a fair bit of the microformats are handled by the core code. The "hentry" is added on the <artlcle> element there, for example.
#
AndrewMiguelez
Okay, thanks. I haven't pushed my microformats2 updates yet. I was waiting to get the primary photo issue resolved to get it all done in one shot.
#
gRegorLove
mf1 is still fine, btw. Most mf2 parsers have backcompat
#
AndrewMiguelez
@gRegorLove you're right, they use mf1 very poorly in my opinion.
#
gRegorLove
pin13.net/mf2 is useful for testing parsing by URL or direct input too
#
AndrewMiguelez
WordPress Core only implements a couple mf1 tags and then leaves everything else up to the theme. But there are no settings, so switching to mf2 isn't exactly a simple thing.
#
gRegorLove
There's some #indieweb members pushing for better mf/mf2 in WP core, but it's a slow road. I think there's resistance because people have applied CSS to mf classes over the years. Anyway, different topic
#
AndrewMiguelez
Last question: is using mf1 and mf2 tags at the same time an issue? What's best practice?
#
gRegorLove
Not an issue. If mf2 is present, mf1 classes should be ignored.
#
gRegorLove
*ignored by mf2 parsers.
#
gRegorLove
So it gives you better coverage, if there's legacy, mf1-only parsers
#
AndrewMiguelez
Exactly what I was hoping for. Thanks gRegorLove!
#
gRegorLove
And in some cases, like hReview, mf1 is still a good idea because Google parses it, but not h-review
#
AndrewMiguelez
good to know
rodolfojcj and tantek joined the channel
#
@AndrewMiguelez
Why doesn't Google's Structured Data Testing Tool recognize h-entry and #microformats2? #microformats #mf2
(twitter.com/_/status/856957771249569792)
[cleverdevil] joined the channel
#
aaronpk
gRegorLove: i'm gonna take a look at your php-mf2 PR
#
aaronpk
oh boy we're using phpunit 3.7 which is way not supported anymore
#
gRegorLove
I can update it in composer in the PR if you want?
#
aaronpk
i wonder how different the new one is
#
aaronpk
it's at 6.1 now
#
gRegorLove
I'll try it out locally
#
aaronpk
hm phpunit 6.1 requires php 7!
#
aaronpk
php is getting aggressive about deprecating things
#
aaronpk
i hope this doesn't end up fracturing the community like python
#
aaronpk
oh boy, phpunit 5.7 requires php 5.6. how are we supposed to have tests that run on multiple versions of php if the test suite can't?
#
aaronpk
phpunit 4.8 was the last one to support php 5.4
#
aaronpk
i'll try it on that
#
aaronpk
ooh it worked
#
aaronpk
k push that up to your PR and let's see if that passes php7 now
#
gRegorLove
Ok. phpunit 4.8.*?
nitot joined the channel
#
tantek
does WordPress use phpunit?
#
tantek
would a similar strategy work here?
#
aaronpk
likely
#
gRegorLove
Ok, pushed
#
tantek
are these the fixes that get rid of the h-as-* class names
#
gRegorLove
Ack, an issue on PHP 5.4 now. Wut.
#
aaronpk
weird! it said phpunit 4.8 was supported in php 5.4!
#
gRegorLove
tantek: No, this is updates to php-mf2 for better backcompat parsing
#
tantek
oooh!
#
gRegorLove
It's the phpdocumentor stuff that phpunit includes I guess, which requires PHP 5.5
#
aaronpk
can we get rid of that? we're not using phpdocumentor i think
#
gRegorLove
Maybe phpunit's composer.json is too loose on version number? I'm not sure
#
gRegorLove
I'm not sure how to exclude certain dependencies within dependencies
#
gRegorLove
(yo dawg)
[dgold] joined the channel
#
aaronpk
(unrelated, i thought barnaby was going to make a commit that allowed me to sign releases)
#
aaronpk
hm didn't i make a VM with old php versions on it for this purpose?
#
aaronpk
i sure did!
#
gRegorLove
I think the only way to exclude would be to manually edit the composer.lock. Sounds like dragons.
#
gRegorLove
Nudging phpunit to fix their composer might be better
#
aaronpk
you can add a specific version of phpdocumentor in the composer.json too
#
aaronpk
i'll try this on my php5.4
#
gRegorLove
At least we're passing PHP nightly now
#
tantek
woot!
#
ben_thatmustbeme
GAH, the deeper i go into this ruby gem the worse it feels
#
ben_thatmustbeme
i'm having to duplicate so much stuff just to get it to store the original names of things and not change street-address to street_address
KartikPrabhu joined the channel
#
gRegorLove
Why's it converting to underscores?
#
aaronpk
because ruby
#
aaronpk
huh phpenv is not working for me
#
Loqi
[Abuelodelanada] #43 phpenv install --releases produces no result
#
aaronpk
starts over
#
Loqi
[madumlao] phpenv: Simple PHP version management
#
Loqi
[gRegorLove] #57 Remove h-as* tests
#
tantek
gRegorLove++ thanks much!
#
Loqi
gregorlove has 3 karma in this channel (120 overall)
#
tantek
I suppose there's a lesson in there somewhere, like only use *either* completely standard or completely nonsensical examples in tests
#
tantek
not experiments / drafts
#
aaronpk
yay i think i'm building php 5.4 now. had to install a bunch of ubuntu dependencies
#
aaronpk
i now have a working php 5.4 environment with composer \o/
#
KartikPrabhu
does u-featured count as experimental?
#
aaronpk
i got it to install
#
aaronpk
...aaaand....
#
aaronpk
the tests pass!
#
tantek
aaronpk that's pretty amazing
#
aaronpk
let's see if it still works on php 5.6
#
tantek
now I wonder if anyone else can replicate that ?
#
tantek
KartikPrabhu: re: u-featured, for which vocabulary?
#
KartikPrabhu
h-entry mf2
#
tantek
what does the h-entry spec say?
#
aaronpk
yessss
#
aaronpk
gRegorLove: add this to your require-dev: "phpdocumentor/phpdocumentor": "v2.8.4"
#
Loqi
[Tantek Çelik] h-entry is a simple, open format for episodic or datestamped content on the web. h-entry is often used with content intended to be syndicated, e.g. blog posts. h-entry is one of several open microformat standards suitable for embedding data in HTML/H...
#
KartikPrabhu
what is h-entry?
#
KartikPrabhu
aaronpk: can I haz Loqi "what is" on this channel?
#
aaronpk
we'd have to add a plugin to the microformats wiki or add the p-summary to each article manually
#
KartikPrabhu
hmm yeah nvm
#
tantek
a mediawiki plugin is a possibility
#
KartikPrabhu
funny that microformats wiki does not use mf2 :P
#
tantek
I've added others
#
tantek
KartikPrabhu: fair point!
#
KartikPrabhu
actually it does use some. I see h-entry, and some h-card
#
tantek
where?
#
KartikPrabhu
for the h-entry URL
#
tantek
I only see hentry in the source
#
gRegorLove
Would probably need to update the MediaWiki version first
#
KartikPrabhu
tantek: body has a h-entry
#
tantek
KartikPrabhu: from backcompat likely
#
tantek
gRegorLove: why? I have plugins that work on the current version
#
KartikPrabhu
tantek: no http://microformats.org/wiki/h-entry has h-entry on the <body> and the Editor has a h-card and p-author
#
Loqi
[Tantek Çelik] h-entry is a simple, open format for episodic or datestamped content on the web. h-entry is often used with content intended to be syndicated, e.g. blog posts. h-entry is one of several open microformat standards suitable for embedding data in HTML/H...
#
gRegorLove
I meant if it was to use the same plugin as indieweb.org does
#
KartikPrabhu
has become un-cannily good as scanning mf2 in source!
#
tantek
KartikPrabhu: not quite, it has page-h-entry on the <body> ;)
#
KartikPrabhu
tantek: oh ok not so good then :P
#
tantek
which is likely due to mediawiki page-*url-segment-page*
#
Loqi
microformats community
#
tantek
but it does have <div class="content hentry"> etc.
#
tantek
we've tried to document the wiki "setup" here: http://microformats.org/wiki/mediawiki-customization in case you're curious
#
Loqi
MediaWiki customization
#
aaronpk
the IWC wiki is only barely ahead of the MF wiki
#
aaronpk
1.17 vs 1.13
#
gRegorLove
ponders, very briefly, adding "update MediaWiki" to the Leaders summit
#
tantek
I think the microformats in the markup that you're seeing KartikPrabhu are from templates
#
KartikPrabhu
yes likely
#
tantek
gRegorLove: you could expand that to "site admin"
#
gRegorLove
Good idea
#
tantek
probably worthy of trying to help provide a backup person or two for aaronpk :)
#
gRegorLove
aaronpk: Heh, Dreamhost kills the php process trying to run composer now, for taking too long. Let me try on a different server.
#
aaronpk
just commit it and let travis run it
#
gRegorLove
Need the composer.lock though, right?
#
aaronpk
edited /measure-brainstorming (+167) "/* Examples in the Wild */"
(view diff)
#
aaronpk
oh is that checked in?
#
aaronpk
h-measure needs a property for accuracy or whatever that's called
#
tantek
and IRC logs need markup for non-sequitor
#
KartikPrabhu
precision
#
aaronpk
"0.0785 +/- 0.0087" you'd call 0.0087 "precision"?
#
tantek
hmm - I can't figure out where we documented our template / theme mods
#
tantek
for the microformats wiki
#
aaronpk
is still compiling php 7.1.1
#
KartikPrabhu
aaronpk: yeah I think so, let me find ref
#
KartikPrabhu
anyway might not be important for h-measure semantics
#
tantek
KartikPrabhu: depends on the context that the h-measure is being used
#
gRegorLove
confidence interval? Think that's usually for stats, though
[chrisaldrich] joined the channel
#
KartikPrabhu
tantek: yes, quite possibly
#
gRegorLove
Or maybe just "interval" to be more generic
[cleverdevil] joined the channel
#
aaronpk
well i just added an example where it came up and he accidentally put the value markup around the whole string
#
aaronpk
so there needs to be some sort of guidance for it
#
gRegorLove
Geez, so many dependencies
#
tantek
yikes for h-custom
#
tantek
is this a new test or existing modified?
#
gRegorLove
It's from microformats2-issues
#
aaronpk
looks like the only one like it
#
tantek
this is testing to make sure mf2 properties are ignored inside an mf1 root?
#
Loqi
microformats2-parsing-issues
#
Loqi
microformats2-parsing-issues
#
Loqi
nice
#
gRegorLove
Argh. Now the build fails 5.4 AND 5.5
#
gRegorLove
Oy. Like 20 more dependencies failing
#
gRegorLove
(ok, 16)
#
aaronpk
oh gRegorLove i bet you committed a composer.lock from a new php version that added things that don't work in an old
#
aaronpk
how bout i give you my .lock that i made in php 5.4
#
gRegorLove
Sure. WIll that cause problems with PHP 5.5+ though?
#
gRegorLove
Yeah, my composer.lock comes from 5.6
#
aaronpk
only if any versions locked don't work in 5.5+
#
aaronpk
but i just ran the test from php7 with the 5.4 .lock and it worked
#
tantek
edited /microformats2-parsing-issues (+30) "/* uf2 children on backcompat properties */ use a more nonsensical h-acme-some-acme-object rather than the possibly normal looking h-custom"
(view diff)
#
gRegorLove
Excellent. Didn't realize composer varied it. Maybe that was the initial problem?
#
tantek
gRegorLove: ^^^
#
gRegorLove
Like do we need to specify phpdocumentor?
#
aaronpk
well, composer is going to install things that work under the php version it's running under
#
aaronpk
when it makes the .lock
#
aaronpk
gRegorLove: yes, didn't you add "phpdocumentor/phpdocumentor": "v2.8.4" to composer.json a while ago?
#
gRegorLove
Today at your request, yeah
#
tantek
aaronpk, start with s/h-custom/h-acme-some-acme-object
#
tantek
then I'm not sure how the adr's object type is both h-adr and h-acme-some-acme-object
#
aaronpk
gRegorLove: yeah that's how i was able to get php5.4 to generate a .lock that worked
#
aaronpk
because one of the libs defaults to a version of phpdocumentor that doesn't work in 5.4 otherwise
#
gRegorLove
aaronpk: Ok, updating with your lock file.
#
aaronpk
oh h-custom came from the wiki. i didn't see that at first
#
gRegorLove
tantek: Want me to update the test case?
#
tantek
that would be great
#
tantek
edited /admin-to-do (+281) "/* for site update to microformats2 */ update wiki skin to mf2"
(view diff)
#
Loqi
microformats2-parsing-issues
#
aaronpk
gRegorLove: wooooo all green!
#
tantek
edited /mediawiki-customization (+372) "note skinning, plugins, more to be documented"
(view diff)
#
gRegorLove
Yayyyyy!
#
tantek
aaronpk just did a few minutes ago ^^^ (14:34) :)
#
aaronpk
refresh
#
aaronpk
so in that case, the "adr" class should *not* be added as a type?
#
aaronpk
if so, this still needs work
#
tantek
now I'm not sure if we decided that or not, or what's the right answer there
#
tantek
from the issue discussion
#
gRegorLove
I feel like I was asking tantek about this a while back. Let me check logs.
#
gRegorLove
It was about adr in h-card, actually, but maybe applicable? https://chat.indieweb.org/microformats/2017-03-06#t1488831469687000
#
Loqi
[gRegorLove] It seems to conflict with the microformats2-parsing-issues example I linked, where <div class="adr h-adr"> is upgraded to <div class="adr p-adr h-adr">. The node parser does that, making the adr the property of the h-card, not a child
#
gRegorLove
"If an element has one or more microformats2 root class name(s) (h-*) ... all backcompat properties, without an intervening root class name, are ignored inside that element" on http://microformats.org/wiki/microformats2-parsing#note_backward_compatibility_details
#
Loqi
[Tantek Çelik] microformats2 parsing specification
#
gRegorLove
I read that as: backcompat properties on the same element as an h-* get upgraded, but no backcompat properties inside that element
#
gRegorLove
So the updated backcompat does not upgrade the "locality" inside h-acme... http://gregorlove.com/php-mf2/test.php?id=15
#
aaronpk
edited /microformats2 (+53) "/* Javascript */ add command line node parser"
(view diff)
#
aaronpk
gRegorLove: regardless of the outcome of this discussion, that testMf2ChildrenOnBackcompatProperties could use a few more assertions to catch in particular this issue
#
gRegorLove
I thought the primary thing was to ensure it's not upgrading the mf1 locality
#
gRegorLove
What else should it add?
#
aaronpk
well depending on whether it should or should not end up with two types (h-adr and h-acme-some-acme-object), test for that
#
gRegorLove
Ah, gotcha
#
tantek
what do existing parsers do? any consensus?
#
tantek
re: whether two types?
#
tantek
from the issue "Per the #any_h-_root_class_name_overrides_and_stops_backcompat_root resolution, the class name "h-custom" overrides the use of "adr" as a backcompat root. "
#
aaronpk
the node parser returns both
#
gRegorLove
As does microformats-shiv
#
tantek
which then seems to imply only one type
#
tantek
yep, and that's likely because we resolved *this issue* http://microformats.org/wiki/microformats2-parsing-issues#any_h-_root_class_name_overrides_and_stops_backcompat_root but implementations didn't yet get updated
#
Loqi
microformats2-parsing-issues
#
gRegorLove
From that chat log link above, "adr" is both a property and root class name though, right? That's why it gets upgraded to p-adr h-adr
#
tantek
right it *can* be both
#
tantek
but the presence of the h-acme-* blocks it acting as a backcompat root
#
tantek
at least that's what we resolved last time we discussed it, in particular with Tom, Kyle, KevinMarks
#
gRegorLove
Current mf2 returns both types as well, just messes up the h-acme.... properties http://pin13.net/mf2/?id=20170425220609848
#
tantek
gRegorLove: what about something simpler like <span class="adr h-acme-address"><span class="locality">mf1</span><span class="p-locality">mf2</span></span> ?
#
tantek
that should only have h-acme-address and the p-locality
#
tantek
that's the point
#
Loqi
microformats2-parsing-issues
#
tantek
we probably need to fix that simpler bug in parsers first
#
tantek
before we can answer the more complex case that aaronpk was indicating
#
aaronpk
other than this issue, i am done reviewing the PR and it looks good
#
tantek
edited /microformats2-parsing-issues (+15) "/* uf2 children on backcompat properties */ use obv non-standard h-acme"
(view diff)
#
gRegorLove
I'm confused by that example. "adr" would be ignored regardless since it's not inside a root class, right?
#
tantek
gRegorLove: no. "adr" is its own backcompat mf1 http://microformats.org/wiki/adr
#
gRegorLove
How do we tell if adr is being used as a root or a property?
#
tantek
separate tests
#
tantek
it *always* acts as a root. it *sometimes* acts *also* as a property (in particular IF it is a property on a backcompat "vcard")
#
gRegorLove
Heading out shortly for an appointment. Will catch up with logs and update/add tests later.
#
gRegorLove
Ok, I think that makes sense
#
tantek
adding an explicit example to the "simpler" issue
#
Loqi
MF1 MF2
#
gRegorLove
aaronpk++ thanks for all the PHP work and reviewing
#
Loqi
aaronpk has 7 karma in this channel (1296 overall)
#
aaronpk
gRegorLove: i think i captured that all in the review https://github.com/indieweb/php-mf2/pull/111#pullrequestreview-34702768
#
tantek
edited /microformats2-parsing-issues (+679) "/* any h- root class name overrides and stops backcompat root */ add examples"
(view diff)
#
tantek
gRegorLove: added examples to http://microformats.org/wiki/microformats2-parsing-issues#any_h-_root_class_name_overrides_and_stops_backcompat_root which should hopefully help with that one in case implementations haven't been updated to pass it yet
#
Loqi
microformats2-parsing-issues
[kevinmarks] and [cleverdevil] joined the channel