#microformats 2020-05-30

2020-05-30 UTC
KartikPrabhu, [chrisaldrich], gRegorLove, [John_Payne], test, [prtksxna], kevinCH, [tw2113], [jeremycherfas], dckc and [grantcodes] joined the channel
#
Zegnat
https://github.com/microformats/php-mf2/pull/163 is ready for review again, Travis passes everything now!
#
Loqi
[Zegnat] #163 Run mf2/tests test suite with PHPUnit during default testing
[prtksxna] and [schmarty] joined the channel
#
[schmarty]
Zegnat++ !!
#
Loqi
Zegnat has 7 karma in this channel over the last year (54 in all channels)
#
Zegnat
Feel free to drop in and give it a review if you have time, [schmarty]! I look forward to any and all feedback in getting this merged
#
aaronpk
that is weird
#
aaronpk
how on earth did you figure that out
#
Zegnat
Lots of help in #indieweb-dev walking through the options and obtaining a docker container that had the same issues as Travis.
#
Zegnat
Then just a matter of finding a small test case and running it in a loop to look for solutions? Hehe https://gist.github.com/Zegnat/a94489e9b7d5501193e724e336bc6052
#
Zegnat
Of course we do not have an answer to why turning of XML parser warnings would change parsing behaviour *shrug* but hopefully this fixes it on most hosts
#
aaronpk
Sounds like maybe also file a PHP bug?
#
Zegnat
Probably. In some way. I need to think about what that would look like.
#
Zegnat
I have been able to run PHP 7.3 side-by-side where the code in docker would fail, but the code on my laptop succeeded *shrug*
[snarfed], [KevinMarks], [LewisCowles], [chrisaldrich], [jgmac1106], [John_Payne], [prtksxna], [schmarty], KartikPrabhu and gRegorLove joined the channel