#microformats 2026-11-01

2026-11-01 UTC
gasiyu joined the channel
#
Zegnat
gRegor: it depends what you want the cutoff to be. The core introduction of Dom\HTMLDocument is for 8.4. So it can easily go into a future update where we may drop old PHP support. It just happens to also update some tangental things because is opens up some function signatures.
barnaby joined the channel
#
[pfefferle]
I would really recommend to drop all php versions below at least 7.4
[jeremycherfas], thatoddshade, [snarfed], barnaby and pimeille joined the channel
#
gRegor
Yes, that's 0.6.0
#
gRegor
extra relevant with the recent PHP vuln
#
Zegnat
My PR does not do anything for PHP 7.4, so probs not necessary for the milestone then
thatoddshade, kal_jan, barnaby and jtojnar joined the channel
#
gRegor
Onward to 0.6.0! thanks for everyone's help!
#
jtojnar
gRegor++
#
Loqi
gRegor has 13 karma in this channel over the last year (119 in all channels)
sivoais joined the channel
#
gRegor
jtojnar, heh, saw your comment *just* in time before merging #274 :)
#
jtojnar
yeah, I drafted it just to be sure
#
gRegor
appreciate it
#
gRegor
That's the only other one for 0.6.0 currently, so maybe we'll get them both out today.
#
jtojnar
we should also bump the PHP version to 7.4
#
Loqi
[preview] [jtojnar] #274 Fix PHPdoc param type
#
jtojnar
and ideally add PHP typehints since that is a BC break too
#
Loqi
totally
barnaby joined the channel
#
gRegor
gives Loqi a typehint
#
Loqi
eats the typehint
#
gRegor
Can work on type hints unless you already are
#
jtojnar
gRegor already am
#
gRegor
interested in consensus on enabling the language parsing in 0.6.0 as well: https://github.com/microformats/php-mf2/issues/240
#
Loqi
[preview] [gRegorLove] #240 Proposal: enable language parsing by default
barnaby joined the channel
#
jtojnar
gRegor the type hints are non-trivial, we will probably need to postpone them to 0.7
#
jtojnar
there are lot of methods that return something else than the phpdoc says
#
jtojnar
and it is not clear if I should update the phpdoc or the behaviour
thatoddshade joined the channel
#
jtojnar
for example, parseImg claims to return string but it actually returns `string | array{value: string, alt: string}`
#
jtojnar
and we have `parseU(): string` that can return the output of `resolveUrl(parseImg(...))`
#
jtojnar
`parseUrl` would previously return the input unchanged if `parse_url` did not like it
#
jtojnar
but if we restrict parseUrl to only take string, it would not work
#
gRegor
I'll take a look tomorrow. Some of them we can add hints for, easy ones like string and bool. union type hints aren't supported until PHP8, so can't add those just yet.
#
Loqi
[preview] [jtojnar] #292 Add PHP type hints
#
jtojnar
gRegor https://github.com/microformats/php-mf2/pull/281 would also be useful since it make the tests run much faster
#
Loqi
[preview] [jtojnar] #281 tests: Use mock web server
[artlung], barnaby and thatoddshade joined the channel
#
jtojnar
gRegor managed to make it work. Added PHPStan as well to make it less likely there are regressions
#
Zegnat
I really liked PHPStan. Have not used it much myself, but it was pretty easy to add even to my PR