#wordpress 2018-06-09

2018-06-09 UTC
gRegorLove, [chrisaldrich], chimo and [xavierroy] joined the channel
#
[xavierroy] [gregorlove]++ for indiebookclub
#
Loqi gregorlove has 2 karma in this channel (244 overall)
[jeremycherfas], [chrisaldrich], GWG and jgmac1106 joined the channel
#
jgmac1106 Would love feedback on this protocol I developed for testing syndication behaivor each theme, plugin, and silo: https://docs.google.com/spreadsheets/d/19l28iCNAcMiwL2Tpko0GhiLVAVyl9DPltNS8ZvumwoE/edit?usp=sharing
#
jgmac1106 Have three contributors so far willing to help out, will be offline but fee free to leave me message
#
jgmac1106 had to come back from camping to get ready to coach baseball all day to then go back from camping, reproduction and productivity shoudl not share root words
jeremycherfas, jeremycherfas_, jeremych_, raretrack and [davidmead] joined the channel
#
[davidmead] [aaronpk] i checked and updated indieauth plugin this morning. Running Indieauth Version 2.1.1 and Indieweb Version 3.3.8. Logged out of OwnYourGram and signed back in using the /blog URL. Still getting an error posting within OwnYourGram 😞
#
[davidmead] If no one else is running into these issues on WP, maybe it’s because I have my WP install at /blog instead of the root. That’ll be a PITA to move it but I can try [aaronpk].
#
[davidmead] If that turns out to be the case that could be a roadblock of getting more people from GEN2,3,and 4 adopting
raretrack and [jgmac1106] joined the channel
#
[jgmac1106] [davidmead] many WP folks having same problem. A known but thorny issue folks working on
gRegorLove joined the channel
#
GWG [jgmac1106]: aaronpk and I were discussing it last night, and pfefferle, aaronpk, and I yesterday morning. I'm going to dive into the code and try to separate out the pieces to see if we can identify the problem, which seems to have no pattern
raretrack_ joined the channel
#
aaronpk hm i'll try installing wordpress in a subfolder to see if that messes it up somehow. there's no limitation with OwnYourGram regarding that, so it would just be a wordpress plugin bug if there's a problem
#
aaronpk [davidmead] did you put all the wordpress files in a folder called "blog"? trying to make sure I replicate this the right way
#
GWG aaronpk: I'm trying to untangle websignin from indieauth.
#
GWG aaronpk: I had a websignin question for you in that regard. If there is no authorization_endpoint, where should this thing go?
#
GWG aaronpk: Indielogin goes to relmeauth, this should probably go back to WordPress auth
#
aaronpk I would show an error TBH
#
aaronpk if they enter a website that doesn't have an authorization endpoint then you can tell them they need to support IndieAuth on that site for the Web sign-in to work
#
aaronpk I'm not sure how you could make Wordpress password login make sense in that flow
#
aaronpk Hmm I know a lot of the reason people liked the Web sign-in prompt is because it lets them log in with twitter instead of using a password. Is there maybe a twitter auth plugin we can point people to if they want that specific functionality?
#
aaronpk Maybe this? Might be overkill tho https://wordpress.org/plugins/oa-social-login/
#
Loqi [OneAll - Social Network Integration] Description Social Login Plugin Social Login is a professionally developed and free WordPress plugin that allows your visitors to comment, login and register with 30+ Social Networks like for example Facebook, Twitter, Google, LinkedIn, PayPal, Live...
#
GWG aaronpk: I was going to write it so by default, it shows an error and displays the WordPress login page, and there was a way to optionally hook in another fallback if you want
#
aaronpk What kind of fallback hook do you expect people to write?
#
GWG Something that starts the prompt into something like the plugin you have there.
#
GWG No one may ever write one.
#
aaronpk Why would you need to install the IndieAuth plugin for that?
#
aaronpk Wouldn't you just not install it and use something else instead?
#
GWG Exactly.
#
GWG I was trying to write it as if websignin might be its own plugin at some point
#
aaronpk Save yourself the trouble and don't write the hook then? Less code and less to document and less support requests
#
aaronpk I just tested the plugin on a sub folder install of Wordpress and it was fine
#
aaronpk tho i just realized I'm not using the Wordpress.org version of it so I should update and try again
[cjwillcock] joined the channel
#
GWG Trying to figure out how to eliminate those cookies
#
GWG I think I need to store a session type cookie and pull the actual data out of the database
#
aaronpk There must be some sort of built in mechanism for this
#
GWG Yes, for logged in users
#
aaronpk no, even before you log in
#
aaronpk I say this because there are plenty of other authentication plugins that have the same problem
#
GWG aaronpk: It doesn't use PHP Session
#
GWG It looks like most of them store transient values
#
GWG I've been looking since last night.
#
aaronpk just downloaded the auth0 "social login" plugin
#
aaronpk apparently that one uses a cookie too...
#
aaronpk checks their github issues
#
aaronpk nothing there
#
aaronpk huh, i'm going to need to look into this. I can't figure out if it's actually safe to store the "state" parameter in a cookie
#
GWG aaronpk: What if you stored the parameters elsewhere, and stored a session ID in the cookie?
#
aaronpk that's totally fine
#
GWG That was what I was going to do
#
aaronpk if the state and "me" are stored on the server and never accessible or able to be manipulated by the browser or the user then that's great
#
GWG Store a random hash value and pass that along
#
GWG That was what I was thinking of doing.
#
GWG aaronpk: Does this id need to be a cookie or is there another way for the browser to tell the server what transaction it is currently doing?
#
aaronpk cookie is fine. you could also set that value as the state parameter
#
aaronpk that's one of the things the state parameter is for, to associate information with the beginning and end of the flow
#
aaronpk okay what the heck. I just updated the indieauth plugin and now I get this error trying to sign in to ownyourgram "Did Not Receive a Valid Authorization Endpoint"
#
aaronpk which doesn't make sense because the plugin was set to use the built-in enpoint both before and after the update
#
GWG Hmm..
#
aaronpk oh no
#
GWG So, I can generate a state parameter as I do now, and set that parameter as a transient in WordPress, eliminate the cookie, and store the information temporarily on the server keyed to the state parameter.
#
GWG I hope I can do that correctly.
#
aaronpk That sounds right
#
aaronpk And if the state value that comes back from the redirect is not in the transient database you can throw an error
#
aaronpk I think I found a pretty bad bug with the current version
#
aaronpk the token endpoint file here https://github.com/indieweb/wordpress-indieauth/blob/master/includes/class-indieauth-token-endpoint.php#L140 calls IndieAuth_Authenticate::verify_authorization_code
#
aaronpk which is defined here https://github.com/indieweb/wordpress-indieauth/blob/master/includes/class-indieauth-authenticate.php#L256
#
aaronpk which only ever does remote validation
#
GWG aaronpk, it did local, pfefferle took it out
#
GWG But I am refactoring that section a bit as part of what I am thinking
#
aaronpk why does this keep changing!
#
GWG Why does what keep changing?
#
GWG It was causing a different bug
#
aaronpk why is there an option to set a remote auth/token endpoint at all?
#
GWG This is why we talked about splitting the websignin code into its own plugin
#
aaronpk all these errors are making me want to just rip out all the code and trim this thing down to the bare minimum
#
GWG Then the IndieAuth plugin would just be the Endpoint
#
aaronpk and yeah a separate web sign-in plugin would be great because I feel like most of the problems are because this code is trying to do two different things, and every time someone changes one part it breaks the other.
#
GWG I am breaking the pieces apart inside the plugin first
#
GWG So they act like two different plugins
#
aaronpk great
#
GWG Then the decision to split them becomes trivial.
#
aaronpk well at the moment I can't actually test any more of these micropub errors because the plugin completely fails to issue an access token
#
aaronpk so I will just wait
#
GWG I am not certain how we got in this position, but I intend to try to get out of it
#
GWG I was so young and idealistic in April
#
aaronpk lol
#
GWG I feel like there are things I am misunderstanding that may have contributed
[davidmead] joined the channel
#
[davidmead] [aaronpk] Yes. All of my WP folders & files are in a folder named `blog` off of the root
#
[davidmead] the homepage at the root is a POSH page
#
aaronpk [davidmead]: did you say you were able to log in to ownyourgram again just now?
#
[davidmead] I do have webmention, endpoint, and pingback links in the `head` there too. That may be causing an issue, so I can remove them manually
#
aaronpk that shouldn't affect anything, those are completely unrelated
#
[davidmead] I can log into OwnYourGram, Quill, etc. but they don’t post
#
[davidmead] I’ll check again as that was this morning EST
#
aaronpk oh I see the error in the OYG log
#
aaronpk "Using $this when not in object context"
#
[davidmead] i just logged out and logged back in
#
[davidmead] shows no syndication targets
#
[davidmead] at my micropub endpoint
#
aaronpk let me see if I can see that log
#
GWG What line?
[kevinmarks] joined the channel
#
aaronpk yeah same thing
#
aaronpk GWG: https://github.com/indieweb/wordpress-indieauth/issues/65
#
Loqi [aaronpk] #65 Error: Using $this when not in object context
#
[davidmead] Would it help if i can give you access to my WP?
#
GWG In the original version, I used globals, but I got a comment and changed it
#
GWG I will have that fixed as I refactor
#
aaronpk [davidmead]: normally I would say yes, but we clearly have a number of problems that are already identified
#
[davidmead] ok
#
aaronpk [davidmead]: what version of the micropub plugin is installed?
#
[davidmead] Version 1.4.3
#
aaronpk thx
#
aaronpk GWG: it looks like the micropub plugin is expecting the filter to be called "indieauth_scopes" but the indieauth plugin calls it "get_indieauth_scopes"?
#
aaronpk oh nevermind I read that wrong
#
GWG I need to fix the issue of passing scopes
#
aaronpk do you know what the issue ie?
#
aaronpk is?
[cleverdevil] joined the channel
#
GWG I switched from a global to a filter because there was a comment. You see the error
#
GWG I need to fix the contexts.
#
GWG But that should have shown up on my logs
#
GWG Odd
#
[davidmead] [aaronpk] GWG - here’s the screen showing `scopes` when i log into OYG in case that helps
#
[davidmead] https://www.dropbox.com/s/k3p0zh0v0ttq5ix/Screenshot%202018-06-09%2017.01.43.png?dl=0
#
GWG [davidmead]: That's what it is supposed to show.
#
[davidmead] ok good
#
GWG [davidmead]: I'm doing a major refactor right now to try to clear some problems. Will be done soon
#
aaronpk GWG: if you finish in the next hour or two I can do some testing
#
GWG I just started in the master branch of my fork
[grantcodes] and [mrkrndvs] joined the channel
#
[mrkrndvs] GWG did I miss a conversation somewhere along the way, have facepiles been turned into piles with the faces stripped? Just wondering https://collect.readwriterespond.com/using-facepiles-in-comments-for-wordpress-with-webmentions-and-semantic-linkbacks/
#
Loqi misses a conversation somewhere along the way too
#
GWG [mrkrndvs]: Yes. Go into the Webmentions settings and save the page
[chrisaldrich] joined the channel
#
[chrisaldrich] Unchecked the setting, save it. Then recheck it and resave and the facepiles will come back.
#
GWG It's a bug where if the setting isn't set, it isn't showing avatars
#
GWG I fixed it, but we haven't pushed the change due me switching over to an IndieAuth issue
#
[chrisaldrich] gwg++
#
Loqi gwg has 65 karma in this channel (360 overall)
#
[mrkrndvs] GWG++
#
Loqi gwg has 66 karma in this channel (361 overall)
#
[mrkrndvs] Faces are back. Thank you.
[deeden] and tantek joined the channel