#wordpress 2018-08-25

2018-08-25 UTC
#
miklb_
GWG if I might suggest slightly more descriptive PR titles than fixes.
#
GWG
I described it in the individual commit messages
#
miklb_
or the originating branch name you create to add the work to
#
GWG
But point taken
#
miklb_
just a thought so seeing it in GH notices have a better idea of which/what it is for.
#
GWG
miklb_: I added a changelog also
#
miklb_
I understand
#
GWG
miklb_: Either way, after pfefferle submits a WebSub update, I think I'm done for now
#
miklb_
that reminds me, I need to go back through the logs and find those links for the issue we discovered
#
GWG
While I'm waiting for feedback, I may start on some Post Kinds work
apetresc24 joined the channel
#
apetresc24
| __
#
miklb_
another reminder, I need to figure out what's broken in Safari 12.1 causing that javascript to beachball the tab.
[kevinmarks] and snarfed joined the channel
#
GWG
snarfed: So, where are we?
#
snarfed
GWG: you tell me, you're driving!
#
GWG
I'd like one more concurring comment from someone who had issues before releasing.
#
GWG
Then, any further released issues as a priority if they come up
#
miklb_
I'm checking out master right now
#
snarfed
oh definitely, at minimum we should confirm (ideally by reproducing) that *all* reported issues are fixed
#
GWG
miklb_: I thought we had yours.
#
snarfed
...before releasing
#
GWG
snarfed: All the reported auth issues?
#
snarfed
of course! all issues period, right?
#
GWG
Well, not the enhancements, I assume
#
snarfed
and miklb_ confirmed with a previous version of your PR, not the merged one
#
snarfed
any change can break something
#
snarfed
we should try to confirm all reported bugs/problems are fixed
#
Loqi
definitely
#
GWG
dougbeal hasn't confirmed the PHP notices are gone. I think I fixed them all
#
miklb_
complete auth success. However posting a photo from Quill, the photo didn't attach, at least using default post-kinds, so need to look where that failed.
#
GWG
@vishae had an issue, but it appears to be a Bridgy Publish issue, so I should close it.
#
snarfed
eh php notices are low priority imho. fine to fix, just low priority
#
GWG
miklb_: Not a Micropub issue, although certainly there is still a FIXME snarfed put on to enhance how the plugin handles galleries, I believe
#
miklb_
and that was completely logged out from WP and went through 2fa to auth.
#
miklb_
GWG how not a micropub issue? was a single photo. Not saying it is, just curious what it is then.
#
GWG
miklb_: Because when Post Kinds is installed, it turns off Micropub rendering.
#
GWG
So, Post Kinds takes it over.
#
miklb_
so it is a bug in post kinds?
#
GWG
miklb_: It is my next project.
#
GWG
I want to do a major enhancement to rendering the backend properties and the frontend property.
#
miklb_
yeah, that will be a priority for me too.
#
miklb_
I just want to be able to post a photo via micropub
#
miklb_
or I just need to write my own photo template
#
Loqi
[dshanske] #85 redesign to coordinate with other mf2 plugins and themes
#
GWG
snarfed: No. Post Kinds backend fixes. But might include some of that
#
miklb_
but somehow a gallery shortcode was inserted into my content
#
GWG
I'm trying to beat chrisaldrich, who keeps creating new kinds
#
snarfed
ah ok. probably hard to do #85 piecemeal...but ok!
#
GWG
miklb_: That's Micropub. I think it does that regardless. I have to look again.
#
GWG
But splitting out the rendering code will make that easier.
#
GWG
Also, still worried about gutenberg
#
GWG
But the reason I'm going back to Post Kinds is a lot of issues opened on it.
#
GWG
Shows people are using it
#
GWG
I have a lot of improvements I want to make
#
miklb_
well, I wouldn't worry about all of that, I'd get what is there now working.
#
miklb_
all that == gutenberg
#
GWG
Also, the Yarn Microsub reader is using the Post Kinds parser, and I have things I can do with that
#
GWG
I'm not
#
GWG
I'm basically building a tiny Fields API into it
#
miklb_
I just want to post photos from micropub :-D
#
GWG
The media endpoint may help with that
#
GWG
Should make clients better
#
miklb_
I guess I thought adding the media endpoint would magically make it all simpler
#
GWG
It means that you can add media in JSON posts, which means some more complex options for clients
#
miklb_
more I think about it, I do not recall that gallery code being inserted into the content in the past. That seems new for me
#
miklb_
well, been a long week, time for some rest. GWG, I probably haven't said it lately, but thank you so much for all the work you put into the plugins.
#
GWG
Thanks
epic8, Croepha13, [kevinmarks], jeremych_, ChickenSoup_, Smeef5, hsiktas13 and romanzolotarev joined the channel
#
ululate
| _.--"""""--._
#
ululate
| .' '.
ululate and miklb__ joined the channel
#
miklb__
when is next IWC
#
Loqi
IndieWebCamp Oxford 2018 is on 2018-09-22 at White October https://indieweb.org/next-iwc
#
GWG
Okay, just broke a bunch of things with the new registration system
#
miklb__
registration?
#
miklb__
what is
miklb__ joined the channel; miklb__ left the channel
#
GWG
To register post kinds
#
miklb__
thank you Loqi for the private message I don't know how to remove the underscores after my nick
#
GWG
Basically, instead of an array of properties, it is now an array of objects with which properties make up the kind.
#
GWG
So in future I can tell it which fields to include on the backend instead of hardcoding.
#
miklb__
sounds complicated
#
GWG
How so?
#
miklb__
not saying it in a bad way, my eyes just gloss over sometimes when I think about arrays
#
miklb__
but objects sound the path forward to someday integrating with gutenberg blocks
#
GWG
Exactly
#
GWG
I have that as a possibility
#
miklb__
now that I've pretty much figured out the current state for themes and mf2 and can start working on my theme framework again with confidence, blocks are on the roadmap for me too
#
GWG
Blocks aren't something I'm sure I'm going to do, but I'll be in an easy place to do them
#
GWG
As well as improving the classic version, or a custom version
miklb joined the channel
#
GWG
What are your big Post Kinds Issues?
#
miklb
that I can't post photos from micropub
#
GWG
I will be testing more view template improvements
#
miklb
is it the template that is causing that?
#
GWG
Might be, have to look at everything
#
GWG
I have media issues overall to explore
#
miklb
as I mentioned last night though, I don't recall micropub inserting that gallery shortcode in the past
#
miklb
I'm not a fan of it either way
#
GWG
The code was always there, but it might not have been triggered
#
GWG
I also want to upgrade the parser for Microsub
wagle, miklb, wagle_, [kevinmarks], OPK29 and [asuh] joined the channel
#
[asuh]
Finally got a chance to try out Micropub’s latest update via my site and Quill returns a 403 error upon posting. Is there anything I need besides the micropub rel link in <head>?
#
miklb
which update for micropub [asuh]
#
miklb
there is a beta version in the master branch that's a refactor and fixes several issues
#
[asuh]
master on repo
#
miklb
what are you using for authentication?
#
miklb
the IndieAuth plugin or the built in auth?
#
[asuh]
indieauth 3.1.5
#
[asuh]
i updated everything just a while ago
#
[asuh]
and pulled from micropub master on GH
#
miklb
gotcha. then you should have everything. Not sure where GWG wants to document but https://github.com/snarfed/wordpress-micropub/issues/150 is for the 2.0 release. I'd report issues there first
#
Loqi
[dshanske] #150 Release Version 2.0 of Micropub plugin
#
GWG
Why are you adding a rel link in the head? It does that automatically.
#
GWG
And is this a new token or old one?
#
[asuh]
Not manually added, just confirming it’s the only thing required in <head> for this to work
#
[asuh]
Good question, is it new if I just logged into Quill and gave it permission to post?
#
[asuh]
it = token
#
GWG
Yes
#
GWG
Post or create?
#
[asuh]
Post button
#
[asuh]
report on 150 above?
#
GWG
Can you enable WP_DEBUG and check the error logs?
#
GWG
That should help
#
[asuh]
`Invalid argument supplied for foreach() in [...]/wp-includes/rest-api/class-wp-rest-server.php on line 1259`
#
miklb
I'm seeing that error coming from omnibear ironically
Freejack10 joined the channel
#
miklb
added that to the ticket
[pfefferle] joined the channel
#
GWG
That's an IndieAuth issue that I fixed in 3.1.5 I thought
#
GWG
Line 118 is blank
#
GWG
So, you are running 3.1.5 and 2.0 of Micropub?
#
GWG
Trying to make sure I am tracking down the right thing
#
miklb
oh, I hadn't updated indieauth in a couple of days. Can't keep up :-D I'll test it all again
#
GWG
The new stable version fixes that bug
#
GWG
Also adds icons
#
miklb
ok, not getting that param arugment, but still getting the invalid for each when attempting to auth with Omnibear, logged out of both before testing.
#
miklb
Indigenous and Quill still fine
niek joined the channel
#
niek
___________________
[kevinmarks] joined the channel
#
miklb
I think I fugred out what I was doing wrong whitelisting webmentions. I was whitelisting brid.gy not brid-gy.appspot.com
#
miklb
figured even
[pfefferle], wagle, [keithjgrant] and vectr0n0 joined the channel
#
miklb
ok, how do I get micropub to not put any html at all in my notes ?
#
miklb
a flag would be fine
wagle joined the channel
#
miklb
feels like this was something that I figured out once before but don't remember how.
#
GWG
Post Kinds should turn it all off
#
miklb
so something in the new micropub has changed that?
tantek__ joined the channel
#
GWG
Possibly. Worth investigating
tantek___ and wagle joined the channel