#wordpress 2018-09-18

2018-09-18 UTC
[jgmac1106] joined the channel
#
[jgmac1106] <link class="chattin-to">Parenting</link>
#
[jgmac1106] @jackiejamieson there has to be a way to hack the link manager interface to do everythign you would need for a microsub management UI
strfyr and [kevinmarks] joined the channel
#
GWG I am anti link manager. It isn't built for this
#
GWG I think I can help him fix the missing pieces
#
[jgmac1106] no no, @gwg just the UI
#
[jgmac1106] Even if I have a microsub reader I would like to have a way to publicly show who I follow, and I don't want to do it twice, or make it when I add someone to a microsub reader it also publishes a follow post-kind
muteki19 joined the channel
#
GWG I have something in mind for that
#
[jgmac1106] be neat. i was even going to suggest to [aaronpk] that a public "Who I follow page" in Aperture would be nice feature. I decided not to make an OPML file available for who I follow...I think mass follow lists aren't good. Want folks to take time and curate
#
GWG I just want metadata, which links manager doesn't have
#
[jgmac1106] that makes sense...in the end the output is just a bunch of <ul's> that is an easy function...I just want to add the description., but be nice if parsing filled in as much as possible, img from h-card, etc
#
GWG Remember how much data I am parsing
#
[jgmac1106] said you wanted metadat and sounds like the splitting of the parser is a good idea if I understood what you and @jackiejamieson were talking about
#
GWG Basically, instead of writing similar code, I spin mine off as a library we both include
tantek, Logg11, Ruxton, dwmw2_gone28, dandre17, jeremych_, mikkeloscar6, walterve21, bb1, guerby3, aml7, [jgmac1106], Krakke13, crope20, dgenr8, [schmarty], [eddie] and jackjamieson joined the channel
#
GWG jackjamieson, I sent you a PR
#
GWG I cleaned up the things you brought in from other plugins
#
jackjamieson Thanks, I'm just looking at it now
[tantek] joined the channel
#
[jgmac1106] !tell chrisalrich we spent some time looking at your /following post types, I am gonna use what @zegnat suggested as: <a class="u-follow-of h-card" href="$url">$name</a> - should be enough for following a person
#
Loqi Ok, I'll tell them that when I see them next
#
[jgmac1106] but you do combine the quote and a little reason why..so its get complicated...you should scroll back through dev as people had a few pointers
#
jackjamieson GWG: I just merged it. Thanks for the changes - You can tell I copied a bunch over from webmention before learning how to deal with it properly. So thanks for updating the gruntfile, phpcs etc.
#
GWG I have more I saw, but I saw an easy win
#
jackjamieson GWG: I probably won't have much time for coding today, but will do some more tomorrow. I'll probably merge the parse-this-update branch soon since it's working pretty well (unless you have more changes I should wait for), and then I'm adding some UI for managing channels in the admin-options branch. Then, I want to focus on optimization, documentation, and testing
#
GWG I may have some thoughts. I got it working
#
jackjamieson Great! Was there a specific problem before?
#
GWG It was a dependency issue, which is why I updated them
#
jackjamieson Ah, I've still been learning the ins and outs of composer. Worked on my server as it was before, but maybe the dependency was already present in another plugin or something. Thanks for catching that
#
GWG I don't do much with composer
#
GWG But likely if I make it a library, the parent plugin wouldn't have autoload
#
GWG I will be offline from tonight through tomorrow night. I probably won't do anything in that period
#
GWG Until tonight
#
GWG I am going to try to fix Post Kinds issues during the day
#
jackjamieson Sounds good, I've got some other work to catch up on today, and then I'll have some more time for yarns tomorrow. Thank you for the PR!
[kevinmarks] joined the channel
#
GWG I will be sending more PRs in future, maybe issues
#
GWG And I have some design thoughts
#
jackjamieson Fantastic, I'm eager for any feedback/ideas you have
#
GWG I may do that today
#
GWG I have Post Kinds fixes
#
GWG I want to get that pushed
jackjamieson, [tantek], [schmarty] and jgmac1106 joined the channel
#
GWG jackjamieson: Why is the custom post type public?
jgmac1106 joined the channel
#
jackjamieson GWG - oh, that's temporary for debugging
#
jackjamieson GWG But to be honest it's not that useful for debugging, so I may as well hide it now
#
GWG Why save the entire post JSON as one meta field? Why not multiple ones?
#
GWG Why is the title $channel . $permalink ?
#
jackjamieson By saving it all as one field, I can just write a simple function to store posts. If each json field has its own field it would be more complicated to read and write. Probably good ways to write that but storing the full json in one field I can more easily retrieve it (e.g. just pass that one field to timeline)
jgmac1106 joined the channel
#
jackjamieson The title scheme is a pretty hacky method for avoiding duplicate posts in one channel - could definitely be changed
#
GWG Just trying to understand.
#
jackjamieson Of course - some of those decisions aren't documented thoroughly in the source
#
GWG jackjamieson: Why not use the GUID?
#
jackjamieson Hmm, not familiar with GUID
#
GWG It is a unique identifier for the post.
#
jackjamieson Actually I've got to run to a meeting now - I should be able to get back on IRC in a couple hours though
#
GWG We'll talk another time.
#
jackjamieson Thanks - I'll talk to you later
jgmac1106, pfoo19, doubleloop and jackjamieson joined the channel
#
jackjamieson GWG: I'm back if you're still around
#
GWG jackjamieson: For a bit.
#
GWG jackjamieson: Parse This now has a repo
#
jackjamieson re: using GUID to refer to posts, my purpose was to prevent a post from being polled multiple times for the same channel, but to allow a post to be added to multiple channels
#
jackjamieson Woo!
#
GWG I haven't quite split it
#
GWG But I created the repo anyway
#
GWG https://github.com/dshanske/parse-this/
#
GWG It is setup as a plugin.
#
jackjamieson Are you thinking of adding it to packagist or anything like that?
#
GWG jackjamieson: Yes. That will be the way I plan on including it in Post Kinds
#
jackjamieson Great, that will be very convenient
#
GWG I've never done packagist
#
jackjamieson Nor I
#
GWG I'll have to learn
#
jackjamieson I'm taking a look at it now (not that I need to submit anything there, but curious how it works)
#
GWG There's a reason that loading class appears in Parse This.
#
GWG But, I'd rather not include composer as a dependency anymore, only as a dev dependency
#
jackjamieson As someone who is still getting used to composer, may I ask why?
#
GWG Because I'd have to include the entirety of composer in the plugin.
#
aaronpk composer is a dev tool, not something you'd ask end users to use
#
GWG So, I want to use it to assemble the plugin.
#
GWG But not have it load every time.
#
aaronpk what do you mean "have it load"?
#
aaronpk once you run composer install, the result is the vendor folder which is just php
#
GWG Yes.
#
GWG But, I'd have to include composer in the WordPress plugin
#
aaronpk not if you ship the vendor folder
#
jackjamieson Do you mean you need it if you want to rely on the autoload.php it generates?
#
GWG The entire vendor folder?
#
aaronpk right, that's all just php code in the end
#
GWG Yes, correct.
#
aaronpk and it runs without the person having the composer binary installed
#
GWG aaronpk: But, you need the vendor/composer directory then
#
GWG I suppose that isn't so bad
#
aaronpk right, just like you'd be including the source code of your dependencies without using composer
#
GWG You've used packagist.
#
GWG I've never done it. I suppose I'll read the literature
#
GWG So, what doesn't go in the Github repo?
#
aaronpk i wouldn't put the vendor file in the github repo
#
aaronpk but make building it part of the process you do to build the release version for wordpress svn
#
jackjamieson If I'm understanding correctly, I think you can just list the dependencies in composer.json, and then when someone requires your package its dependencies will be loaded
#
jackjamieson https://packagist.org/about#naming-your-package
#
aaronpk if they are using composer yes. but that doesn't help them if they are installing a wordpress plugin.
#
jackjamieson Right - I think we're on the same page
#
GWG Exactly.
#
GWG That's why the Github repo always has the dependency files.
#
GWG There's no practical way around it.
#
GWG It the Github repo is mirroring the plugin
#
aaronpk the github repo should be the source for the plugin, which doesn't need the vendor folder, since the process that publishes to the wordpress svn repo can run `composer install`
#
GWG aaronpk: People download the plugin directly from the github repo too
#
aaronpk you could publish a release on github so people can download that
#
GWG Yes. I will have to rethink my design
#
GWG People are always installing from GitHub.
#
GWG I think that including the files is the only way not to pass the burden to the users
#
GWG Even with a release
#
jackjamieson aaronpk: That seems reasonable, but I think it's fairly common practice (at least I do it regularly) to just download a wordpress plugin from the master branch and install it directly
#
aaronpk i guess it won't really hurt anything to include the vendor folder in github, it's just not common for normal projects
#
GWG That's why I am waffling
#
GWG But this latest project is a library, so I might do it without the files
#
jackjamieson My instinct is that a library makes sense without the files, since anyone installing it via composer will get them anyway
#
aaronpk wait, if it's a library, then it's only intended to be used when developing other plugins?
#
GWG And have Post Kinds and Microsub include it all
#
GWG I just split it into one, so no one will be downloading it to install
#
jackjamieson And including the files in a library could cause problems.
#
jackjamieson But I think there's a bit of convenience for keeping the files in a wordpress plugin, and it doesn't seem likely to harm anything
#
GWG Although I know there are libraries that run as plugins
#
GWG Keyring does that
#
GWG But then we're back to a new plugin
#
jackjamieson This keyring? https://github.com/beaulebens/keyring
#
Loqi [beaulebens] keyring: Keyring is an authentication framework for WordPress. It comes with definitions for a variety of HTTP Basic, OAuth1 and OAuth2 web services. Use it as a common foundation for working with other web services from within WordPress code.
#
GWG Yes
#
GWG I wish WordPress had dependency management of any kind
#
jackjamieson For real, it'd be nice
#
GWG Makes it hard to figure out what to do.
#
GWG I wonder what pfefferle thinks
#
GWG Because php-mf2 is a dependency of most indieweb plugins
#
GWG It might be something that needs to be discussed.
#
GWG Remember, I didn't want to include it in IndieAuth for this reason.
#
GWG Maybe I am better off with a submodule
#
jackjamieson Hmmm, hard for me to weigh in
#
GWG Me too
#
GWG I'll have to think.
#
GWG Either way, it should be separate from Post Kinds.
#
GWG Separate, I could see a lot of other things it could do.
#
GWG Handle the backend for Semantic Linkbacks, for example.
#
GWG Handle the feed parsing for Microsub
#
GWG Still handle what it does for Post Kinds.
#
jackjamieson Agreed. I'm quite content just borrowing it from post-kinds in the interim, but it seems like it will be a useful general purpose tool
#
GWG Yes. Just unsure of how it should work.
#
GWG It has its own endpoint for returning json.
#
jackjamieson Well, I'm happy to chat about it any time, though I think you've got a much clearer idea than me
#
GWG I may take a few days to decide that.
#
jackjamieson Can't hurt
#
GWG But the repo stays where it is.
#
jackjamieson I've got to get going. Thanks again for the PR and yarns feedback!
#
GWG I may have more
#
jackjamieson Always appreciated
#
jackjamieson Cheers!
[tantek], tantek__ and dougbeal|mb1 joined the channel; jackjamieson left the channel