#wordpress 2019-01-03

2019-01-03 UTC
[kevinmarks], [tantek], [davidmead], [scottgruber], AkyRhO, [voss], [metbril], [pfefferle] and [stefp] joined the channel
#
[stefp] Thanks. I couldn’t narrow it down to that because I didn’t think I ever had it turned on.
#
[stefp] It was turned on but just not configured to show any buttons.
#
GWG It is odd why that would cause an issue, but if you don't need it..
[voss], [Vincent] and [xavierroy] joined the channel
#
GWG xavierroy, thank you
[eddie] joined the channel
#
[xavierroy] [dshanske] for what? The PR?
#
GWG Yes
#
[xavierroy] if you accept it, it becomes my first PR to be accepted 🙂
#
GWG How did you notice it?
#
GWG I noted sunrise to make viewable in a future version
#
[xavierroy] I looked up the location first and got this error
#
[xavierroy] i'm also having some trouble with post kinds feed
#
[xavierroy] the pretty links don;t seem to work for feeds.. .../kind/read/feed doesn;t work ... /feed/?kind=read does work
#
GWG I might have broken that when I did the rewrite.
#
GWG Can you open an issue?
#
[xavierroy] sure.
#
[xavierroy] I've forked your plugin and making changes atop that. Is there a better way of doing custom changes to your plugins?
#
GWG What changes?
#
GWG Depends on what you want. I try to make it easy to extend without changing the core plugin
#
GWG Some things may be worth doing a PR for
#
[xavierroy] i tweked post kinds watch view to display the featured image.. if i bother to fill that field
#
GWG For example, I wrote chrisaldrich a gist that he could use as a second plugin to avoid modding the plugin
#
GWG xavierroy, that can be done in the theme, copy your kind-watch file into a directory called kind_view under your theme
#
[xavierroy] could you share that gist?
#
[xavierroy] tweaking the plugin's view template allows me to use the change across any theme changes 😮
#
GWG I built it exactly that way for this reason
#
GWG Chrisaldrich needed a gist for registering new kinds in a second plugin
#
GWG You just need a subfolder
#
GWG Excuse me, kind_views, under your main theme folder
#
GWG The templating system looks there first
#
GWG Although I do want to return to the issue of showing featured images
#
GWG There are just a few questions
#
GWG Should it offer to assign the image as the featured image on the post?
#
[xavierroy] the way I use it (https://xavierroy.com/kind/watch/) is that a featured image for a show and individual images for each episode
#
[xavierroy] maybe an option when checked, I can enter a new featured image url if unchecked, you could use the post's featured image..
#
GWG I meant, offer to set the response featured image as the post featured image.
[davidmead], [voss], [tantek], [cleverdevil], [eddie], [schmarty], [Vincent], tantek, [smerrill] and jackjamieson joined the channel
#
jackjamieson Hi GWG, how are you?
#
GWG jackjamieson: Officially out of the office this week.
#
jackjamieson GWG: Amazing! I took some down time over Christmas, but I'm back to work now
#
GWG jackjamieson: I fixed your problem
#
jackjamieson I saw that, thanks! I'm testing now to see if that fixes the issues adding and viewing feeds
#
GWG It was one letter off.
#
jackjamieson Yeah, I saw that - easy mistake!
[cleverdevil] joined the channel