#wordpress 2019-04-13

2019-04-13 UTC
[eddie] and [tantek] joined the channel
#
GWG
Bulk edit seems to be working for Simple Location
[Rose], [tantek], [Ignacio], [kevinmarks] and [stefp] joined the channel
#
[stefp]
Simple Location seems to be working for me but this error is appearing on post edit pages
#
[stefp]
Warning: deg2rad() expects parameter 1 to be float, string given in …wp-content/plugins/simple-location/includes/class-geo-data.php on line 265
#
GWG
[stefp]: Will have a look. I plan to push the fix for someone else's problem today.
[eddie] joined the channel
#
GWG
I think I have to convert to float
#
[stefp]
Thanks
[Rose] joined the channel
#
GWG
[Rose]: I just finished the automatically add location on Micropub feature
[eddie] joined the channel
#
[Rose]
Nice!
#
GWG
It sets to private and stores the location and weather for every post unless it is more than 5 minutes in the past or future
[chrisaldrich] joined the channel
#
GWG
Simple Location 3.7.0 has been pushed.
[stefp] joined the channel
#
[stefp]
That fixed my error too. Thanks.
[kevinmarks], dougbeal|mb1 and [dougbeal] joined the channel
#
[dougbeal]
GWG: woo, my swarm came in as public!
#
Loqi
GWG has 83 karma in this channel over the last year (173 in all channels)
#
GWG
[dougbeal]: Glad it worked out
#
GWG
And I gave you your bulk fix
#
dougbeal
GWG: about to take it for a spin
#
dougbeal
GWG: wierd, one of my OYG posts has no location... it looks like it should have one on IG https://www.instagram.com/p/BwAINURjIJt/
#
GWG
dougbeal: Isn't there a place in the OYG setup where you can see the MF2 data?
#
dougbeal
GWG: yes, good idea, looking now
#
dougbeal
Oh, I was thinking of OYS
#
dougbeal
You can only see 20 latest photos
#
dougbeal
Also doesn't display location data
#
GWG
dougbeal: Form encoded or JSON encoded?
tw2113 joined the channel
#
dougbeal
JSON encoded
#
dougbeal
also setup to syndicate to flickr, and add an instagram tag
#
dougbeal
I could find the original upload, I think
[Rose] joined the channel
#
dougbeal
GWG: I don't see a location being set, let me throw it in a gist, and find an OYG with a good location
#
dougbeal
There is a Brid.gy to Flickr error
#
GWG
I see a few things there to work on
[dougbeal] joined the channel
#
GWG
But theose are old ones, it looks like, except the Flickr one
#
GWG
dougbeal, I am pushing a Micropub update for a bug someone submitted a PR for as well today
#
GWG
Involving media attachment
#
GWG
Also, dougbeal, re query for last, I think I need to use a timeframe on that
#
GWG
Apparently aaronpk only does media from the last 5 minutes
[dougbeal] joined the channel
#
GWG
I have a test image from 2 months ago that now always shows up in Quill
#
GWG
What do you think as you asked about it?
#
[dougbeal]
Let me see what it brings up
#
[dougbeal]
I think I would rather it pulled something up… but I guess if it was irelevant and I was on a really slow internet connection…
#
GWG
It will post it unless you remove it
#
GWG
I am thinking of limiting it to the day
#
GWG
Not 5 minutes
#
GWG
Anything else on your list?
#
[dougbeal]
GWG: looking over my list, don ’t see anything
#
[dougbeal]
I’m installing a VPN
#
GWG
Why?
#
[dougbeal]
been on my list for a while
#
[dougbeal]
Sketchy wifi and cell provider blocking Chrome Remote Desktop
[tantek], chrisaldrich and jackjamieson joined the channel
#
GWG
Hi, jackjamieson
#
jackjamieson
Hi GWG, how's it been going?
#
GWG
Just took a walk after releasing Simple Location 3.7.0
#
jackjamieson
Nice, looks like a big update
#
jackjamieson
I just finished a new (child) theme for my website
#
GWG
jackjamieson: dougbeal had some issues, so I stopped what I was doing to fix it.
#
GWG
And since it had set location to private instead of public, I added a bulk edit option for him to fix the ones that were miscategorized.
#
GWG
And to determine which they were, I added a column to the post table
#
jackjamieson
Checking it out now - the bulk edit is convenient
#
GWG
Also, auto save location to post if you are using one of the geolocation providers is now there.
#
GWG
Now that I have Compass, it makes sense.
[stefp] joined the channel
#
jackjamieson
That's on my list to try out too. I think it might be fun to install compass on my server but I'll wait until I've ironed out Yarns' auth troubles
#
GWG
How is that going?
#
jackjamieson
Feeling stumped. I ported over the revised endpoint class from the Micropub plugin, along with the new authorize class
#
jackjamieson
As far as I can tell, the issue is the same regardless of whether I'm using the IndieAuth plugin or the authorize class, so I think it's a problem in the endpoint
#
jackjamieson
I've been trying to figure it out around the load_auth() function in the endpoint class
#
GWG
Do you need help?
#
jackjamieson
(1) This function checks if current_user_can('read') - which seems to return false no matter what. Seems like the current user is empty when this is checked
#
jackjamieson
(2) If I remove that check, the function proceeds to check if static::$microsub_auth_response is empty, and it always is
#
GWG
Interesting.
#
GWG
Which branch are we looking at?
#
jackjamieson
I'll have to push my current version, still just local
#
jackjamieson
I'll push it to a new branch now. If you can help out I'd be grateful -- I'm sure I can get it eventually but tbh I feel pretty fuzzy on the auth flow so I might be missing something simple
#
GWG
I see some coding here that looks like it doesn't belong from Micropub, but not about that.
#
GWG
Standby
#
GWG
You have a few issues I found.
#
jackjamieson
There's some old code I haven't removed yet from the previous version (e.g. the check_scope() function), but the problems seem to be triggered before that executes (it's called in serve_request, but the 403 auth error occurs before then)
#
GWG
First, I just manually ran against your code and it returned true for endpoint/?action=channels
#
GWG
$permissions = static::check_request_permissions( $request );
#
GWG
return $permissions;
#
GWG
I assume because of this
#
jackjamieson
Right, when I run it I get a 403 before it hits that point. return $permissions was part of my debugging
#
GWG
But it works for me
#
GWG
Can you run a test for me?
#
GWG
Do you have the Indieauth plugin enabled?
#
GWG
What is your test site?
#
GWG
Is it publicly accessible?
#
jackjamieson
Do you need the URL?
#
GWG
What is the URL?
#
Loqi
It looks like we don't have a page for "URL" yet. Would you like to create it? (Or just say "URL is ____", a sentence describing the term)
#
GWG
Yes
#
jackjamieson
microsub-dev.jackjamieson.net -- but actually you might have already helped me solve it
#
jackjamieson
I removed return $permissions and then fixed a typo on line 1284, and can now log in to monocle
[dougbeal] joined the channel
#
[dougbeal]
Tags are behaving strangly, :thumbsup: is converted to :face_vomiting:
#
GWG
Glad it worked
#
jackjamieson
Argh, turns out it's just that my debugging had gotten twisted up. I had disabled the callback to check_permissions during my debugging. When I re-enable that, I'm back where I started with a 403
#
jackjamieson
I'll push a corrected version
#
[dougbeal]
Seems to work if I create the emoji tags manually
#
jackjamieson
GWG: Pushed with minor corrections to remove some of my debugging. It might be a good idea for me to go through more meticulously so I can give you a cleaner version, but I don't know if I have time to do that until early next week
#
GWG
I understand
#
GWG
I'm uploading a refresh of Syndication Links right now. I'll pull your code and see if I can figure out what is going on.
[Rose] joined the channel
#
[Rose]
All my locations are now public if they weren't before, GWG++ for the awesome update!
#
[dougbeal]
GWG: all the tag stuff is core wordpress?
#
GWG
Yes
#
[Rose]
pokes Loqi
#
GWG
[Rose]: I think it needs its own line
#
GWG
Any push
#
jackjamieson
GWG: Thanks. I don't want to take you away from your other projects. I feel like I should be able to solve this with another solid session of troubleshooting. Going to take a couple days away from it and then try with a clear head
#
GWG
Attempt at cache busting in Syndication Links and bug fix for the other issue [dougbeal] handled.
#
GWG
jackjamieson: I always have too many projects.
#
[Rose]
GWG++
#
Loqi
GWG has 84 karma in this channel over the last year (174 in all channels)
#
[Rose]
Well done Loqi
#
[Rose]
So, there's a pending update for Syndication Links, should I install it?
#
jackjamieson
GWG: That's why I should try to take this one myself if I can!
#
GWG
[Rose]: Well, I did refresh some icons and fixed a typo that was throwing a PHP notice, so...why not
#
GWG
Also there's one for Micropub
#
jackjamieson
Thanks GWG, I've got to get offline but I'll let you know how it goes
#
[Rose]
I installed the Micropub one, just saw something in here about Syndication so thought I'd wait until I'd checked.
#
[Rose]
So, using the Press This IndieWeb bookmarklet did not create an RSVP. What did I break and how?
#
[Rose]
As in, in WordPress it was marked as a note, not an RSVP
#
GWG
Yes. It doesn't work with Post Kinds
#
[Rose]
Hmm, ok! I can handle that 🙂
[kimberlyhirsh] joined the channel
#
[kimberlyhirsh]
I use bookmarklets with the Post Kinds URLs and it's working beautifully for me.
#
GWG
[kimberlyhirsh]: Different bookmarklets