#wordpress 2019-08-02

2019-08-02 UTC
#
GWG But I will have my first bug fix PR for webmention tonight
#
GWG Fixes the whitelist that was broken and some other cleanups
#
GWG Happy to brainstorm with anyone
[kimberlyhirsh] joined the channel
#
[kimberlyhirsh] WordPress embed works in comments, no plugin needed.
#
GWG Good to know
#
GWG I was going to change the Semantic Linkbacks plugin to support it
#
[kimberlyhirsh] I think the next question I have is whether those are appearing in the comment source code as links rather than just text URLs because Bridgy/Semantic Linkbacks is backfeeding them with the <a> tag, or if it's because I have an autolinking plugin.
#
GWG Semantic Linkbacks would display it as a mention, I think
[schmarty] joined the channel
#
[Michael_Beckwit have my list of plugins to try and contribute to, ready for tomorrow 😄
[Michael_Beckwit joined the channel
#
GWG Look forward to hearing about it
#
[Michael_Beckwit Open issues
#
[Michael_Beckwit PHPCS review
#
[Michael_Beckwit PHPDocs review
#
[Michael_Beckwit https://github.com/dshanske/indieweb-post-kinds
#
[Michael_Beckwit https://github.com/dshanske/syndication-links
#
[Michael_Beckwit https://github.com/dshanske/parse-this
#
[Michael_Beckwit https://github.com/dshanske/simple-location
#
[Michael_Beckwit https://github.com/pfefferle/wordpress-webmention
#
[Michael_Beckwit https://github.com/manton/jsonfeed-wp
#
[Michael_Beckwit https://github.com/pfefferle/wordpress-semantic-linkbacks
#
[Michael_Beckwit https://github.com/indieweb/wordpress-indieweb
#
GWG We lack docs
#
GWG I think we're up to date on PHPCS
#
[Michael_Beckwit i’m fine for getting paid for either. I have a lot of phpdoc experience with BuddyPress
#
[Michael_Beckwit even if paid for only 1 day
#
GWG I should definitely document better
#
Loqi I agree
[xavierroy] joined the channel
#
[xavierroy] one thing that need love is more view templates for post kinds 🙂
#
[xavierroy] A plugin to edit the template from the admin instead of tweaking the code
[snarfed] joined the channel
#
[snarfed] [kimberlyhirsh] they're links (instead of text) because bridgy renders them that way
[Rose], Derek[m]1, [xavierroy] and [Zegnat] joined the channel
#
[Rose] Ok, something has definitely changed in WP and now I'm logging into Aperture as https://rosemaryorchard.com/author/rosemaryjayne instead of https://rosemaryorchard.com/
#
[Rose] Which is causing issues, understandably
[svandragt], [prtksxna], jeremych_, Krazydee, [tantek] and [jgmac1106] joined the channel
#
GWG [Rose]: I made some modifications in the last update to the logic there. I may have introduced the issue
#
GWG !tell [Rose] I'll work on fixing this tonight. I think my logic must have been off. I tested it, but...
#
Loqi Ok, I'll tell them that when I see them next
dillon[m] and [Rose] joined the channel
#
[Rose] No worries 🙂
#
[prtksxna] Hey GWG 👋Any idea what might be going wrong with https://github.com/pfefferle/wordpress-semantic-linkbacks/issues/227 ?
#
Loqi [pfefferle] #227 HTML5 comments seems to overwrite facepiles
#
GWG No. Haven't had a chance to look.
#
GWG Since I was going to try and merge Semantic Linkbacks into Webmentions, I was going to do some fixes durng that process.
#
GWG But I just got a critical login bug report from IndieAuth I need to check.
#
GWG Too much to do, too little time.
#
[prtksxna] Oh, let me know if I can help with any testing (with the critical bug)
#
GWG Well, it is messing up people's logins and that can't stand.
#
GWG So far, my test site doesn't have this problem, but my live site does.
#
GWG I found the problem
#
GWG A lowercase instead of a capital W
#
[prtksxna] 🥶
#
[prtksxna] I should update my dreamhost `.htaccess` so that IndieAuth starts working 😓
#
Loqi yea!
#
[Rose] Oh dear, capital letters caused me problems today too - lowercase instead of uppercase!
#
GWG [Rose]: Depending on the Indieweb plugin is not good anyway
#
GWG I am going to add the setting directly to the IndieAuth plugin
#
GWG To decide which account gets root
#
GWG Also may fix the subdirectory problem
#
GWG Or try to
#
GWG It means I have to detect that a site is not at the root of the domain and allow someone to use the root
#
GWG [Rose]: Temporary fix is to go into /includes/functions.php and change Indieweb_Plugin to IndieWeb
#
[Rose] Thanks!
#
[Rose] Only I am not logged in as myself in Aperture still, hmm.
#
[Rose] Seems that either I followed instructions incorrectly, or something is still amiss
#
[Rose] Thankfully it's not urgent 🙂
[eddie], [JuJu] and [Michael_Beckwit joined the channel
#
[Michael_Beckwit fork all the things
#
Loqi http://meme.loqi.me/m/51q2x7JS.jpg
#
[Michael_Beckwit @GWG which branch should I issue PRs against for post-kinds? master?
#
[Michael_Beckwit i’m assuming yes because it has the most recent commits 😄 and we can change PR branches later
#
GWG Yes, we don't have a dev branch
#
GWG All of the Indieweb plugins use master
#
GWG Probably should think about that
IWC_SlackBot, [aaronpk] and [prtksxna] joined the channel
#
[prtksxna] GWG: Is there an `$arg` to get only black icons when calling `get_syndication_links`?
[Michael_Beckwit and [schmarty] joined the channel
#
GWG Yes, I believe so
#
GWG It's a global setting
IWSlackGateway and [KevinMarks] joined the channel
#
GWG I have to look about whether I allowed it on a per call basis
#
GWG Wait... it's a stylesheet
#
GWG Never mind
#
GWG I should be able to change that.
#
Loqi I agree
[schmarty], [prtksxna], [mapkyca] and neoaboriginal1 joined the channel
#
GWG I'd open an issue for jackjamieson to look into
#
[prtksxna] {{done}} Thanks GWG
[jgmac1106], [prtksxna], neoaboriginal2, [schmarty]1, jackjamieson, [aaronpk], [KevinMarks] and [david] joined the channel
#
[david] Howdy yall, came here with two questions, and see that [prtksxna] is already working on one with facepiles and html5 comments
#
[david] Second, I've been recently updating my personal website theme in preparation of submitting for theme review on the w.org repo. I'm trying to ensure that my theme is compliant with schema, microformats2, and looks/works well with webmentions, semantic linkbacks, and syndication out of the box.
#
[david] I'm looking for someone who has experience that would be willing to review it. I borrowed a bit from SemPress on the template parts of the theme https://github.com/davidwolfpaw/velox-theme
[Michael_Beckwit joined the channel
#
[Michael_Beckwit @GWG some extra stuff I’ve worked on today for Post Kinds that I haven’t issued a PR for yet https://github.com/tw2113/indieweb-post-kinds/commits/phpcs-and-phpdocs-cleanup
#
[Michael_Beckwit [pfefferle] was that PR meant to be approved even with the comment about DB ids?
[pfefferle] joined the channel
#
[pfefferle] GWG already merged it but I would not recommend doing it
#
[Michael_Beckwit want a fresh PR? also curious what sort of fallback we want since we can’t rely on it
#
[Michael_Beckwit perhaps `$author_id = ( $authordata instanceof WP_User ) ? $authordata->ID : $author_id`
#
[pfefferle] What about get_users and take the first of the response
#
[Michael_Beckwit `$author_id` is initially set to `get_option( 'iw_default_author', 1 )`
#
[pfefferle] This shouldn‘t be either
#
[Michael_Beckwit i’ll get a fresh PR going with the get_users recommendation soon
#
[pfefferle] Or do you think it is not problematic? [dshanske] [Michael_Beckwith]
#
[Michael_Beckwit i would think the default author value would be better, as get_users would probably turn up the primary admin user, which may not be desired to be the specified author
#
[pfefferle] But the default author value also falls back to the 1 which is, if it exists, the admin
#
[Michael_Beckwit good point. Hrm
#
[pfefferle] Or we should use get_users for the default user function?
#
[Michael_Beckwit hard to say
[tantek] joined the channel
#
[Michael_Beckwit i would definitely say at bare minimum, the first result from a get_users() call for admins. as the base
[snarfed] and [eddie] joined the channel
#
GWG pfefferle, I see your point
#
[Michael_Beckwit @GWG [pfefferle] https://github.com/tw2113/wordpress-indieweb/commit/c8ef930f577c4066872e78fb62e5faee601c87a1
#
[Michael_Beckwit hrm, not sure if I want to do any hardening of php notices for this one, because there should be at LEAST one item in this result
#
GWG I would make that a function instead of having it inside the widget code
#
GWG But that's only stylistic
#
[Michael_Beckwit your plugin, i’ll bend to help 😄
#
GWG Actually I share it
#
GWG But if you look, I designed the code to be able to be called outside the widget
#
GWG So the same should apply to this logic
#
[Michael_Beckwit will keep massaging it then
[KevinMarks]1, [david]1 and [schmarty] joined the channel
#
[Michael_Beckwit gotta go for a bit, but i’ll probably continue a bit more later 😄
[jgmac1106], kevinbird15[m], ScottSmiley[m] and SirMemesALot[m] joined the channel