#wordpress 2019-08-08

2019-08-08 UTC
[fluffy], tbbrown, Homie, gRegorLove, [prtksxna], [xavierroy] and [pfefferle] joined the channel
#
[pfefferle] [dshanske] thanks for the quick IndieAuth fix! IndieWeb.org login works again 😊
tbbrown, [fluffy], [prtksxna]1, IWSlackGateway1, PaowZ, [Lewis_Cowles], [Rose], [grantcodes], [xavierroy], [prtksxna], jeremych_, jeremyc__ and [tonz] joined the channel
#
GWG [pfefferle]: I need better testing
[jgmac1106], jgmac1106, [Rose] and [Lewis_Cowles] joined the channel
#
[Lewis_Cowles] what is it you need tested? Is it public, open source or libre?
[aaronpk], [schmarty], [jgarber], [tonz], [kim_landwehr], [grantcodes], [tantek], jujudario, j12t and [snarfed] joined the channel
#
[snarfed] wow. https://www.zdnet.com/article/wordpress-team-working-on-daring-plan-to-forcibly-update-old-websites/
#
[tantek] Hopefully not using exploits. /me reads
#
[snarfed] heh. ends justify the means?
#
[snarfed] nah, looks like built in auto-update. key benefit here is that auto-plugin-update is much more recent, and plugins are the vast majority of wp security holes, so getting more sites on to auto-plugin-update is a big win
#
[snarfed] (and auto-theme-update)
[aaronpk] joined the channel
#
[aaronpk] Wow that seems incredibly risky, how do they ensure everything will be compatible with the update?
#
GWG It's a proposal
#
GWG https://make.wordpress.org/core/2019/08/07/proposal-auto-update-old-versions-to-4-7/
#
GWG Go original source
#
[snarfed] [aaronpk] slow rollout, canaries, monitoring, opt outs. the usual.
#
[snarfed] would you rather your site is owned five ways from sunday, or a plugin stops working? tradeoffs, whee
#
GWG You can also disable automatic updates locally
#
[snarfed] (but please don't!)
[KevinMarks], [tantek], [Lewis_Cowles], [Will_Monroe], [Rose], [grantcodes], chris[m18 and IWSlackGateway joined the channel
#
[Lewis_Cowles] The worrying thing would be that someone will likely complain.
#
[Lewis_Cowles] When taking a first aid lifesavers course they told us that one of the reasons for certification was that it would protect us from being sued by a******s. Apparently some people are unhappy with help.
[tantek] and [pfefferle] joined the channel
#
[pfefferle] [Lewis_Cowles] hey hey
#
[Lewis_Cowles] [pfefferle] going back to PHP5.2, unable to use closures so I don't need to argue or try to persuade you to upgrade that plugin supported PHP. FUN
[Will_Monroe] joined the channel
#
[Lewis_Cowles] I think it's been a decade since I used 5.2
#
[pfefferle] I still do not understand your issue... the code should work as is
#
[Lewis_Cowles] it's specifically told not to clobber the header in the existing code
#
[Lewis_Cowles] false
#
[Lewis_Cowles] I've grabbed the existing values (according to PHP.net docs and online place I could test), so that we don't lose data or truncate the Link header
#
[pfefferle] have you update your test instance with your code?
#
GWG I am confused
#
[pfefferle] if not, I can’t see any issue
#
GWG Which plugin?
#
[Lewis_Cowles] webmention
#
GWG And what is wrong?
#
[Lewis_Cowles] I'm actually looking at build steps now so I can upload (I turned off plugin edits)
#
GWG The headers?
#
[Lewis_Cowles] It does not set the link header
#
GWG Odd. Does for me
#
GWG Anything atypical about your configuration?
#
GWG Or unique that might explain it?
#
GWG Reading the issue
#
[pfefferle] I get a “307 Temporary Redirect” on your site
#
GWG I don't see the issue either
#
[pfefferle] these is the link header I got from your site: `Link: <https://wp.dh.codesign2.co.uk/wp-json/webmention/1.0/endpoint>; rel="webmention", <https://wp.dh.codesign2.co.uk/wp-json/webmention/1.0/endpoint>; rel="http://webmention.org/", <https://wp.dh.codesign2.co.uk/wp-json/>; rel="https://api.w.org/", <https://wp.dh.codesign2.co.uk/?p=8>; rel=shortlink`
[snarfed] and [grantcodes] joined the channel
#
[pfefferle] [Lewis_Cowles] perhaps it was a caching issue?
#
GWG [pfefferle]: By the way, next PR for Webmention is the avatar handler.
#
[pfefferle] I have to MRs for the indieweb plugin btw,
#
GWG I think that can merge in without conflict
#
GWG [pfefferle]: You do? I'd better look
#
GWG Approved
#
GWG Sorry.
#
GWG Must have slipped past me
#
[pfefferle] no problem 🙂
#
[pfefferle] you are a busy man 😉
#
GWG I have been trying to get webmention work done since May
#
GWG [pfefferle]: As are you
#
GWG I keep only stopping for bug fixes
#
GWG It's just hard to dismantle Semantic Linkbacks safely
#
[pfefferle] 😉
#
GWG So, I am trying to do the equivalent of building a foundation to move a house.
#
GWG So the mf2 code can just slide into place
#
[pfefferle] I was at an interesting talk about modern WP plugin dev on the WordCamp Europe
#
[pfefferle] I would love to try a package that rewrites the namespaces
#
GWG [pfefferle]: Which would you try on?
#
[pfefferle] that would fix the issue with multiple mf2 versions on different plugins
#
GWG None of the Indieweb ones do it
#
[pfefferle] load the mf2 lib?
#
GWG Use namespaces
#
[pfefferle] but the mf2 lib does
#
GWG Yes
#
[pfefferle] if we change the namespace of the mf2 lib there will be no more class name collisions
#
GWG But the mf2 library doesn't change that often
#
GWG I agree
#
GWG I just don't want to bundle composer
#
GWG Using it for dev is fine
#
[pfefferle] ok
#
[Lewis_Cowles] hmm... Happier to have it work. Can I ask what client you used to get that? Perhaps my curl etc was broken. I do have some caching. I never thought to send cache busting at it. 😊
#
[pfefferle] [dshanske] why this change btw.? https://github.com/pfefferle/wordpress-webmention/compare/fetch?expand=1#diff-4a405db849c60f60b9e32bde3bfe0096R12
#
GWG [pfefferle]: So I don't have to write it over and over?
#
GWG And risk making a mistake?
#
[pfefferle] if you change the classname?
#
[pfefferle] hmmm
#
[pfefferle] have to go to bed now
#
[pfefferle] have a nice evening all
#
GWG Yes