#wordpress 2019-09-06

2019-09-06 UTC
#
GWG
Thinking about it, not sure Gutenberg is needed for a new per post setting, but will try
JKingWeb_, [snarfed], [Michael_Beckwit, JKingWeb_1, Ruxton, jgmac1106, [grantcodes], [xavierroy], [jgmac1106], tsrt^, ben_thatmustbeme, jeremych_ and [pfefferle] joined the channel
#
[pfefferle]
Are you here GWG?
#
GWG
Yes
#
GWG
[pfefferle]: I don't think I made a mistake on the PR we were discussing
#
[pfefferle]
The webmention_url_to_postid?
#
GWG
Yes?
#
[pfefferle]
It returns the custom page for the homepage?
#
GWG
Yes
#
GWG
Or if you add to the filter, for any URL on the site
#
GWG
So it is future proof
#
[pfefferle]
Nice! Indeed!
#
GWG
I saw the option of hooking in later, but this covers all URLs, not just posts
#
[pfefferle]
Yes, but you can use the is_* URLs there
#
GWG
[pfefferle]: I realized we didn't need it
#
[pfefferle]
With the Webmention thingy not
#
[pfefferle]
The webmention_url_to_postid
#
beko[m]
I'm confused… searched for something today and Pages (not Posts) came up but I had no way to click on the excerpt to read the full page. Is this WordPress or a theme bug?
#
GWG
The only other thing I can considered was caching the result because I am running the query twice per page load
#
GWG
beko[m]: That's theme
#
beko[m]
Oh… thanks 🙂
#
[pfefferle]
Hmmm... that is a Point I had a bug on the WebSub plugin for something similar https://github.com/pubsubhubbub/wordpress-pubsubhubbub/issues/5
#
Loqi
[archon810] #5 pubsubhubbub_topic_urls massive size and autoload=yes
#
[pfefferle]
Do we really need to hide the headers? Couldn‘t we focus on a better ui to disable webmentions?
#
GWG
[pfefferle]: I guess I should cache it regardless.
#
[pfefferle]
In a global?
#
GWG
[pfefferle]: What better UI?
#
GWG
[pfefferle]: Just in the object cache for the life of the query. It needs it twice during load...it only should calculate it once
#
[pfefferle]
To add a disable/enable Webmention instead of using the ping setting
#
[pfefferle]
I know I had a lot of issues/problems with headers with the websub plugin
#
GWG
On a per post basis?
#
GWG
We'd still have the header advertisement question
#
[pfefferle]
That’s why I ask if we really have to remove the headers
#
[pfefferle]
What is the issue here?
#
Loqi
It looks like we don't have a page for "issue here" yet. Would you like to create it? (Or just say "issue here is ____", a sentence describing the term)
#
GWG
There seems to be a consensus that you shouldn't advertise support where none exists
#
[pfefferle]
Ok, but it might cause issues for custom implementations if we remove headers
#
[pfefferle]
And we Force users to add the headers by hand if the do not use the filter thing
#
[pfefferle]
Just saying
#
GWG
I can add a config setting to disable this check.
#
GWG
Personally, having headers on all pages is not a problem for me
#
GWG
It is for snarfed, for example
#
GWG
And a few others have asked over the years, so I wanted to give it s try
#
[pfefferle]
If we add a settings for that, we run into issues with a lot of dB connections on every page
#
[pfefferle]
We should avoid that
#
GWG
That's why I said config
#
[pfefferle]
See the websub issue I sent above
#
GWG
wp-config as opposed
#
[pfefferle]
Ok, a config/const would be a nice compromise I guess
#
GWG
I'll do an optimization run on it
#
GWG
Add as many performance enhancements as I can
#
[pfefferle]
Something like WEBMENTION_ALWAYS_SHOW_HEADERS or so
#
GWG
Yes
#
[pfefferle]
Nice! I can live with that
#
GWG
And add the other idea... caching the result for the load so it only loads once
#
[pfefferle]
So I will have a lot to do tomorrow... merging a lot of stuff!
#
GWG
And will add a few other checks
#
Loqi
GWG has 82 karma in this channel over the last year (147 in all channels)
#
GWG
I have a few more ideas to terminate the check early if conditions aren't met
tsrt^ joined the channel
#
GWG
[pfefferle]: Trying to keep laser like focus on webmentions
#
beko[m]
Much code, less time. Iktf 😕
[tantek], jackjamieson, dopplergange, petermolnar, discord[m], npfoss[m], card[m], aaronpk[m], asuh[m], manfred[m], sacha[m], sander[m], tom85[m], new0ne[m], rittme[m], ritewhose[m], andrewxhill[m], iiogama[m], romaric[m], Nebulous[m], Giyomu[m], sfroment[m], enricomarino[m], Keegen[m], vasa[m], freethinkingaway, RealSnazzy[m], Senshi[m], gnunicorn[m], Ja3ood[m], Lolicon[m], mZ[m], Tianyi[m], mikeal[m], gozala[m], drshamoon[m], macerbi[m]1, maparent[m], CantiTurtleCoin[, celso[m], Mairkur[m], cesarosum[m], placer14[m], prtfw[m], gorhgorh[m]1, aeddi[m], Tianyi[m]1, jenncloud[m], gorhgorh[m]2, CryptoEmpress[m], AXEL-Lee[m], JeffMaherVegas[m, M[AXEL]Darr[m], rklaehn[m], WidgetBotiocli1[, msena3[m], pierreboc[m], Rick[m], Expherience[m], drbh[m], oed3[m], carsonfarmer[m], fozzie[m], phynite[m], eddy[m], JustMaier[m], balupton[m], celso[m]1, Romaric[m]1, silent_Activist[, kanej[m], johanherman[m], Lilz|BetaMe[m], AXEL-Brian[m], Gorka[m], Clment[m], chris[m]1, hvergara[m], Oxy[m], Akshay[m]1, PermawebMatrixBr, npfossDiscord[m], jimpick[m], lyon[m], JordanKrageDisco, Valium[m], HeishDiscord[m], oed3Discord[m], baluptonDiscord[, NatoBoram[m], aphelionzDiscord, johanherman[m]1, RockSteadyTRTL[m, RickDiscord[m], RealityDiscord[m, AuHau[m], LSJI07Discord[m], postablesDiscord, dignifiedquireDi, gorhgorhDiscord[, kanejDiscord[m], brewskiDiscord[m, AuHauDiscord[m], dillonDiscord[m], msena3Discord[m], GorkaDiscord[m], manfredDiscord[m, wcharginDiscord[, hazDiscord[m], dpinnerDiscord[m, TH0RynDiscord[m], hyde__Discord[m], eshohetDiscord[m, corylDiscord[m], prcDiscord[m], realChainDiscord, AkshayDiscord[m], JayWelshDiscord[, aeddiDiscord[m], RyonezCoruscareD, fexra|TRTLDiscor, sfromentDiscord[, andrewxhillDisco, NatoBoramDiscord, Kenzo3Discord[m], rxninDiscord[m], LeFDiscord[m], DiscordRSSDiscor, NebulousDiscord[, cwchristerwDisco, ritewhoseDiscord, braditzDiscord[m, BossMANDiscord[m, thatguyDiscord[m, carsonfarmerDisc, pusherDiscord[m], ValiumDiscord[m], OboDiscord[m], M5310Discord[m], catmanDiscord[m], KubeWorshipperDi, GiyomuDiscord[m], M[AXEL]DarrDisco, JerbsDiscord[m], jgmDiscord[m], AXEL-BrianDiscor, MairkurDiscord[m, Dazuck-3BoxDisco, berDiscord[m], cyluDiscord[m], M011000100111010, snapDiscord[m], JustMaierDiscord, SirMemesALotDisc, jamiedubsDiscord, doodlemaniaDisco, MichaelTenDiscor, RDeckardDiscord[, LokeLDiscord[m], thomasDiscord[m], buztedDiscord[m], porshDiscord[m], alphapapaactualD, TianyiDiscord[m], farhad312Discord, AtiqDiscord[m], PhillmacDiscord[, foxcoolDiscord[m, mZDiscord[m], Microsoft_techni, tobowersDiscord[, rittmeDiscord[m], sekiDiscord[m], Ja3oodDiscord[m], RealSnazzyDiscor, pbvieDiscord[m], drbhDiscord[m], JohnnyMilkshakes, eddyDiscord[m], flower88Discord[, KubeDiscord[m], gnunicornDiscord, new0neDiscord[m], dy5es41Discord[m, olizillaDiscord[, hubaDiscord[m], rklaehnDiscord[m, denzukoDiscord[m, rozgoDiscord[m], combrayDiscord[m, lamborghiniDisco, chmanieDiscord[m, aleDiscord[m], cristobalDiscord, XierumengDiscord, vamsiDiscord[m], jwheelerDiscord[, EugeneDiscord[m], Dby0Discord[m], lyonDiscord[m], tom85Discord[m], dqxDiscord[m], ClmentDiscord[m], vasaDiscord[m], nocentDiscord[m], OxyDiscord[m], MaggieDiscord[m], johanhermanDisco, neohexDiscord[m], mZDiscord[m]1, ShadowLingDiscor, skillman623Disco, CatManDoooDiscor, peterkDiscord[m], Turtle1331Discor, sanderDiscord[m], crestDiscord[m], GuillaumeDiscord, codynhatDiscord[, Lilz|BetaMeDisco, cwDiscord[m], NastyEbilPiwateD, planetary_devDis, ZedDiscord[m], SteffDiscord[m], abhi_Discord[m], ddahlDiscord[m], dhenzDiscord[m], fozzieDiscord[m], KYZITEMELOS93Dis, dindustriesDisco, jimpickDiscord[m, M4eekDiscord[m], nlkoDiscord[m], sbpDiscord[m], Luna14Discord[m], benaszabDiscord[, kevinbird15Disco, JungleHeartDisco, zoink92Discord[m, SenshiDiscord[m], RomaricDiscord[m, celsoDiscord[m], TryptophanDiscor, katakotoDiscord[, hvergaraDiscord[, grvhiDiscord[m], zegordoDiscord[m, sukarDiscord[m], zwelsternDiscord, KarlDiscord[m], nyarlathotepDisc, koalalorenzoDisc, NooooooWayyyyyDi, ShmultzDiscord[m, mhzDiscord[m], sprayDiscord[m], pps96Discord[m], rappelDiscord[m], drshamoonDiscord, CarboClanCDiscor, jmank88Discord[m, OrkunDiscord[m], foxcoolDiscord[4, AblibuDiscord[m], jenncloudDiscord, the_nikinDiscord, gregjeanmartDisc, malaclypsDiscord, chinsuDiscord[m], ScottSmileyDisco, allgoDiscord[m], panDiscord[m], nijynotDiscord[m, megadogberthehim, SchwartzDiscord[, h2Discord[m], mattcDiscord[m], RichardLittDisco, KinnardDiscord[m, xtream1101Discor, felixschlDiscord, DerekDiscord[m], jessicaschilling, MesaDiscord[m], SmileRobotDiscor, jazzy-jeff^_^Dis, braditzDiscord[4, modigDiscord[m], bitspillDiscord[, romaricDiscord[4, TeamIanDiscord[m, nebulerDiscord[m, ExpherienceDisco, DamirDiscord[m], SweatDiscord[m], leoalvarezhDisco, marcocastignoliD, sekiDiscord[m]1, bengoDiscord[m], aaronpkDiscord[m, deltaDiscord[m], paulmahoneDiscor, gtsDiscord[m], sachaDiscord[m], thestevewayDisco, n9tDiscord[m], prtfwDiscord[m], jklepatchDiscord, cardDiscord[m], PamileissonDisco, EdmundMDiscord[m, CocoonCrashDisco, cesarosumDiscord, l^discordDiscord, ArunDiscord[m], enricomarinoDisc, ithithDiscord[m], freethinkingawa4, placer14Discord[, CryptoEmpressDis, MatthDiscord[m], godparticleDisco, tangoDiscord[m], silent_ActivistD, r5723013Discord[, HeysteinDiscord[, TianyiDiscord[m4, UserDiscord[m], swedneck__, SuikaDiscord[m], OlegStotskyDisco, DioBrandonDiscor, test123Discord[m, UsDiscord[m], ryanchristoDisco, IgutinDiscord[m], James|ColonyDisc, KisulkenDiscord[, aswiththewildDis, amatuniDiscord[m, pierrebocDiscord, funwhilelostDisc, zcopleyDiscord[m, marcusrbrownDisc, cristobalDiscor4, celsoDiscord[m]1, felixschlDiscor4, mikealDiscord[m], KeegenDiscord[m], plexusDiscord[m], ksDiscord[m], LordFenixNCDisco, ad87657Discord[m, JonwelDiscord[m], MisterGoreDiscor, zazikiDiscord[m], ngamboaDiscord[m, catman[m], macerbiDiscord[m, nofwayyDiscord[m, PhiDiscord[m], DaekiDiscord[m], KinnardDiscord[4, lauren|Microspon, vexlDiscord[m], iiogamaDiscord[m, robinzzzDiscord[, boomshroomDiscor, te0dDiscord[m], sblinnDiscord[m], PermawebEmbedDis, wngrDiscord[m], PeevesDiscord[m], chrisDiscord[m], itsmekntDiscord[, RDeckardDiscord4, janttoDiscord[m], bushido711Discor, thomasbDiscord[m, nilocDiscord[m], willibuddyDiscor, capDiscord[m], M[AXEL]JulianDis, maparentDiscord[, chmanieDiscord[4, JaoheahDiscord[m, Bads3ctor9700[m], swedneck[GMT1]Di, leoalvarezhDisc4, JeanDiscord[m], ptonerDiscord[m], ShokuninDiscord[, KinnardDiscord[7, TristanDiscord[m, doorknob88Discor, AraratDiscord[m], ZapierDiscord[m], RockSteadyTRTLDi, GabrielBadGriefD, cannabysDiscord[, DiscordBridge[m4, PrabhaavDiscord[, GelvenDiscord[m], Discord[m]1, RomainDiscord[m], DerrickFDiscord[, CantiTurtleCoinD, glenn[m], GeorgeXieDiscord, neilDiscord[m], ivanDiscord[m], nellkate1[m], watDiscord[m], johanhermanDisc4, CathyLDiscord[m], beko[m], VictorGDiscord[m, bekoDiscord[m], jgmac1106Discord, Swedneck_, ben_thatmustbeme, [jgmac1106] and [snarfed] joined the channel
#
GWG
[snarfed]: If there is an option, that is loading the option on each retrieval of a page
#
GWG
The page query is not populated until after the headers sent filter
#
GWG
So I had to get creative
#
[snarfed]
ah, that's unfortunate
#
[snarfed]
the headers may get populated before, but i bet they haven't actually been sent to the client. so maybe you could reach into them and edit them after the page query?
#
GWG
So I intend to optimize as much as possible
#
GWG
So, it will check for a populated post variable and use it if there
#
GWG
It will use the url to post id functionality to try to derive the post id from the request Uri
#
GWG
It will cache the result in the WordPress object cache
#
[snarfed]
thoughts on my suggestion ^?
#
[snarfed]
alternatively if this is more trouble than it's worth, feel free to deprioritize it
#
[snarfed]
i'd like it, but i don't care about it as much as eg https://github.com/pfefferle/wordpress-semantic-linkbacks/issues/41
#
Loqi
[snarfed] #41 for mentions, show full content text if it's small enough
#
GWG
I am working on webmentions right now as a precursor to bundling in Linkbacks
#
GWG
So, I might add that to webmentions right now so it will be there. I am running my test website with Linkbacks disabled
#
GWG
Trying to be focused
#
GWG
I have 3 PRs into pfefferle for when he returns from vacation
#
GWG
1. Avatar code moving over from Linkbacks
#
GWG
2. Support webmentions to any post type, specifically to attachments, and optionally don't send webmentions for img tags
#
GWG
3. The header issue
#
GWG
Next is improving verification so I can pass the content to the parsing code more effectively
#
GWG
Then I can bring the parsing code over
#
GWG
I can't just merge it, per required parameters
#
GWG
I have to reimplement hacky features
[fluffy], gRegorLove, [jgmac1106] and [tantek] joined the channel