#wordpress 2019-12-24

2019-12-24 UTC
[tantek] and shrysr joined the channel
#
GWG I ported the icon changes I made in Syndication Links over to the Indieweb plugin, and sent a PR for review.
[fluffy], [dmitshur], [snarfed], [tantek], ba, gimochiDiscord[m, EldenDiscord[m] and [jgmac1106] joined the channel; ba left the channel
#
GWG Good morning, WordPress users
[LewisCowles], [CrowderSoup], dougbeal|iOS, [tantek], [snarfed] and chrisaldrich joined the channel
#
[snarfed] so GWG i still suspect edent's u-mention line break problem is a bug in Semantic Linkbacks
#
[snarfed] just fyi. details in https://github.com/snarfed/bridgy/issues/903#issuecomment-568811094
#
Loqi [snarfed] > I'm using the semantic-linkback plugin, which enters them into the WordPress database with `\n`. this is probably the problem. cc @dshanske. Bridgy obviously isn't posting a WP comment itself, it's just publishing HTML, in which pure whitespace ...
#
GWG [snarfed]: Possibly, that's why I was asking about what I might do with the hidden links, then I could simply strip them
#
[snarfed] it's not about the links, it's about how you handle whitespace in HTML
#
[snarfed] it's not significant on its own, at least not without explicit markup like <pre> or CSS like white-space: ..., so by default you should collapse it all to single spaces, which is what browsers themselves do
#
[snarfed] i think you'll get that for free if you just use your mf2 parser's 'value' field instead of its 'html' field
#
GWG I have some cleaning code I use as well if we keep the HTML.
#
[snarfed] sure, that could work too, as long as it collapses whitespace
#
GWG I wrote a lot of this already and am going to port over parts of it from my other library
#
[snarfed] ok!
#
[snarfed] feel free to reopen https://github.com/pfefferle/wordpress-semantic-linkbacks/issues/234 then
#
Loqi [edent] #234 Hidden links in Twitter replies
#
GWG I would think it should be renamed, but will see
#
[snarfed] if you're a committer on the repo, you should be able to rename it
#
[snarfed] please do reopen it if you agree this should be fixed in SL, and i'll close the bridgy issue
#
GWG I don't agree with reopening the issue unless I copy over the context. The SL issue asks where the links come from...closed because they don't come from SL
#
GWG The Bridgy issue discusses an SL issue with rendering them
#
[snarfed] sure, obviously, copy over the context. you want to work with people on the spirit of their problems, not the narrow letter of the original text they typed in
#
[snarfed] the key point is that we understand and agree on the problem itself, and where we should fix it. issues are just tools we use to manage and coordinate the debugging and fixes, we can replace any text anywhere we want to help us do that
#
[snarfed] if you'd rather open a new SL issue, go for it
#
GWG [snarfed]: Yes. I'm agreeing with that. I'm just pointing out that looking at the original issue, I thought his issue was something else.
#
GWG Copying context as we speak