#wordpress 2020-08-14

2020-08-14 UTC
[tw2113] and [chrisaldrich] joined the channel
#
Ruxton
jgmac1106 - theres some errs in that feed atm, trying to load /%5Bobject%20object%5D twice, around line 126 in the feed it's embedding a background image with that url for http://drmac.tech-4-teens.club/2020/08/178/
#
Loqi
[jgmac1106] Emma, the only rule to blogging is you get to write all the rules. Have fun, already I see your personality dancing off the stage as a Mountain range rising into the future. Have fun
[jeremycherfas], ben_thatmustbeme, [KevinMarks], [argovaerts], cap_da_flag, [Murray], [chrisaldrich], [Rose], [Ana_Rodrigues] and [jgmac1106] joined the channel
#
[jgmac1106]
ruxton yeah some of the post kinds spit out weird rss sometimes, this is just the feedzy plugin
#
[jgmac1106]
thx chrisaldrich, I will pass it along to the campers
[argovaerts] and [tonz] joined the channel
#
[tonz]
mmm, I just updated the Sempress theme, and now my site gives a critical error. Let’s see if the logs say something useful
#
[tonz]
It’s a clash with a subtheme: Backend fatal error: PHP Fatal error: Cannot redeclare sempress_customize_css() (previously declared in /var/www/…/wp/wp-content/themes/tonsempress/functions.php:59) in /var/www/…/wp/wp-content/themes/sempress/functions.php on line 233\n
[pfefferle] joined the channel
#
[pfefferle]
Can I help you?
#
[pfefferle]
This is weird, I am not aware that I made changes there
#
[tonz]
I don’t remember, but it might be I cut that function from sempress theme before. I added it to my subtheme’s functions.php I see.
#
[tonz]
I’ll either cut it again or do a if !exists.
#
[pfefferle]
You want me to add a exists check to my functions?
#
[tonz]
from your comments in the files, I see it was an explicit choice on your side to not have that check for it (“Functions that are not pluggable (not wrapped in function_exists()) are instead attached
#
[tonz]
* to a filter or action hook. The hook can be removed by using remove_action() or
#
[tonz]
* remove_filter() and you can attach your own function to the hook.“)
#
[tonz]
so, I’ll tinker with it myself, and add a warning to my own notes 😄
#
[tonz]
thanks for asking.
#
[pfefferle]
Ok, let me know if I can help
#
GWG
[pfefferle]: Have you looked at the webmention PR lately?
#
[pfefferle]
Do you ask because of a specific change?
#
[pfefferle]
I plan to make a branch for the latest version, to merge the changes into core
#
[pfefferle]
The mr is way too big now
#
GWG
[pfefferle]: That's what I was asking...it is growing.. I think we need to merged before we add anything else
#
[tonz]
[pfefferle] I added a !exists check to sempress_customize_css function and that solved it.
#
GWG
[pfefferle]: Just tell me if there is anything else we need to close off to merge what we have so far and move to the next PR/branch
[tb], [tw2113], [chrisaldrich], [Ana_Rodrigues], [Rose], [schmarty], [tantek], nickodd, gRegorLove, [fluffy], [snarfed] and [pfefferle] joined the channel; nickodd left the channel
#
[pfefferle]
[tonz] have you published your child theme?
#
[pfefferle]
[dshanske] merged!
#
GWG
[pfefferle]++
#
Loqi
[pfefferle] has 5 karma in this channel over the last year (8 in all channels)
#
GWG
Happy Friday to us
gRegorLove joined the channel
#
[pfefferle]
I branched the master to “4.x” if we have to change/fix something in the meantime.
#
GWG
What do we want to accomplish minimum before release?
#
GWG
100% Semantic Linkbacks parity or just just parsing and the rest incrementally?
#
[pfefferle]
good question
#
GWG
[pfefferle]: I try to ask good ones
#
GWG
If we merge the remote_source_mf2 PR into Semantic Linkbacks, we can release without a functionality change
#
GWG
If we don't, we can keep iterating toward a full replacement
[schmarty], bishop_bautista and [KevinMarks] joined the channel