#wordpress 2021-10-21

2021-10-21 UTC
[chrisbergr], [tw2113_Slack_], grantcodes[d], justHaunt and maxwelljoslyn[d] joined the channel
#
[chrisbergr] Hey GWG, I think you have an answer for me there: with Semantic Linkbacks it is still not possible to override the comment templates by the theme, right? Documentation is only semi helpful, as usual 🙂
perro joined the channel
#
GWG You should be able to with a filter change...
#
Loqi yea
#
[chrisbergr] There is no filter in the comment walker... Anyways, I'm doing it like 2yrs ago https://github.com/pfefferle/wordpress-semantic-linkbacks/issues/210#issuecomment-473555248
#
GWG remove_filter( 'wp_list_comments_args', array( 'Linkbacks_Handler', 'filter_comment_args' ) );
#
Loqi [chrisbergr] I have a proposal for you. See [my fork](https://github.com/chrisbergr/wordpress-semantic-linkbacks/tree/templates-for-mentions). Maybe you'd be able to test this on your test environment? It worked great in my local env with all my tests.
#
GWG We've been trying to merge Webmentions and Semantic Linkbacks for 2 years now.
#
GWG The new code would work differently.
#
GWG So, we have only been doing maintenance.
#
[chrisbergr] That's fine. But just let me note that I'd love to see some kind of templating system in the future merge.
#
GWG [chrisbergr]: I can show you the code I started to write for it last year.
#
GWG !tell [pfefferle] Can we talk plan for moving forward on webmentions? We've been stalled for a bit
#
Loqi Ok, I'll tell them that when I see them next
#
GWG [chrisbergr]: We're switching to registering custom comment types for reply, like, etc. So you'd be able to have a template for each called by the new walker, which would call the template file that could be overridden in your theme. The same way I do in Post Kinds
#
[chrisbergr] Oh, that sounds really great 🙂
[chrisaldrich] joined the channel
#
[chrisbergr] yes, I think I remember that you wrote about this idea a long time ago
#
[chrisbergr] What you did in the meantime with simple location in combination with post kinds is really great. My Paris/Disneyland trip last week forced me to finally use own your swarm and I love what I get thanks to your great work 🙂
jamietanna joined the channel
#
GWG [chrisbergr]: I have to fix a new timezone bug I found in Simple Location, but I love that code
#
GWG I also hear Phantom Manor is the best themed Haunted Mansion
#
[chrisbergr] We could hear the screams from outside. Unfortunately, my kids don't like scary attractions, so I can't judge that first hand.