#wordpress 2023-04-05
2023-04-05 UTC
RasAlGhoul joined the channel
antranigv joined the channel
IWSlackGateway, [manton], [snarfed], gRegor and [pfefferle] joined the channel
# 
[pfefferle] You already found issues? :face_with_peeking_eye:
wagle joined the channel
# [pfefferle] Good morning 👋
[chrisbergr] joined the channel
# 
[chrisbergr] I had semantic linkbacks 3.11.0 installed, updated to 3.12.0 first. That was a mess because of the deactivation of the plugin, had to download the latest tag in github and made a installable zip file. Next I updated webmention and deactivated semantic linkbacks. Seems like it's working, but every other received webmention than reply is now displayed as mention. Before they were likes, bookmarks and so on. I guess this has
# [chrisbergr] something to do with the fact that I skipped a lot of updates, but idk.
# [chrisbergr] Talking about the old likes, bookmarks, etc...
# [chrisbergr] have not received new ones and am not able to test new likes because this is on my local machine. On a online testpage I made only the update of webmentions, deactivated the old semantic linkbacks 3.11 without updating it and there are all likes, bookmarks and so on displayed as default comments.
# [pfefferle] We changed from comment meta to comment_type
# [pfefferle] Do you use custom code?
# [chrisbergr] on my localhost yes, on my online testpage I removed everything and changed to twentytwentythree
# [chrisbergr] I guess because I skipped some linkbacks updates I missed the internal rebuilding from comment meta to comment type...
# [chrisbergr] I think I can fix this with a script batch-changing those things. But first I have to serve my clients 🙂
# [chrisbergr] But maybe there are other people out there having the same situation (not done every update). They should be warned .
[fluffy], fef and gRegor joined the channel
# [chrisbergr] "Seperate Webmention Types from Comments" is checked, if that's what you mean.
[Murray] joined the channel
# [chrisbergr] Oh.... The issue with likes and other types being displayed as default comments is caused by the twenty-twentythree theme. I guess it has something to do with the comments block. Changing to sempress and it looks like expected
# [pfefferle] Yes, sadly fse is ignoring all of the filters we use 😥
antranigv joined the channel
# [chrisbergr] Maybe we have to provide our own comments block?
# [chrisbergr] Than it won't work out of the box, but with minimal change in the fse template
# [chrisbergr] *won't work meaning that it doesn't look that pretty but still works...
antranigv joined the channel
# [chrisbergr] After a quick look it should be possible to simply duplicate the block and only make changes in the PHP file. Filter the comments, somewhere at line 32, so you can generate the list of regular comments.
# [chrisbergr] And for the reaction types we make a second duplicate with different filters, where css can do the job of displaying just the facepiles..
# [chrisbergr] That might be my first vague and theoretical approach, without having thought about it more deeply.
IWSlackGateway, gRegor, [tantek], RasAlGhoul, [jacky] and [chrisbergr] joined the channel
# [chrisbergr] Even though there is still construction work going on almost everywhere else on my site, at least I have the output of the comments the way I want it :)
# [chrisbergr] This is what I had to do to realize it: https://github.com/pfefferle/wordpress-webmention/compare/main...chrisbergr:wordpress-webmention:templating
[pfefferle] joined the channel
# [pfefferle] will you create a pull request when ready? seems to be pretty straight forward what you have done so far.
[snarfed] joined the channel
# [chrisbergr] [pfefferle] Have done a pull request. I'm curious to see if it stands up to your quality assurance 🙂
# [chrisbergr] Oh, interesting. I have a function that merges comments from the german and english versions of my posts and always displays them. Of course excluding the reactions doesn't work on the respective other language... Everytime I find new construction sites
fef and aaronpk joined the channel
# 
aaronpk Please see https://indieweb.org/discuss for channel purposes and logging policies. Code of conduct: https://indieweb.org/code-of-conduct
fef, [KevinMarks], [aciccarello] and RasAlGhoul joined the channel