#wordpress 2023-07-04

2023-07-04 UTC
JohnBeales, doug_c_im, [jacky], IWDiscord, [jeremycherfas], gRegorLove_, gRegorLove__, [Murray] and [pfefferle] joined the channel
#
[pfefferle] oh oh... the parser in Webmention 5.x has some serious issues :face_with_peeking_eye:
doug_c_im joined the channel
#
sknebel ?
doug_c_im joined the channel
#
[pfefferle] broken parsers, broken checks
#
[pfefferle] some parsers only worked, because the checking was wrong 🙂
#
[pfefferle] double negation
#
[pfefferle] 🙂
#
[pfefferle] https://github.com/pfefferle/wordpress-webmention/compare/5.1.0...main
doug_c_im joined the channel
#
GWG [pfefferle]: Darn
#
[pfefferle] yea 😞
#
GWG I see the changes there
#
[pfefferle] I had to remove the handler->parse completely
#
[pfefferle] as far as I can see, it only ever used the MF2 parser, because of the broken is_complete check
#
GWG How did we miss that?
#
[pfefferle] and after I fixed that, I got a lot of errors of the other parsers, because they where never loaded before
#
[pfefferle] 😂
#
[pfefferle] should work now 🙂
#
GWG That's good.
#
[pfefferle] I also added options to the tools endpoint, to check aggregated and grouped
#
GWG I know I looked at the individual returns from the parsers originally, but I guess the merged effect wasn't checked enough
doug_c_im and GWG joined the channel
#
[snarfed] [pfefferle]++ wow!
#
Loqi [pfefferle] has 16 karma in this channel over the last year (31 in all channels)
doug_c_im joined the channel
#
GWG I still feel like I need a karma deduction. Can someone minus me?
#
[pfefferle] [snarfed] but the URL thing is tricky
#
[pfefferle] GWG??? why that?
#
GWG [pfefferle]: I feel like I haven't lived up to my karma level.
#
[pfefferle] come on... you are THE one that pushed the WordPress Outreach Club over time, with a very consistent work load level!
#
[pfefferle] GWG++ 😉
#
Loqi GWG has 25 karma in this channel over the last year (56 in all channels)
#
GWG I'm told I'm hard on myself.
doug_c_im joined the channel
#
[pfefferle] That isn‘t that bad? Better understatement than the opposite!
doug_c_im and JohnBeales joined the channel
#
GWG [pfefferle]: Are you going to push your fixes to a release?
doug_c_im joined the channel
#
[pfefferle] maybe a good idea
#
[pfefferle] the mf2 parser has a breaking change with 0.5.0 😞
#
[pfefferle] we have to change the code a bit for that
#
GWG [pfefferle]: Tell me if you need me to do something or if you have it.
doug_c_im, IWSlackGateway, [schmarty], [timothy_chambe], JohnBeales, [KevinMarks] and [snarfed] joined the channel