#wordpress 2024-12-29

2024-12-29 UTC
[snarfed], Lars-Christian, Guest6, sebbu, gRegor and gRegorLove_ joined the channel
#
[snarfed] GWG just fyi capjamesg's https://artemis.jamesg.blog/ triggered a 500 in the WP IndieAuth plugin on my site just now
#
GWG Do we have logs on why?
#
[snarfed] ```
#
[snarfed] er yes, just a sec
#
[snarfed] ```
#
[snarfed] damn, that isn't working. nm then
#
[snarfed] POST /wp-json/indieauth/1.0/token?grant_type=authorization_code&code=...
#
GWG Let me see what I can figure out
#
[snarfed] PHP Warning: Undefined variable $tokens in /srv/htdocs/wp-content/plugins/indieauth/includes/class-indieauth-token-endpoint.php on line 338
#
[snarfed] PHP Fatal error: Uncaught Error: Call to a member function destroy() on null in /srv/htdocs/wp-content/plugins/indieauth/includes/class-indieauth-token-endpoint.php:338
#
[snarfed] ...
#
[snarfed] Stack trace:
#
[snarfed] #0 /srv/htdocs/wp-content/plugins/indieauth/includes/class-indieauth-token-endpoint.php(234): IndieAuth_Token_Endpoint->verify_local_authorization_code(Array)
#
[snarfed] #1 /srv/htdocs/wp-content/plugins/indieauth/includes/class-indieauth-token-endpoint.php(187): IndieAuth_Token_Endpoint->authorization_code(Array)
#
[snarfed] #2 /wordpress/core/6.7.1/wp-includes/rest-api/class-wp-rest-server.php(1292): IndieAuth_Token_Endpoint->post(Object(WP_REST_Request))
#
[snarfed] ...
#
[snarfed] #14 {main}
#
[snarfed] thrown in /srv/htdocs/wp-content/plugins/indieauth/includes/class-indieauth-token-endpoint.php on line 338
#
[snarfed] see discussion in #indieweb-dev
#
GWG Can you put that into a GitHub issue for readability? Let me see what I can do.
#
[snarfed] sounds like capjamesg sent params in the URL query params instead of body
#
GWG Might have triggered something as a result... I thought I got rid of old code
#
GWG Except for backcompat
#
[snarfed] https://github.com/indieweb/wordpress-indieauth/issues/279
#
Loqi [preview] [snarfed] #279 500 on badly formed POST to token endpoint