pfefferle!tell barnabywalters perfect! thanks! and also thanks for pointing me to the <body /> or <html /> as h-entry thing… never thought about that and it makes a lot of things a lot easier… working on my theme to support the comments markup and try to implement the p-in-reply-to into the web mention plugin.
Loqibarnabywalters: aaronpk left you a message 12 hours, 11 minutes ago: here's the date formatting library I was telling you about. would be curious to hear your thoughts on it! https://github.com/indieweb/date-formatter-php
Loqibarnabywalters: pfefferle left you a message 1 hour, 15 minutes ago: perfect! thanks! and also thanks for pointing me to the <body /> or <html /> as h-entry thing… never thought about that and it makes a lot of things a lot easier… working on my theme to support the comments markup and try to implement the p-in-reply-to into the web mention plugin.
Loqiaaronpk: barnabywalters left you a message 28 minutes ago: I merged my mf2-shim changes, pushed to https://packagist.org/packages/mf2/shim — let me know if you want to be added as a maintainer
tantekbarnabywalters - perhaps you can add a section on advice / how-to NOT show PHP notices when selfdogfooding in a new section here: http://indiewebcamp.com/selfdogfood
waterpigs.co.ukedited /selfdogfood (+911) "/* testing your code in production */ added notes about debugging notices in production, some PHP code samples" (view diff)
sandeepshettythe reason it bothers me is because if it were local comment, I would show the whole comments so treating remote comments differently doesn't feel right
sandeepshettythat should be an explicit rule/guideline that applies to both remote/local comments: truncate any comment greater than x and show a read more link,
tantek.comedited /FAQ (+849) "sort questions by likelihood of relevance, fix/updated everyone going to want to run their own website question (of course they are, like personal computers, cell phone numbers etc.), add What is new q and a" (view diff)
sandeepshettyand trusting p-summary to be "short" is also not a good idea so that rule could be added explicitly... and shouldn't be a reason to show p-summary by default
sandeepshettyit feels like a hack to get a plain text version of the comment (which works for what most indiewebers call "notes" but not for "articles")
tantekaaronpk - because if there is a p-summary and it is shorter, it may be more meaningfully truncated than you might be able to automatically truncate
aaronpksandeepshetty: I don't think that's necessarily true. especially with inline previews on twitter and facebook, summaries of articles is even more important now
aaronpkI agree with sandeepshetty on this one though, it shouldn't be a "rule" to show the p-summary, it should be recommended that you truncate text to fit your UI, and suggested that the p-summary may have a better truncated version
aaronpkright, truncate to whatever length you want based on your design, but take into account the fact that the p-summary may have a shorter/better version for you to start with if it's present
sandeepshettywhich brings us to the other problem of displaying html securely.. think we should change this from "you may want to filter some HTML" to "you should filter unsafe HTML"
tantek.comedited /comments-presentation (+465) "/* How to display */ prefer full content, use p-summary instead of truncating yourself, truncated only if that's what you need per your own site UI/design. also truncate the p-summary or p-name if you have to" (view diff)
sandeepshettyDo we need this: "for longer posts where only a part of it is the comment". I would markup this up (or rather not have any markup) as a mention
Loqisandeepshetty meant to say: Do we need this: "for longer posts where only a part of it is the comment". I would markup this (or rather not have any markup) as a mention
sandeepshettyShould I remove "for longer posts where only a part of it is the comment" in favor of marking up posts like that as a mention instead of in-reply-to ?