#dev 2017-07-10

2017-07-10 UTC
davidmead, AngeloGladding and [kevinmarks] joined the channel
#
[kevinmarks] Can we rename "authN" and "authZ" to "itme" and "canihaz"?
davidmead joined the channel
#
aaronpk lol
[miklb] and billbennettnz joined the channel
#
samwilson.id.au edited /Flickr (+276) "/* How to export your data */ +flickr-cli" (view diff)
davidmead, snarfed and [miklb] joined the channel
#
www.boffosocko.com edited /micro.blog (-50) "addyourself template; OwnYourGram support" (view diff)
[eddie], prtksxna, davidmead, cweiske and [pfefferle] joined the channel
#
[pfefferle] good morning
#
Loqi guten morgen
prtksxna and davidmead joined the channel
#
Zegnat !tell aaronpk could you comment on https://github.com/Inklings-io/selfauth/pull/16#issuecomment-313953690 ? I am leaning towards filing this as a bug in IndieAuth.com, but it might just be me misreading the spec.
#
Loqi Ok, I'll tell them that when I see them next
#
cweiske Zegnat, I'd say an empty scope falls under "If the client omits the scope parameter when requesting authorization"
barpthewire joined the channel
#
Zegnat cweiske, yeah, it is a question of interpretation. Always the NULL vs empty debate.
#
cweiske there are sometimes technical reasons empty parameters are sent instead of omitting them
#
cweiske so I favor "lenient what you accept"
#
Zegnat For things like authorisation and authentication, I am not often lenient
prtksxna_away, davidmead and prtksxna joined the channel
#
@John316Network https://booklaunch.io/llwroberts/thedoor - The Door is free. #IARTG #Kindleebooks #mustread #readers #Kindletouch #indieauth #IAN1pic.twitter.com/8LCenVAYrJ (twitter.com/_/status/884407900633833472)
singpolyma joined the channel
#
ben.thatmustbe.me edited /Vidyo (+263) "i strongly dislike vidyo now" (view diff)
eli_oat joined the channel
#
ben_thatmustbeme Zegnat, sknebel, sebsel, can we talk about doing a code_sniffer cleanup only PR first?
#
ben_thatmustbeme #16 is messy, so i'd like to be able to do that first and then review changes
#
sknebel ben_thatmustbeme: ok with me
#
Zegnat Is fine with me. I am happy to rebase #16 after a master update, or even redo the entire PR.
#
Zegnat It made sense to do it after I had moved function around in the index.php, back when there were only 3 commits on the PR ;)
#
Zegnat Maybe fix-up and merge #20 onto master first, so that one doesn’t need rebasing?
#
sebsel Okay with me too, there is a lot going on in #16, so splitting up might be a good thing.
#
ben_thatmustbeme so as far as standards, i guess it doesn't matter to me too much, but i do have big preferences, no side-effects, and always {}s
#
Zegnat Most styleguides force {}s right? What do you mean by side-effects? PSR1 calls function definitions in a logic file SideEffects, but we can’t get around that unless we start using multiple files.
#
Zegnat sebsel, do you mind if I fix up #20?
[jemostrom] joined the channel
#
sebsel Reading through all the notifications now
#
Zegnat Oh woops! return-requested-scope branch is based on data-validation and not on master!
#
sebsel That was on purpose.
#
sebsel sorry, I made this thing way more complicated than needed
#
Zegnat Didn’t notice that before. We can hold off on that one then and first do a styleguide fix on master
#
ben_thatmustbeme Zegnat, if($a = 0) is what i mean by side-effects
#
Zegnat Ah, gotcha! Yes, I am cleaning up that if right now, commit incoming.
#
Zegnat Then I am happy to merge it into the data-validation branch and we can close the PR.
#
ben_thatmustbeme also (not so testable) but if(obj.changetheobject())
#
sebsel was cleaning #20 too
#
aaronpk I don't mind if($a=0) if the only time $a is used is inside the if()
#
Loqi aaronpk: Zegnat left you a message 5 hours, 27 minutes ago: could you comment on https://github.com/Inklings-io/selfauth/pull/16#issuecomment-313953690 ? I am leaning towards filing this as a bug in IndieAuth.com, but it might just be me misreading the spec.
#
Zegnat Are you ready to commit, sebsel? Or should I continue with commit and push?
#
sebsel I have it here, only need to sync.
#
Zegnat go ahead then
#
sebsel There you go, hope this is okay now.
#
Zegnat aaronpk, the problem is more that we don’t want a falsey check there. '0' is a valid scope, but if ($scope = '0') {} will not run.
#
aaronpk i was just talking about code standards
[pfefferle] joined the channel
#
ben_thatmustbeme eyes easily miss = vs == when reading if statements
#
aaronpk ah yeah, normally i only do it when there's *also* an == in there
#
ben_thatmustbeme and many times it can be done incorrectly unintentionally, then as a reader you have to double check if they actually meant to do that, etc
#
Zegnat only uses === these days
#
Zegnat PHPs type juggling has bit me too many times
snarfed joined the channel
#
Zegnat sebsel lgtm on that commit. Though I personally would have gone !=='' over !empty(), I find the first more explicit.
#
Zegnat But those are personal preferences more than anything
#
sebsel haha, I know nothing about code style
#
sebsel I'm out of this PR
#
Loqi rofl
#
sebsel Please fix however you like :)
#
Zegnat Not style related. You fixed it up fine!
#
ben_thatmustbeme likes just using a phpcs standard
#
Zegnat ben_thatmustbeme, just go --standard=PSR1,PSR2 --exclude="PSR1.Files.SideEffects" ?
#
sknebel someone make a readme section or contributing.md with what exactly I have to run and I'll try to fit to it ;)
#
ben_thatmustbeme --exclude doesn't work for me at all, what version are you using
#
ben_thatmustbeme have tried with 2.6 (i think it was) and now updated to 3.0.1
#
Zegnat I am on 2.8.1 apparently
#
ben_thatmustbeme just --standard=PSR1,PSR2 seems ok to me
#
Zegnat Good with me. I just tacked on the exlude so it wouldn’t complain about the function definitions within the logic file
#
ben_thatmustbeme oh actually, that doesn't catch if ($a=b)
#
ben_thatmustbeme it seems
#
Zegnat Nope it wont catch that
#
Zegnat I don’t think PSR has a rule about doing that at all
#
sknebel is there an extra rule that can be switched on?
#
Zegnat Not sure.
#
sebsel I don't see it in here http://edorian.github.io/php-coding-standard-generator/#phpcs not sure where to get other lists of options.
#
Zegnat Will UnconditionalIfStatement catch it maybe?
#
ben_thatmustbeme there is, i believe
#
ben_thatmustbeme just need to write our one ruleset.xml
#
ben_thatmustbeme https://pear.php.net/manual/en/package.php.php-codesniffer.annotated-ruleset.php
#
Zegnat Hmm, odd that the PSR2 checker doesn’t catch it: https://github.com/php-fig-rectified/fig-rectified-standards/blob/master/PSR-2-R-coding-style-guide-additions.md#avoid-conditional-assigment
#
Zegnat $ phpcs --standard=PSR1,PSR2 --exclude="PSR1.Files.SideEffects" index.php
#
Zegnat Works for me with the exclude, ben_thatmustbeme. I just updated to version 3.0.1 (stable).
#
ben_thatmustbeme huh, now its working, not sure why it was mis-behaving before
#
ben_thatmustbeme weird
#
ben_thatmustbeme but still doesn't actually check assignments in ifs
#
Zegnat No. I am not sure what sniffer we need for that
#
Zegnat Can’t find any rule or sniff that detects that behaviour ben_thatmustbeme. So either we have to create our own sniff or just define it as a code preference outside of phpcs
#
ben_thatmustbeme i have an old xml i'm updating now
tantek joined the channel
#
Zegnat I just merged #20 into #16, so that’s one PR down. Thanks sebsel for bringing up the extra scope support.
[miklb] joined the channel
#
sknebel so we are now reviewing an even bigger PR? that's not going to make it faster ;)
#
Zegnat If we handle codestyle in a separate PR soon, I will rebase on master and maybe squash the commits together. But it was always going to be a messy review as it moves parts of the original up-and-down in the file. No way around that.
#
ben_thatmustbeme or so i think
#
ben_thatmustbeme ugh
#
Zegnat We can also just merge #16 and call it a day, hahaha
#
Loqi nice
[xavierroy] joined the channel
#
Zegnat Ugh, good catch sknebel, best to fix the htmlspecialchars before merge. Not sure why I removed those/forget to add those.
#
ben_thatmustbeme woo
#
ben_thatmustbeme found something i like
#
ben_thatmustbeme and probably others won't lol
#
ben_thatmustbeme https://github.com/Inklings-io/selfauth/pull/22
#
Loqi [dissolve] #22 coding standard
#
ben_thatmustbeme Zegnat, sebsel, sknebel
#
Zegnat I never use the autofixer, that way you never get rid off bad habits.
#
Zegnat Reviewing changes now :)
#
ben_thatmustbeme heh, well, the autofixer can't fix the ones that its important you learn to not do
#
ben_thatmustbeme so i'm usually fine with it
tantek joined the channel
#
Zegnat Why the 2 or 3 spaces between $variable and =, ben_thatmustbeme? Could that be normalised to “1 space between longest variable name and = sign”, or something?
#
Zegnat Line 79 uses 3 spaces, 131 uses 2.
arush joined the channel
#
ben_thatmustbeme Zegnat: i took out the rule requiring it to be exactly 1 space around =
#
ben_thatmustbeme for alligning things
#
ben_thatmustbeme and oops, that should have been tabbed over
#
ben_thatmustbeme there is a rule for it
#
ben_thatmustbeme for blocks of variable that all tdo the same thing, it can be useful, but i'm good with either way
#
ben_thatmustbeme same for 129-134
#
ben_thatmustbeme meant to allign the :'s
#
Zegnat I usually go with the exactly-1-space-around rule, but I don’t have anything against aligning things like = and ? and : when they are in a block like that. But I would always align them based on 1-space-around for the longest one.
KartikPrabhu joined the channel
#
Zegnat That’s splitting hairs though, and that block disappears in #16 with the addition of filter_input anyway.
#
ben_thatmustbeme ahh, i usually just align to wherever tabs fall
#
ben_thatmustbeme Zegnat: like that?
#
ben_thatmustbeme just pushed a change
#
Zegnat Yes, that’s fine with me
snarfed and dougbeal|mb1 joined the channel
#
Zegnat line 27 of setup.php with no space between : and ?> is my only other irk, ben_thatmustbeme. Otherwise it LGTM and can be merged.
#
ben_thatmustbeme i was just reviewing that
#
ben_thatmustbeme i have an additional rule added
#
ben_thatmustbeme for embedded php
#
sebastianlasse.de edited /Events (+725) "NEW EVENT - Campfire Journalism Festival (for generation 2)" (view diff)
[jeremycherfas] joined the channel
#
ben_thatmustbeme Zegnat: updated
#
Zegnat That looks good to me. I also do not mind explicitly adding the semicolon everywhere for the echo's :)
#
Zegnat LGTM and approval on GitHub :)
[chrisaldrich] and [xavierroy] joined the channel
#
ben_thatmustbeme Zegnat: seems like sknebel and sebsel have no preference in it
#
ben_thatmustbeme so i think good to merge
#
ben_thatmustbeme oh, should probably document those commands in contributing.md or somewhere
#
sknebel yep, do that please.
#
sknebel otherwise no feedback from me, due to lack of clue on my part ;)
#
sebsel I don't feel experienced enough to share my preferences :) please set rules.
#
Zegnat The real pain will probably be rebasing on this.
#
ben_thatmustbeme https://github.com/Inklings-io/selfauth/blob/code_standards/CONTRIBUTING.md
#
ben_thatmustbeme Zegnat, yeah, might be easier to just run a codesniff on your branch then do diffs to rebuild your changes as a whole new commit
#
ben_thatmustbeme thankfully the code base is small
#
sebsel I got the Atom package that complains in-line. It complains about ALL my Seblog code now.
#
sebsel (mostly because Kirby uses 2 spaces instead of 4-spaces / tabs and I adopted that)
#
aaronpk Wow this is crazy https://thehackerblog.com/the-io-error-taking-control-of-all-io-domains-with-a-targeted-registration/
#
sknebel yep, just saw it too
#
Zegnat That contributing file change is also fine with me. Merge whenever!
#
Zegnat has to step out for dinner
#
www.boffosocko.com edited /Indieweb_for_Journalism (+226) "Campfire Festival 2017" (view diff)
barpthewire joined the channel
#
ben_thatmustbeme Zegnat: push invalidated the approval
#
ben_thatmustbeme can't merge until another approves
#
ben_thatmustbeme s/ves/val/
#
sknebel ben_thatmustbeme: done
#
www.boffosocko.com edited /Goodreads (+322) "/* POSSE to Goodreads */ example: Chris Aldrich" (view diff)
#
www.boffosocko.com edited /archival_copy (+387) "Link Archiver on Twitter archives tweeted links to Internet Archive" (view diff)
snarfed and arush joined the channel
#
www.boffosocko.com edited /read (+47) "Reading session at IWS 2017" (view diff)
snarfed, snarfed1 and gRegorLove joined the channel
#
www.boffosocko.com edited /Webmention (+80) "Django" (view diff)
prtksxna joined the channel
#
www.boffosocko.com edited /Django (+95) "Django Webmention" (view diff)
snarfed joined the channel
#
ben_thatmustbeme Zegnat, i think i got your data-validation branch up to snuff with just git merge
#
ben_thatmustbeme it wasn't too bad
#
ben_thatmustbeme check out data-validation-merge branch
#
ben_thatmustbeme make sure i didn't bork anything with the merge
#
@WendyandCharles ReadersGazette: BLOG Indie Author Answers by Jim Heskett http://www.thejugglingauthor.com/indieauth/ Get help writing your book #bookbloggers 97 (twitter.com/_/status/884482195972337664)
#
Zegnat Back from dinner, looking now, ben_thatmustbeme :)
snarfed joined the channel
#
Zegnat ben_thatmustbeme, doesn’t look like you touched index.php at all? https://github.com/Inklings-io/selfauth/compare/data-validation...data-validation-merge
#
ben_thatmustbeme what the heck
#
Zegnat If that’s the case, a simple rebase might work after all :p
#
Zegnat Yeah, I am not sure why git is being so nice to us
#
ben_thatmustbeme i messed something up
#
ben_thatmustbeme i definitely merged things in there
snarfed joined the channel
#
ben_thatmustbeme it wasn't bad at all actually
#
ben_thatmustbeme so all i needed to do was rerun the code styles first
#
ben_thatmustbeme oh yeah
#
ben_thatmustbeme and since the code checker was fine with index.php already
#
ben_thatmustbeme it was all happy
#
Zegnat So … no edits to index.php at all?
KartikPrabhu joined the channel
#
ben_thatmustbeme no, thats... odd
#
ben_thatmustbeme the only question i had
#
ben_thatmustbeme was on content negotiation
#
ben_thatmustbeme it steps on the old way of doing conneg, but i'm not sure if your code covers it fine
#
ben_thatmustbeme (side note, i said the heck with it then and just merged master in to your branch
#
Zegnat There is a problem with conneg?
#
Zegnat takes another look at the specific function
#
Zegnat Otherwise, if you have no problems with #16, I would say lets merge it before it gets out of hand again
#
ben_thatmustbeme oh, thats right, that was your PR anyway
#
ben_thatmustbeme https://github.com/Inklings-io/selfauth/pull/15
#
Loqi [Zegnat] #15 First pass at content negotiation
#
ben_thatmustbeme was going to review that you didn't overwrite this PR
#
ben_thatmustbeme but... yeah
#
Zegnat Yeah, conneg has been moved into its own function on 16
#
Zegnat One of the small things I wish I hadn’t done but had kept to its own PR
#
Zegnat Which is why I would love to get 16 in now. Giving us a blank slate to iterate on.
#
ben_thatmustbeme i think thats good
#
ben_thatmustbeme you handled aaron's comment i'm assuming
#
ben_thatmustbeme https://github.com/Inklings-io/selfauth/pull/16#issuecomment-314124222
#
Zegnat Yes https://github.com/Inklings-io/selfauth/pull/16/commits/80993a17cb68ddd3b105d603f4f6ea4a2fa3a6ff
#
ben_thatmustbeme you test it to make sure you can login as i'm only reviewing code
#
ben_thatmustbeme otherwise i'm approving the PR
#
Zegnat grabbing latest commits with your merge now. Will try and use it to login at some places
#
ben_thatmustbeme PR approved, unless you find an issue, go ahead with the merge
#
ben_thatmustbeme i'll merge #21 after that
#
Zegnat My login tests worked, so I am merging. If other clients have problems that will simply be future issues
#
Zegnat I have now hit the big green merge button. Progress!
#
sknebel interesting that you can't reacji to merges or approvals
#
sknebel ?
KartikPrabhu joined the channel
#
Zegnat ben_thatmustbeme feel free to hit the big green button on #21. Then we just need to fix up #18 a little and we are back to a clean slate
#
ben_thatmustbeme done
#
ben_thatmustbeme closing #14 as well
#
ben_thatmustbeme you beat me to it
#
Zegnat Hehe, had the text ready ;)
#
Zegnat 3 issues and 1 PR left. Progress!
#
ben_thatmustbeme so scopes works fully now?
#
ben_thatmustbeme and thus authorization works?
#
ben_thatmustbeme if thats the case i really want to get #18 in then
#
ben_thatmustbeme as that updates the readme
#
Zegnat Unless sebsel unchecked it, I think you can commit to his branch if you just want to fix that one sentence and merge afterwards.
#
Zegnat And I think scope works completely now, whether authorisation works all the way through will depend on the user’s token-endpoint though
#
ben_thatmustbeme he put it under his own user account, didn't think you could commit to it like that
[colinwalker] joined the channel
#
[colinwalker] !tell Pfefferle When calling get_linkbacks() and looping through them is there an easy way to reverse the order?
#
Loqi Ok, I'll tell them that when I see them next
#
Zegnat You can when you make a PR. Little known feature, ben_thatmustbeme
barpthewire joined the channel
#
ben_thatmustbeme fixed that change and merged
#
ben_thatmustbeme back to 1 branch as well
#
ben_thatmustbeme deleted all the merged branches
#
sknebel nice
#
sknebel ben_thatmustbeme++
#
Loqi ben_thatmustbeme has 15 karma in this channel (248 overall)
#
sknebel Zegnat++
#
Loqi zegnat has 21 karma in this channel (111 overall)
#
Zegnat ben_thatmustbeme++ for the spring cleaning :D
#
Loqi ben_thatmustbeme has 16 karma in this channel (249 overall)
#
sebsel c
dgold joined the channel
#
dgold hey sknebel
#
Loqi dgold: tantek left you a message on 2017-04-12 at 7:45pm UTC: re: 10C definitely worth requesting that bits be open sourced for helping add more indieweb friendly functionality, like perhaps the markup templates so mf2 can be added
#
sknebel dgold hey
#
dgold whew - obvs been a while since I was in here
#
dgold I've been struggling through getting micropub working - using php
#
dgold I have set syndication query results - two results for now
#
dgold but quill isn't showing them - ergo I deduce that I have set the response incorrectly
#
dgold if you throw a GET at http://tinyurl.com/ydeo2mos [ https://ascraeus.org/micropub.php?q=syndicate-to ]
tantek joined the channel
#
sknebel dgold: I get a form-encoded response, pretty sure that has to be JSON
#
aaronpk yeah quill is expecting a JSON response
#
sknebel dgold: https://www.w3.org/TR/micropub/#syndication-targets
#
dgold ah, I see.
#
aaronpk (it even sends an accept: application/json http header)
#
dgold just because it sends it, doesn't mean I acknowledge it (yet) :)
#
aaronpk nobody actually reads Accept headers ;-)
#
Zegnat dgold, there is a pretty nice example in the spec: https://www.w3.org/TR/micropub/#syndication-targets
#
Zegnat aaronpk, most people don’t even think to send them ;)
#
dgold so, I need to take the response, create an array, and then spit out json
#
sebsel yaay for all the selfauth progress btw, Zegnat ben_thatmustbeme
#
sebsel Just tested it with tokens.indieauth.com and Quill: scopes seem to work!
#
Zegnat sebsel++ for the scopes work
#
Loqi sebsel has 7 karma in this channel (30 overall)
#
ben_thatmustbeme of all the code i've written, its the tiny lib thats 2 files is the one that has had the most interested in it, lol
#
ben_thatmustbeme well, most people involved in it
tantek joined the channel
#
Zegnat It is all about selfdogfooding, ben_thatmustbeme. This is now my main login for indieweb.org
#
Zegnat And if OpenID on IndieAuth gets fixed (I might look into that next), this will also be my main login on StackExchange
#
dgold like that?
#
loqi.me created /Backitude (+232) "prompted by sknebel and dfn added by Zegnat" (view diff)
#
dgold sknebel: I _think_ I have that fixed
KartikPrabhu joined the channel
#
sknebel dgold: key name "syndicate-to", not "syndication"
#
sknebel other than that looks good
snarfed joined the channel
#
dgold fixed that :) thanks sknebel
snarfed joined the channel
#
sknebel dgold: does it work now?
snarfed joined the channel
#
loqi.me created /QuartzDB (+131) "prompted by sknebel and dfn added by sebsel" (view diff)
#
snarfed aaronpk Zegnat: your Accept header comments made me laugh, because:
#
snarfed https://github.com/snarfed/bridgy/blob/master/util.py#L52
#
snarfed https://github.com/snarfed/indie-map/blob/master/crawl/wget.sh#L12
#
sknebel Known breaks on accept headers?!
#
snarfed it did at one point at least
#
sknebel :/
#
aaronpk lol
#
Zegnat snarfed, why it was topical to us: https://github.com/Inklings-io/selfauth/issues/12
#
Loqi [Zegnat] #12 Default to application/x-www-form-urlencoded on verification
[chrisaldrich] joined the channel
#
www.boffosocko.com created /donate (+28) "redirect to open collective" (view diff)
#
www.boffosocko.com edited /open_collective (+37) "see also: how to sponsor" (view diff)
[shaners] and snarfed joined the channel
#
www.boffosocko.com edited /granary (+15) "JSON feed support" (view diff)
#
www.boffosocko.com edited /JSON_Feed (+14) "/* Tools */ granary" (view diff)
[kevinmarks] joined the channel
#
[kevinmarks] So is this the opposite of rel-me auth? https://m.facebook.com/notes/protect-the-graph/delegated-account-recovery-now-available-in-beta/1875376806035795/
#
gRegorLove Haha, that's funny snarfed.
[miklb] joined the channel
#
Loqi nice
#
@kevinmarks @hillbrad @marypcbuk How about re-enabling rel=me from public Facebook pages so we can use indieauth with Facebook… https://twitter.com/i/web/status/884534339635224576 (twitter.com/_/status/884534339635224576)
#
@ChrisAldrich @sl007 @danehillard I don't use it (yet), but I know some journalists who are big into Django who have been wanting webmention support. :) (twitter.com/_/status/884538966845816833)
#
sebsel aaronpk I have made a start with a default timezone setting for Compass https://github.com/sebsel/Compass/tree/feature/default-timezone And it works! But I also added an option for metric system and I have no idea how to get that value from database into speed.js https://github.com/aaronpk/Compass/blob/master/compass/public/assets/speed.js any thoughts?
#
aaronpk nice
#
aaronpk probably easiest way is to write it into a hidden <input> tag iin php, then read it from JS
#
sebsel Oh, yeah! I was thinking about <script> and stuff, but then you have scopes wrong.
#
sebsel Good idea.
#
www.boffosocko.com edited /Indieweb_for_Journalism (+241) "Dodging the Memory Hole 2017 conference in Nov 2017 at Internet Archive" (view diff)
tantek and snarfed joined the channel
#
sebsel aaronpk https://github.com/aaronpk/Compass/pull/6 :)
#
Loqi [sebsel] #6 Add timezone and metric options
#
aaronpk ?
#
sebsel :D
#
sebsel now that I added timezone options I should honour mine. Good night!
AngeloGladding joined the channel