#dev 2020-02-01

2020-02-01 UTC
#
[LewisCowles]
this happens even with the original index.php
#
[LewisCowles]
so I think something is trying to use the secrets before we’re getting to override
#
aaronpk
huh... it was working fine for me before
#
[LewisCowles]
I think it’s the composer autoload + redis
#
[LewisCowles]
if I set the key manually it works
#
aaronpk
i wish those stacktraces were actually helpful
#
[LewisCowles]
So it’s coming at line 36, which means our line is never true
#
[LewisCowles]
about APP_NAME
#
[LewisCowles]
but it’s also not true using my SETUP_… ENV
#
[LewisCowles]
I might make it die and dump the ENV just so I can be sure what the state of play is
#
[LewisCowles]
neither are set sadly
mblaney and gRegorLove joined the channel
#
mblaney
jgmac1106 yes you can use i.haza.website for that, the reader can be on a public page. let me know if you try and set one up.
KartikPrabhu joined the channel
#
[LewisCowles]
I’m going to deploy from master to see if it behaves differently
KartikPrabhu joined the channel
#
[LewisCowles]
weirdest part is that the APP_KEY is set. Something using it seems to require that it be set outside of a branch
#
[LewisCowles]
master works
#
[LewisCowles]
I’ve reset index.php, so it must be the setup controller edits
maxwelljoslyn joined the channel
#
[LewisCowles]
it worked from master a few commits ago. Just noticed my master is missing updates
#
[LewisCowles]
none of the changes I’ve made should be able to break this
#
aaronpk
i just pushed a minor unrelated change an hour ago btw
Bohren_Gore joined the channel
#
[LewisCowles]
Ha, it was the procfile
#
[LewisCowles]
fixed, smaller, doesn’t touch the installer
#
[LewisCowles]
The installer means if we cache config we get the error I reported. Might be worth me making an issue just to highlight if anyone else feels like applying generic laravel heroku knowledge
#
[LewisCowles]
they will have an awful time
#
[LewisCowles]
it wasn’t a problem before because I was setting the APP_KEY in the app.json
#
[LewisCowles]
CLEARDB_DATABASE_URL -> DATABASE_URL and all the other sets of opinions I was placing are gone for now
#
[LewisCowles]
Makes the PR simpler
#
aaronpk
huh ok not sure i understand yet. are you ready for me to take a look now?
gRegorLove joined the channel
#
[LewisCowles]
it’s ready
#
aaronpk
cool i'm wrapping up some work stuff and might be able to look very soon!
#
[LewisCowles]
NP, it’s much less to look at now
Bohren_Gore joined the channel
#
aaronpk
oookay turned off work computer for the weekend
#
aaronpk
merging and trying this out for real now
#
aaronpk
[LewisCowles]++
#
Loqi
[LewisCowles] has 6 karma in this channel over the last year (8 in all channels)
#
aaronpk
ok cool i'm gonna tighten this up even more
#
aaronpk
the deploy button is sweet though, I haven't used that before
#
aaronpk
[LewisCowles]: it looks like heroku doesn't set DATABASE_URL, only CLEARDB_DATABASE_URL. Do you see any harm in doing this in index.php? if(env('CLEARDB_DATABASE_URL')) $_ENV['DATABASE_URL'] = env('CLEARDB_DATABASE_URL');
Bohren_Gore joined the channel
#
[LewisCowles]
I will be sending a follow-up PR for the cascade. Checkout what I’ve set in indielogin.com PR https://github.com/aaronpk/indielogin.com/pull/57 or branch https://github.com/Lewiscowles1986/indielogin.com/tree/heroku-button
#
Loqi
[Lewiscowles1986] #57 Heroku button
#
aaronpk
oh i'm doing a bunch of stuff right now to clean things up a bit
#
[LewisCowles]
it should probably become a method which tests $_ENV for one of the supported database uri providers
#
aaronpk
on meetbale
#
[LewisCowles]
I knew you meant meetable
#
[LewisCowles]
but the cascade is normal PHP so should work
#
[LewisCowles]
you can do what you’ve put, but then what if someone sets up JAWSDB
#
[LewisCowles]
Because it’s Laravel, someone might even want heroku postgres
#
aaronpk
well those are gonna fail cause I have a raw sql query in there somewhere but that's a different issue
#
[LewisCowles]
```$db_env = array_filter(
#
[LewisCowles]
getenv('JAWSDB'),
#
[LewisCowles]
getenv('DATABASE_URL'),
#
[LewisCowles]
getenv('CLEARDB_DATABASE_URL')
#
[LewisCowles]
], function($val) { return !empty($val); }
#
aaronpk
this is really just an optimization, i'm trying to bypass the DB config completely for the cleardb case cause i'm assuming that's gonna be the most common
#
aaronpk
oh that'd work
#
[LewisCowles]
it’s nasty so I’m loathed to have it generally as it’ll evaluate every boot, but in meetable, you can pick one and set it
#
[LewisCowles]
so only use it in setup
#
[LewisCowles]
then Laravel loads CLEARDB_DATABASE_URL
#
[LewisCowles]
sorry loads DATABASE_URL
#
[LewisCowles]
you know what thats my bad, I removed the “as”: “DATABASE” section from the app.json
#
[LewisCowles]
which would make cleardb use DATABASE_URL instead of their silly CLEARDB_DATABASE_URL
#
[LewisCowles]
no need for the cascade at all
#
aaronpk
oh? that's great
#
[LewisCowles]
PR incoming
#
Loqi
[Lewiscowles1986] #65 set cleardb to use DATABASE_URL
#
Loqi
[Lewiscowles1986] #66 set manual instructions to use cleardb:ignite + as
#
[LewisCowles]
this one is for the manual steps to do the same
#
[LewisCowles]
I have switched punch to ignite just to keep it in line with app.json people can upgrade addons later. Downgrading is harder
#
aaronpk
good idea
#
[LewisCowles]
I’ll remove the cascade in indielogin.com heroku PR too and pivot to attaching `as`
#
aaronpk
ugh I forgot I need to add a step to configure S3 uploads. does heroku have anything with the same API as S3 that can be enabled as an add-on like the databae?
#
[LewisCowles]
it has an S3 addon. I know rails struggles with it
#
[LewisCowles]
give me a sec
#
aaronpk
bucketeer?
#
aaronpk
hm I wonder if I could get away with storing files in the database as a fallback
#
aaronpk
i'm gonna just open an issue for this and solve it later
#
[LewisCowles]
heroku addons:create cloudcube:free
mblaney joined the channel
#
aaronpk
wow their SEO is not good
#
[LewisCowles]
CLOUDCUBE_ACCESS_KEY_ID
#
[LewisCowles]
CLOUDCUBE_SECRET_ACCESS_KEY
#
Loqi
[aaronpk] #68 Somehow solve file storage for Heroku deploys
#
[LewisCowles]
there is a setting called `endpoint` in the PHP AWS SDK (all the AWS SDK’s) and that is `CLOUDCUBE_URL` without the path. The bucket name is the `basename($url['path'])` I’ll try to get on it this weekend
KartikPrabhu joined the channel
#
aaronpk
i'm doing a pass where i'm setting better defaults in the laravel config/*.php files so that there's less to configure in general
mblaney joined the channel
#
aaronpk
alright that's pushed!
#
aaronpk
I wish heroku apps could push config settings themselves!
virtual_vagrantD and [dmitshur] joined the channel
#
[dmitshur]
it appears indieauth.com doesn't support it when the IndieAuth authz endpoint is advertized in an HTTP Link header. luckily indieweb.org uses indielogin.com which supports it fine.
#
aaronpk
hm that wouldn't surprise me, IndieAuth.com is very old
#
[dmitshur]
I've seen many people still using it 😞 even [schmarty]
#
[dmitshur]
(it doesn't affect me negatively, just an observation)
#
aaronpk
I know, it's been haunting me for years
mblaney joined the channel
#
[dmitshur]
🫂 hehe
#
GWG
aaronpk: Aren't people using it still due lack of alternative?
#
aaronpk
That's the haunting
#
GWG
aaronpk: Do you have any ideas on alternatives?
#
GWG
That can be promoted?
[tantek] joined the channel
#
aaronpk
selfauth is good
#
aaronpk
if you use Wordpress or micro.blog then you don't need it which is good
#
GWG
aaronpk: We had that discussion re the use case of not hosting it. But I agree.
#
GWG
aaronpk: That question re update scope the other day, did you have any thoughts? In a multi author site scenario, should the update scope apply to just posts created by that author or all authors?
#
aaronpk
How does Wordpress handle that normally?
#
GWG
It has two capabilities, edit posts and edit other posts
#
GWG
It also has edit published posts
#
GWG
And a publish capability
#
GWG
So a bit more granular
#
GWG
As part of my next improvement, I am trying to map the WordPress permissions to the IndieAuth scopes
#
GWG
Right now, IndieAuth passes scopes to Micropub to determine what to do
#
aaronpk
I think that depends on what the Wordpress site is being used for
#
GWG
Oh?
#
aaronpk
I don't think there's a straight answer
#
GWG
The other option is to key it to the user
#
GWG
If the user has permission to edit other posts...
#
aaronpk
That makes sense
#
GWG
This is going to be a pain to test
#
aaronpk
yes always
#
GWG
But right now, I worry it isn't secure enough
mblaney joined the channel
#
GWG
aaronpk: How far did you get with IndieAuth.rocks if I am looking for inspiration on what to test?
#
GWG
I used the webmention.rocks test list for unit tests in the past
#
aaronpk
There's some stuff there but it's not documented
#
GWG
aaronpk: Do any endpoints have unit tests? I will check selfauth
#
GWG
Oh well... will figure something out
#
GWG
I am unit test challenged
mblaney, [fluffy], KartikPrabhu, gRegorLove and maxwell joined the channel
#
maxwell
maxwelljoslyn
maxwelljoslyn joined the channel
#
maxwelljoslyn
woops. I want to add a flag to my bash script that syncs my site to S3, but I'm new to bash options and having trouble. please lend a hand - think I've almost got it
#
maxwelljoslyn
goal: sync everything if I run "sync.sh" , sync everything but the tag pages if I run "sync.sh -g". see the paste for minimal example :^)
mblaney, HielleMatrixBrid, jeremych_, [AlisonW], [jgmac1106], nickodd and [Rose] joined the channel; mblaney left the channel
#
[Rose]
Yesterday I got nerdy with GitLab and CI and now it can compile mkdocs and scp the compiled files over to my server for me. I'm still amazed I managed it.
[LewisCowles] joined the channel
#
[LewisCowles]
Congrats Rose. I’m not surprised you did it, but I am glad you’ve confirmed
#
Loqi
Rose has 21 karma in this channel over the last year (68 in all channels)
#
[Rose]
I ought to document it, unfortunately I can't demo the result because that's under NDA, but the script to do so isn't.
#
[LewisCowles]
[aaronpk] ++ (I went to sleep by 4am)
#
Loqi
[aaronpk] has 58 karma in this channel over the last year (213 in all channels)
#
[LewisCowles]
Rose, it’s always the way. Around 2010 I started my new sneaky contracts. I cannot show a specific customer setup or data, as they have NDA for the complete set of things; but my contract states that I own all the things and it’s the configuration of that I’m selling to the customer.
#
[Rose]
This NDA isn't permanent, it's just until go live. And the company are very relaxed. It's just not everyone involved in the project knows what my role is yet exactly so it's best to tread lightly and keep things behind authentication.
#
[Rose]
Fortunately I'm also working on a new project: a place for people to upload automation scripts and showcase them.
#
Loqi
giggles
[KevinMarks] and ludovicchabant joined the channel
#
[LewisCowles]
2 new PR’s for meetable (it’s hilarious I don’t even know how to use it lol)
#
aaronpk
New PRs?
[jgmac1106] joined the channel
#
[LewisCowles]
I forgot to make PR’s from the branches
[Rose] joined the channel
#
[Rose]
Loqi request: links to github repos 😉
#
aaronpk
Oh haha cool
#
[Rose]
Imagine “git meetable” and Loqi replying with https://github.com/aaronpk/Meetable
#
Loqi
[aaronpk] Meetable: a minimal events aggregator
#
[Rose]
(maybe !git for sanity’s sake)
#
aaronpk
[LewisCowles]: Looks great just a few questions I left inline
nickodd joined the channel
#
aaronpk
I'm thinking maybe I spend today on the last changes I want to make and then package it up as a release!
#
aaronpk
call it 1.0
[mapkyca] and krychu joined the channel
#
aaronpk
Hey does heroku have an OAuth api...
#
aaronpk
let ppl log in to this with their heroku account hmmmm
#
aaronpk
I think I know my project this morning after breakfast
#
aaronpk
hm none of their examples show any authentication so now I'm suspicious
#
[LewisCowles]
Heroku authenticates people
#
[LewisCowles]
it has two methods I’m aware of
#
[LewisCowles]
• browser
#
[LewisCowles]
meaning if you can access the browser or have push access to git, then you can access
#
[LewisCowles]
I have no idea if they send public keys from github to heroku to enable the git integraton, but you need to opt into it I think
#
[LewisCowles]
no oauth AFAIK though
#
[LewisCowles]
scope-like things seem to be at the account level
#
aaronpk
They do!
#
[LewisCowles]
I’ll learn a thing
#
aaronpk
I'm not sure I'm gonna be able to do what I want, but I'm gonna try
#
[LewisCowles]
It’s nice. I take it heroku config:set might be able to go away?
#
aaronpk
And maybe even GitHub config
#
sivy
Getting from "what I wanted it to look like on my blog" to "what I want it to look like on twitter" might end up requiring some kind of machine learning.
#
sivy
making it automagical is *hard*
#
@steveivy
git switch <branch> git restore <file> Thanks the ever-loving heavens (git 2.23) https://twitter.com/mislav/status/1206937217194741760?s=20 (monkinetic txt-77574ef)
(twitter.com/_/status/1223649620959432706)
#
Loqi
git switch <branch> git restore <file> Thanks the ever-loving heavens (git 2.23) https://twitter.com/mislav/status/1206937217194741760?s=20
#
aaronpk
oops need to unescape html?
chrisaldrich joined the channel
#
sivy
@aaronpk yeah, but the code already strips HTML and then sends it, so it's the markdown processor converting < to &lt; then stripHTML doesn't know how to convert it back for the micro post
#
sivy
just another case to handle
#
sivy
"just do what I mean"
#
aaronpk
that's how I feel every time I deal with html encoding or whitespace
#
aaronpk
er, significant blank space
#
aaronpk
it's like "come on what do you mean you want to collapse this double newline what are you thinking" and the next day "why aren't you collapsing newlines like I intend!"
#
sivy
right?
#
sivy
question: If I want to support some kind of "share this to my blog" thingy that can be used from external apps, what's the best way/API to support?
#
sivy
I'm thinking from Drafts, for one, or something that works with iOS share sheets
#
aaronpk
like posting from an iOS app to your blog?
#
aaronpk
that sounds like Micropub! you can set up a Shortcut in iOS to receive stuff as a share target and post it to your blog
#
aaronpk
[LewisCowles]: this is gonna work... I can give people the option of using Heroku login instead of GitHub, and the installer can go set up everything it needs to make that work!
#
aaronpk
next up i'm gonna try to figure out if the installer can set the config vars itself!
#
[LewisCowles]
I spent way too long on unit testing, but at least coverage won’t go down every time I PR
#
[LewisCowles]
there is no-longer a default region though…
#
[LewisCowles]
uses the table cloudcube provides, where they deduce the region from “the bucket”
#
[LewisCowles]
AFAIK it’s not a bucket
#
[LewisCowles]
Unless they are renting paths in a bucket
#
aaronpk
oh I didn't think I had any tests in here at all yet heh
#
aaronpk
oh I do have tests for the tagging stuff but that's it
KartikPrabhu joined the channel
#
[LewisCowles]
Looks like I misremembered something please don’t merge
#
[LewisCowles]
it is one big bucket and we get a prefix…
#
[LewisCowles]
got to find where I set a forced object prefix
#
[LewisCowles]
‘root’…
KartikPrabhu joined the channel
#
[LewisCowles]
Hmm.. I need to test uploading a file to meetable. aaronpk, any help?
#
aaronpk
make an event, then you can upload a photo to the event
#
aaronpk
on the event page it's under the dropdown next to "edit"
[mapkyca] joined the channel
#
[LewisCowles]
I only have 3 links
#
[LewisCowles]
• Meetable
#
[LewisCowles]
• Past Events
#
[LewisCowles]
• Discover
#
aaronpk
are you not logged in?
#
[LewisCowles]
How do I 😂
#
[LewisCowles]
no idea how to use this
#
[LewisCowles]
is it in the README
#
aaronpk
ohh I need to flip the logic on showing the login link
#
aaronpk
visit /login for now
#
[LewisCowles]
oh dude `AUTH_SHOW_LOGIN=true`
#
aaronpk
well it's in the app settings now not .env
#
aaronpk
i'm gonna make it show it by default https://github.com/aaronpk/Meetable/issues/75
#
Loqi
[aaronpk] #75 Flip the logic on showing the login link
#
[LewisCowles]
I think it might be for the best. I’ve also not set it up with Github, so I guess I should check that one of the two login methods is supported
#
aaronpk
I got heroku login working if you want to wait a few minutes for me to push it up. it requires one manual step right now cause I haven't done the integration with the installer yet
#
[LewisCowles]
Sure. I’ll play tester
#
aaronpk
if you want to test the actual experience I should finish the installer integration first then
#
[LewisCowles]
dude, S3 works
KartikPrabhu joined the channel
#
[LewisCowles]
so did you write a heroku oauth client, or use a generic library?
#
[LewisCowles]
Also does heroku oauth need S3?
#
aaronpk
neither, oauth is simple enough to do by hand
#
aaronpk
it'd be way more complicated to use a library, heh
#
aaronpk
alright that was a beast of a change, but all 3 sites are running it now
#
GWG
aaronpk: Unrelated note, I modified your FA gist to accept older flights than today for backfill
#
[LewisCowles]
umm. So do I need to turn off GitHub to use heroku?
#
aaronpk
GWG: nice
#
[LewisCowles]
I’ve put the client and secret in ENV
#
aaronpk
[LewisCowles]: set AUTH_METHOD=heroku and give it a heroku client ID and secret
#
aaronpk
I updated the .env.example and readme to reflect that too
#
[LewisCowles]
it’s the AUTH_METHOD I was missing.
#
[LewisCowles]
for some reason I was expecting a chooser
#
[LewisCowles]
like IndieAuth 😉
#
aaronpk
yeaa I didn't want to deal with multiple IDPs in this, that makes a whole new set of challenges
#
aaronpk
(IDP = identity provider)
#
[LewisCowles]
we use IDP at work 😉
#
[LewisCowles]
We’ve got an integration to Okta
#
[LewisCowles]
Btw it’s saying I don’t have a client ID, but I do
#
[LewisCowles]
from the heroku client command
#
aaronpk
what's saying that?
#
aaronpk
did you set it as HEROKU_CLIENT_ID in the config?
#
aaronpk
oh I didn't know about that
#
aaronpk
I don't know what that does with config vars
#
aaronpk
I used the API to make my client https://devcenter.heroku.com/articles/platform-api-reference#oauth-client-create and set the client ID and secret config vars manually
nek11Discord[m] joined the channel
#
[LewisCowles]
yeah I thought I’d link the command. It’s the same one. I think you picked two different names. It’s my bad Scanning the beginnings and ends only I see now that they put OAUTH where you put CLIENT
#
[LewisCowles]
I do get a 404 when I return to the app
#
aaronpk
I just picked arbitrary values for those config vars, I had no idea heroku could set them manually
#
aaronpk
automatically not manually
#
aaronpk
oookay some voodoo is happening...
#
aaronpk
can someone please explain what is happening here...
#
aaronpk
when I run it from my laptop, I get a response. when I run it from my server, it says "unauthorized"
#
aaronpk
is curl sending some header i'm not aware of??
#
[LewisCowles]
I think it’s because the command I just shared has /callback which is the method, not a part of the web routes
#
[LewisCowles]
I’m making a new client and deleting the old one
#
aaronpk
omg it is... -n
#
aaronpk
yea you need to set the redirect URL to what's in the readme
nek1113Discord[m joined the channel
#
[LewisCowles]
hehe, people need to have allowed users, not just admins in their site to use heroku
[Sadik_Shahadu] joined the channel
#
aaronpk
like I said in the readme, the heroku login is not meant for a multi-user installation
#
aaronpk
it's for when you want just yourself to log in to manage events
#
[LewisCowles]
Right but the first user login failed
#
[LewisCowles]
so this one was the first
#
aaronpk
hm it shouldn't have failed
#
aaronpk
let me try again
#
aaronpk
it worked on mine
#
aaronpk
if there is an existing user in the DB then it will not let anyone else log in
SnoochToTheNooch joined the channel
#
[LewisCowles]
I logged in with a new private window and it worked
#
[LewisCowles]
shouldn’t be cookies as they can’t set them on our domain
#
[LewisCowles]
at least it worked
sivy-phone joined the channel
#
[LewisCowles]
anyway taking the wife to the movies, so have fun 👋
#
aaronpk
are the PRs in a place where I should merge them?
#
[LewisCowles]
Redis is also
#
aaronpk
thanks!
RenegadeDiscord[ joined the channel
#
[LewisCowles]
Thanks for showing me around too
nek1113Discord[4 joined the channel
#
aaronpk
For those following along at home, this is the reason I don't "productize" more open source projects... it takes soooo much work to get it to a point of being installable by others
#
aaronpk
anyone who has set up aperture or compass knows what I'm talking about, those are not optimized to be able to be installed by others
#
KartikPrabhu
same :P though nothing I have is even close to your setup
#
GWG
aaronpk: I found Compass easy enough, though I should submit some PRs to the readme
#
[jgmac1106]
having the weirdest issue as we migrate a website at work, legacy links to assets (mainly pdfs) with any uppercase in the url will not resolve to https but if there aren't any uppercase the redirect is fine, we use hostgator, at their highest tier of support, funny bug
nickodd left the channel
#
[jgmac1106]
i guess that is more chat, sorry
KartikPrabhu and [dmitshur] joined the channel
#
[dmitshur]
any objections if I add my personal site to the list of IndieAuth clients at https://indieweb.org/IndieAuth#IndieAuth_Clients ? when I was implementing an IndieAuth authorization endpoint, I used that list to test my implementation, so the more the better IMO.
#
aaronpk
go for it!
chrisaldrich joined the channel
#
aaronpk
oo there's a mailgun add-on for heroku too, that solves some things
gRegorLove joined the channel
#
aaronpk
oh gosh why didn't I think of this before... my coworker has been working on an okta add-on for heroku, so that should end up being a super easy way to get login support
#
aaronpk
I think I hadn't wrapped my head around heroku add-ons yet
gxt joined the channel
#
@jgmac1106
↩️ That was my thought behind http://samizdat.jgregorymcverry.com/ an academic journal run on syndication and webmentions. (https://quickthoughts.jgregorymcverry.com/s/1UNbFI)
(twitter.com/_/status/1223718255484964870)
#
@miklb
If anyone is currently posting photos to WordPress using micropub that syndicates to Twitter using http://brid.gy, please raise your hand & share your template.
(twitter.com/_/status/1223731305004851200)
[Christina_Hendr, [jgmac1106], miklb and [chrisaldrich] joined the channel
#
aaronpk
so close
#
aaronpk
I think the browser is caching a redirect
#
aaronpk
this might actually be a 5-minute install
#
aaronpk
2 minutes 30
[Michael_Beckwit and [LewisCowles] joined the channel
#
[LewisCowles]
2.5 minute install for what?
#
aaronpk
heroku deploy
#
aaronpk
to a running site
#
aaronpk
just one weird thing happening, I can't seem to tell when it finishes restarting itself
#
aaronpk
or maybe this is the browser caching the whole page
#
aaronpk
there's definitely a no-cache header tho
#
[LewisCowles]
IDK, maybe some of that was what I was seeing earlier
#
[LewisCowles]
I’ve not touched the headers
#
aaronpk
trying one more time
#
aaronpk
if this works I need to make a screencast
davepeck joined the channel
#
[LewisCowles]
By 2.5 minutes; are you using existing OAuth client + secret and the turn-key addons of Heroku, or running some shared-hosting tests, or the manual Heroku?
#
aaronpk
I...did some things
#
aaronpk
there's a little helper app running on meetable.org which will register a Heroku OAuth app for you, and also can go set the config vars in your account via the API
#
aaronpk
ok I think the heroku deploy button is not getting the latest code from github
#
aaronpk
I added a route and it's not on a fresh deploy
#
[LewisCowles]
linking it to your github is a separate step sadly
#
[LewisCowles]
the button just allows you to deploy
#
aaronpk
what is it deploying?
#
Loqi
It looks like we don't have a page for "it deploying" yet. Would you like to create it? (Or just say "it deploying is ____", a sentence describing the term)
#
[LewisCowles]
settings, deploy, from github
#
aaronpk
no I mean starting from scratch
#
Loqi
[aaronpk] Meetable: a minimal events aggregator
#
aaronpk
I assumed heroku would go get the latest code from github
#
[LewisCowles]
deploying is taking a specific revision of an application source code or pre-built, and setting it up on a machine
#
aaronpk
how does heroku know what revision to deploy? there's no parameters in the deploy button
#
[LewisCowles]
It takes the URL of the referer AFAIK
#
aaronpk
that's what I thought, so why doesn't it have the latest changes?
#
[LewisCowles]
you can add URL parameters to force behaviours
#
[LewisCowles]
maybe they are retrieving a cached version from GitHub.
#
aaronpk
right that was my first thought above
#
[LewisCowles]
having a URL does not and should not mean a Live URL is fetched
#
[LewisCowles]
try checking out and pushing a branch
#
[LewisCowles]
old-school cache-busting
#
[LewisCowles]
from master OFC
#
aaronpk
can the deploy button deploy from a branch via the http referer or do I need to do something fancy?
#
sknebel
Using a custom Git branch
#
sknebel
If you’d like the button to deploy from a specific Git branch, you can use a fully qualified GitHub URL as the template parameter:
#
[LewisCowles]
Right, but you don’t need to do that sknebel
#
[LewisCowles]
it’ll use the referrer you click from
#
[LewisCowles]
I was deploying from the branch I was PR’ing
#
aaronpk
cool it works from a commit hash too
#
aaronpk
ok! that was the problem, it was caching the master branch not fetching it each time
#
[LewisCowles]
How Unfortunate
#
aaronpk
the good news is the code I wrote does work
#
aaronpk
cool cool cool
#
aaronpk
you know i'm kinda on the fence about adding redis to the heroku deploy at all now
#
[LewisCowles]
don’t then
#
aaronpk
there isn't really a performance boost for queuing in this case, because the queue is processed on a cron job anyway
#
aaronpk
I don't even think i'm using Laravel caching anywhere, so that just leaves sessions, and cookie sessions are faster anyway
#
[LewisCowles]
It really depends on where a thing is setup. I don’t like blanket perf statements.
#
[LewisCowles]
unless they are on very small scales, even then the controls will influence
#
aaronpk
sure but like the odds of the redis server being physically close enough to the app server are very low in this case, so there's always gonna be some network latency there, whereas cookie sessions have no network latency
#
[LewisCowles]
we have a site with a minimal number of things. Nothing will change it’s broad performance characteristics right now
#
[LewisCowles]
cookies are transmitted between the client & server per-request. Don’t believe they are faster or slimmer as a blanket. It would defy physics for the whole of a thing, travelling the full distance of the WWW to be faster than anything not needing to do so.
#
[LewisCowles]
It’s okay that we don’t use Redis. It certainly has some desirable properties.
#
[LewisCowles]
I like that you only support MySQL. I prefer it
#
aaronpk
there's just very little session data stored at all, certainly not enough that the extra bytes are going to slow things down. it has to send a cookie header every request anyway
#
[LewisCowles]
Doesn’t make it wrong to use Postgres
#
[LewisCowles]
I’m easy RE: Redis. I’ll close it.
#
aaronpk
if someone really wants to they can always set the laravel config options directly, it's not like i'm preventing that
#
[Michael_Beckwit
ugh cookies
#
aaronpk
(I am preventing postgres cause I have that raw SQL query in there, we can solve that later)
#
aaronpk
it'd be nice to be able to support postgres too
#
aaronpk
ooook I can't believe i've spent all day on this. time for a break