#known 2015-11-08

2015-11-08 UTC
j12t, tantek, raretrack, tommorris, cmal and mattl joined the channel
#
cmal hey
#
cmal I'm just wondering: has this bug been addressed already? https://github.com/idno/Known/issues/753 (following redirects for webmention avatars)
#
cmal (I've just upgraded to 0.8.5 so I guess I'll find out soon enough :D)
#
cmal okay so it's not fixed just yet apparently: Bridgy still sends in the webmention a URL that is a redirect to the avatar
#
cmal I'm just wondering: would always following redirects in Webservice:send() break anything?
#
cmal (i.e. is any part dependant on whether there is a redirect or not?)
#
cmal or maybe it should be in file_get_contents() if code is 302 then rerun the request with the redirect URL?
tantek, j12t and Tino joined the channel
#
cmal okay here's my quick fix for Webservice.php : https://framabin.org/?8ce819f58d7780ec#hkOk03e0OMSXgKzm2BpZQfRW4UIj/yK8IGzccanAk8Q=
#
cmal I'm not sure whether this corresponds to the coding standards/guidelines (if there are any) but I'd be glad to make the required changes
#
cmal just made a pull request : https://github.com/idno/Known/pull/1096
#
cmal also just opened a ticket regarding avatars being stored as new files every time (takes a crazy amount of space for no reason) : https://github.com/idno/Known/issues/1097
j12t and cmal joined the channel