#microformats 2017-05-05

2017-05-05 UTC
tantek, rodolfojcj, gRegorLove, barpthewire, nitot_, [colinwalker], [chrisaldrich], adactio and nitot joined the channel
#
@tobiastom @ttepasse Microformats ersetzen. (twitter.com/_/status/860463379919646720)
nitot_, twisted` and tantek joined the channel
#
ben_thatmustbeme schmarty: i'm close to having it good to go, i just want to update the test suite now
#
ben_thatmustbeme but i can't figure out a sane way of doing it without getting someone to actually work throught the updates with me
#
ben_thatmustbeme and then put microformats-tests in to composer
[kevinmarks] joined the channel
#
schmarty ben_thatmustbeme: sorry for my confusion - the tests are a PHP package that need to be (re-)released?
#
ben_thatmustbeme the tests are just a set of html and equivalent json
#
ben_thatmustbeme i want people to just be able to pull the latest version of that
#
ben_thatmustbeme so that means using <something> to pull down the latest set
#
ben_thatmustbeme simplest methods are npm or composer, the test set is in npm, but its way out of date
#
ben_thatmustbeme i said the heck with it, and in the meantime, i just wrote a copy of all the tests directly in to the git repo
#
ben_thatmustbeme https://github.com/dissolve/microformats2-ruby/tree/rewrite
#
ben_thatmustbeme here is my up to date code
#
ben_thatmustbeme now i need to find out what the next steps would be for it? new gem? replace old? if so, who needs to review?
#
ben_thatmustbeme created a PR as well, hopefully that will trigger some emails to those interested
#
aaronpk oh wow
#
aaronpk ben_thatmustbeme++
#
Loqi ben_thatmustbeme has 7 karma in this channel (212 overall)
#
aaronpk shaners was leading the previous version so we can probably get him to sign off on it
#
aaronpk i think he owns the rubygems one too
#
ben_thatmustbeme never dealt with rubygems
#
ben_thatmustbeme it might actually just pull from github?
#
aaronpk pretty sure you have to run a publish command
#
aaronpk but it's been a while since i've published a gem
barpthewire, [joemcl], gRegorLove, [colinwalker], [chrisaldrich], [evanwolf] and [kevinmarks] joined the channel
#
[kevinmarks] I did a github subproject, but not sure that is ideal either
KartikPrabhu, gRegorLove_, nitot, tantek and [shaners] joined the channel
#
[shaners] ben_thatmustbeme Hi! This PR email was such a pleasant surprise to wake up to today!
#
ben_thatmustbeme :)
#
[shaners] tl;dr I’m down.
#
[shaners] There a handful of very small details that’ll need be sorted. But this is amazing. ⭐⭐
#
ben_thatmustbeme yeah, i figured there would be some things
#
[shaners] I’m working my way through the PR now and making issues about what’ll need doing to do this Right™
#
[shaners] One of which is work through the issues and close ones that this addresses.
#
[shaners] Wanna take a look at those?
#
[shaners] https://github.com/indieweb/microformats2-ruby/issues
#
ben_thatmustbeme just from a quick look at that, most of them, lol
nitot joined the channel
#
[shaners] That’s what I expected
#
[shaners] Which is fucking great!
#
ben_thatmustbeme hehe
#
ben_thatmustbeme it doesn't do the include-pattern yet
#
[shaners] That’s fine. At least that’s not a regression. Since it never did.
#
ben_thatmustbeme solves #5, #8, #9, #11, not sure on #21, #26
#
[shaners] Here’s the biggest thing that I would *prefer* to release a `2.9` that adds deprecation warnings to everything that breaks in `3.0`. That’s not as a trivial as a note in README. So, it’s a “would really *like* to have”, but not a “must have blocker”.
#
[shaners] How would you feel about doing the deprecation warnings?
#
ben_thatmustbeme #29 is why i decided to completely rewrite
tantek joined the channel
#
[shaners] Yeah. #29 was hairy.
#
[shaners] #21 should be its own gem frankly. That this one then depends on.
#
aaronpk i would consider writing that
#
aaronpk i wrote the PHP one
#
ben_thatmustbeme a 2.9 version with deprecation would make sense
#
ben_thatmustbeme not totally sure how it would work
#
ben_thatmustbeme this one builds up the hash fully first, then just wraps it up in an object
#
ben_thatmustbeme i think the main things that are dropped are .all changes to (:all)
#
ben_thatmustbeme and plural names
#
ben_thatmustbeme also classes change names, so if anyone is relying on that
#
aaronpk do people update to new major versions without checking for compatibility?
#
ben_thatmustbeme #31 , #32, #34 would all be taken care of....
#
ben_thatmustbeme #35 (would need to double check that, but it doesn't use that any more)
#
ben_thatmustbeme and #40
#
ben_thatmustbeme not sure what #39 is asking yet
#
ben_thatmustbeme doesn't really make sense, its just a ruby script isn't it?
#
[shaners] aaronpk You’d be surprised.
#
[shaners] But even if they do, a deprecation EOL `2.x` is Good Form™ to do.
#
[shaners] ben_thatmustbeme wrt class name changes, maybe you could a post install message in the `2.9` release that mentions those kinds of things that you can’t easily throw warnings for.
#
ben_thatmustbeme that would make sense, never done a release at all though, so not sure how the install process works at all honestly
#
[shaners] Does that sound like a fun learning opportunity to you? Or an annoying chore?
#
ben_thatmustbeme lol
#
ben_thatmustbeme i feel like i just walked a marathon
#
[shaners] Btw, I’m happy to do the actual release to rubygems (and document the process to hand off to you for future ones)
#
ben_thatmustbeme that would be cool
#
[shaners] No doubt. This was Herculean.
#
ben_thatmustbeme but as to chore or fun learning experience, normally it would be good learning, right now its more like AHHH MORE STUFF!!!
tantek joined the channel
#
[shaners] If we can get something for `2.9` to at the very raise a symbolic flag to say "`3.0` is breaking things, look out”, then I’ll play Release Manager for 2.9 and 3.0. Then doc and hand off release management to you.
gRegorLove_ joined the channel
#
[shaners] I’ll stay on as one of the gem owners, just in case. To keep our bus score > 1. ?
#
[shaners] But it’ll be all yours to run with.
#
ben_thatmustbeme bus score?
#
[shaners] what is bus score?
#
ben_thatmustbeme so you think doing it in the 2.x branch just modify that branch with deprecation warnings for the forthcoming 3.0
#
[shaners] Yes ?
#
ben_thatmustbeme alternatively it may be possible to wrap everything in the old class structures / use all that code for adding functions and just make 2.9 a shell of 3.0
#
[shaners] That’ll likely add another pass to your PR, but it should be easy enough to merge/rebase the deprecation warnings into your branch.
#
[shaners] nah. keep it simple. invest in 2.x as little as possible.
#
[shaners] 3.0 is the target
#
ben_thatmustbeme my work is never done :)
#
ben_thatmustbeme actually i do have some changes for the 2.9 branch already, things i had already started to fix in 2.x
#
[shaners] It’s just software, right? ?
#
[shaners] Bus Score : the number of people in an org that it’d take getting hit by a bus to stop the org.
#
ben_thatmustbeme https://github.com/dissolve/microformats2-ruby/commits/master
#
ben_thatmustbeme hah, never heard it put that way
#
[shaners] For a time, Apple Computer had a bus score of 1 (Woz)
#
[shaners] How about this?
#
ben_thatmustbeme i'll work off that code, it adds a number of features to the parsed result without breaking anything and start that as a 2.9 branch
#
ben_thatmustbeme then go through and add deprecation warnings on all() and the plural functions
#
[shaners] Let’s get whatever non-breaking changes/fixes that you have on your fork into a PR for master. And I’ll merge in that PR.
#
[shaners] And I’ll give you commit to this repo, so you can do your deprecation warnings work right on master on the main repo
#
[shaners] We’ll release 2.9. Then update your 3.0 PR. Merge. Release. Hand off. Cool?
#
ben_thatmustbeme i think i actually already have commit access for the indieweb group
#
[shaners] Oh great. Then PR your existing 2.x changes and let’s merge than in.
#
ben_thatmustbeme https://github.com/indieweb/microformats2-ruby/pull/47
#
Loqi [dissolve] #47 2.x updates
#
ben_thatmustbeme i can pretty quickly revert the spec changes and stuff i did, clean it up a bit
#
[shaners] If you want. Or you can do it on the incoming commits for the deprecation warnings.
#
ben_thatmustbeme ah yeah, i'll work that out then
#
ben_thatmustbeme so i guess give me a few days to work out all the deprecation warnings
#
[shaners] Take whatever time you want. This is your baby.
#
[shaners] I’m just here to make sure we honor existing users and do right by them. ?
#
ben_thatmustbeme all of this because i went to put mf2 tests in to mastodon so it wouldn't break again
#
ben_thatmustbeme and couldn't use it to test h-feeds
#
ben_thatmustbeme [shaners]: want me to merge those 2.x changes in now or wait?
#
ben_thatmustbeme also to make sure i have write access
#
[shaners] You can merge 2.x now
#
[shaners] we just won’t release 2.9 gem yet
#
[shaners] Just made you an admin on the repo
#
[shaners] I’m off to see Guardians movie. I’ll finish my PR review and issues prep work when I get back.
#
ben_thatmustbeme enjoy
tantek, nitot, gRegorLove, gRegorLove_, [evanwolf], [joemcl], [kevinmarks] and [tamaracks] joined the channel