#microformats 2018-01-22

2018-01-22 UTC
[kevinmarks], [miklb], [eddie], [colinwalker], jjuran, KartikPrabhu, chrisaldrich, tantek and [kingkool68] joined the channel
#
[kingkool68]
Added microformats to my daughter's sites https://zadieheimlich.com/
#
Loqi
Zadie Heimlich
#
[kingkool68]
Feedback on the markup is welcome
[miklb] and tantek joined the channel
#
KartikPrabhu
[kingkool68]: that is a great site!
#
KartikPrabhu
though you seem to be using "h-card p-author u-url" on the via links
#
KartikPrabhu
for the p-author this works great and puts the h-card in there. but it also puts the h-card in the u-url
#
KartikPrabhu
which is weird but may not be a big problem
tantek, [eddie], [kingkool68], [cleverdevil], nitot and barpthewire joined the channel
adactio, nitot_, nitot, [colinwalker] and [kevinmarks] joined the channel
#
ben_thatmustbeme
wow, lots to review for microformats-ruby
#
ben_thatmustbeme
specifically the new logo that was suggested for the project
#
ben_thatmustbeme
want to make sure thats OK as its clearly just a recolor of MF logo
#
[kevinmarks]
We've had orange and red before
#
aaronpk
in general i'm not a fan of modifying logos, but usually color variations is okay. imagine reading a branding guidelines book for microformats, would this be something they say is acceptable?
#
aaronpk
usually the branding guidelines say things like, don't put things that overlap the logo. don't rotate the logo. there's usually a certain amount of space required between the logo and other elements on the page.
#
[kevinmarks]
There is an orange variant on the microformats.org front page
[jgarber] joined the channel
#
[jgarber]
My thinking was that it’d be clever to combine the microformats logo w/ a touch of Ruby’s color scheme (overwhelmingly red).
#
[jgarber]
Hello, all!
#
[jgarber]
☝ I’m not wed to the logo, of course. Happy to nix it if the consensus is against using it.
#
[jgarber]
ben_thatmustbeme Thanks for taking the time to review my PR. I promise future PRs won’t be quite so large. 😂
#
ben_thatmustbeme
haha, no problem
#
Loqi
hehe
#
ben_thatmustbeme
I would say, fix the 'Ruby 3.5.0 typo', revert the Liscence.md and remove the logo and start that as an issue
#
ben_thatmustbeme
and it would be good to merge
#
aaronpk
I think the logo is fine
#
ben_thatmustbeme
i wasn't sure what the usage terms were on the logo were aaronpk
#
ben_thatmustbeme
thats why i just wanted to confirm that first
#
aaronpk
is the mf wiki all cc0 too?
#
[jgarber]
ben_thatmustbeme Fixed the Ruby version typo and reverted `LICENSE.md`.
#
Loqi
Microformats:Copyrights
#
[jgarber]
☝ Depends on the date of the addition, according to the copyright page.
#
[jgarber]
Content added after 2007-12-29 is automatically public domain.
#
[jgarber]
I’m not 100% sure when that particular logo was added.
#
[jgarber]
I’ll go ahead and remove the logo. It doesn’t add anything to the `README.md`. Perhaps we could revisit and use it on a GitHub pages-style site for the gem if we want to go that route.
#
aaronpk
here's an example of what not to do with the microformats logo: https://ps.w.org/semantic-linkbacks/assets/icon-256x256.png?rev=1794852
#
ben_thatmustbeme
[jgarber]: i'd say start a seperate issue for the logo
#
ben_thatmustbeme
i like it, just want to make sure all ducks are in a row
#
Loqi
spread-microformats
#
[jgarber]
ben_thatmustbeme Will do!
#
ben_thatmustbeme
this was it initially getting added to the wiki
#
[jgarber]
Ah, okay, so it does pre-date the public domain dedication.
#
Loqi
spread-microformats
#
ben_thatmustbeme
looks like he gave the ok to public domain it
#
[jgarber]
ben_thatmustbeme Okay, logo’s removed from `README.md`.
#
ben_thatmustbeme
so if thats the case, maybe we go ahead with it
#
[jgarber]
Excellent!
#
[jgarber]
Hah! I’m fine either way. I can un-revert the revert. 😆
#
[jgarber]
…and/or file the aforementioned GitHub issue.
#
ben_thatmustbeme
lets put it on its own issue / PR just so it will be easy to refer back to later
#
[jgarber]
Perfect. Filing that issue now.
#
ben_thatmustbeme
i'll be back in a bit
#
[jgarber]
ben_thatmustbeme Thanks! Appreciate the thorough reviews from you and shaners.
#
[jgarber]
Next steps I intend to take are to begin addressing RuboCop issues.
nitot_ joined the channel
#
Loqi
[jgarber623] #78 Discussion: microformats-ruby logo
#
[jgarber]
ben_thatmustbeme Also forgot to note some configuration changes to report code coverage. Details: https://github.com/indieweb/microformats-ruby/issues/79
#
Loqi
[jgarber623] #79 Configure Travis CI / Code Climate coverage reporting
#
ben_thatmustbeme
I don't have access to code climate, not sure who does actually
#
ben_thatmustbeme
it looks like as i'm not an owner of the indieweb group i cannot get access
#
ben_thatmustbeme
might need to ask aaronpk for that part
#
aaronpk
I don't think that's me
#
aaronpk
probably shaners
#
ben_thatmustbeme
i tried to re-add the project figuring that might work, but unless you are and "admin and owner" of the project, it won't be listed
[jgarber] joined the channel
#
[jgarber]
> *Note:* For an organization-owned repository, you must be in an organization’s Owners group to perform the actions described in this article. Alternatively, if you added the repository in question by clicking Add Open Source Repo, you must have GitHub-rights to administer the repository.
#
[jgarber]
aaronpk Yeah, I’m digging through Code Climate’s help docs. They treat organization-owned repos differently than user-owned repos.
#
[jgarber]
I see a similar lack of settings on a Code Climate repo that belongs to an organization I’m an owner of.
tantek joined the channel
#
[jgarber]
aaronpk Okay, got Code Climate to recognize that I’m an owner of an organization-owned repo by doing the following:
#
[jgarber]
1. Follow the steps on this page: https://docs.codeclimate.com/v1.0/docs/approve-code-climate-as-a-third-party-application-in-github to make sure the IndieWeb GitHub organization is granting access to Code Climate (turns out this was off for my org-owned repo).
#
[jgarber]
2. Over on Code Climate, go to https://codeclimate.com/oss/dashboard and click “Add Repository” in the top right.
#
[jgarber]
4. Once that’s done, click “Add Repo” next to any of the IndieWeb GitHub organization-owned repos that you’d like to add to Code Climate. This is silly since, if your account is anything like mine, many of those repos are already in Code Climate. Go figure.
#
[jgarber]
3. Click “Sync now” in the top right.
#
[jgarber]
After re-adding the org-owned repo, I was able to see the Settings option in Code Climate.
#
tantek
hey [jgarber]!
#
tantek
this sounds like a good #indieweb-dev discussion :)
[kevinmarks] joined the channel
#
[jgarber]
tantek Hey-o! Did not realize that was a channel. Thanks for the head’s up.
#
tantek
you're already in it :)
#
[jgarber]
Just joined! 😄
KartikPrabhu, [eddie], [cleverdevil] and [kingkool68] joined the channel
#
[kingkool68]
@KartikPrabhu Ah I see. Thanks
#
KartikPrabhu
[kingkool68]: it is correct according to the parsing rules so you might not need to change anything
[keithjgrant] and [xavierroy] joined the channel
#
ben_thatmustbeme
KartikPrabhu: really? i got the same thing with the ruby parser too though
#
KartikPrabhu
ben_thatmustbeme: yes it is in the parsing rules for child h-* with u-* property on it
#
ben_thatmustbeme
pulls up the parsing spec
#
ben_thatmustbeme
not seeing it KartikPrabhu
#
ben_thatmustbeme
i see special rules for paring a value: in those cases
[kevinmarks], nitot, tantek, [eddie], camb, [jgmac1106], [miklb], [cleverdevil], [keithjgrant], chrisaldrich, [sdepolo], KartikPrabhu and [chrisaldrich] joined the channel
#
@jekyllrb
Default theme minima v2.2.0 brings better SEO, microformats, and support for more social networks. Feel free to bundle update. https://rubygems.org/gems/minima/versions/2.2.0
(twitter.com/_/status/955551155031101440)
[jgarber] joined the channel
#
[jgarber]
So cool! Well done, barryf! 👏
[kevinmarks], [barryf] and tantek joined the channel
#
@barryf
🎉 Jekyll’s default Minima theme now has #microformats baked in to its templates. Really pleased to see my pull request merged in the latest gem release. #indieweb https://twitter.com/jekyllrb/status/955551155031101440
(twitter.com/_/status/955569706693464065)
KartikPrabhu and [barryf] joined the channel
#
[barryf]
Thanks jgarber !
KartikPrabhu, tantek and [miklb] joined the channel
#
[kevinmarks]
microformats wiki seems slow today
#
tantek
kevinmarks, just got a subsecond load
#
tantek
any page in particular?
[eddie] and [andrea_arbogast joined the channel