#microformats 2018-07-02

2018-07-02 UTC
KartikPrabhu, GWG-, [snarfed], barpthewire, [dougbeal], adactio, [jgmac1106], [jemostrom], [manton], [eddie], [wiobyrne] and gidzit joined the channel
#
aaronpk forgot that the ruby parser didn't get updated for the new implied p-name rules yet! https://github.com/indieweb/microformats-ruby/issues/86
#
Loqi [aaronpk] #86 Updates for new implied p-name rules
#
aaronpk anyone feel like jumping on that?
[jeffperry], [cleverdevil] and [cjwillcock] joined the channel
#
[cjwillcock] microformats.org seems to be down. https://downforeveryoneorjustme.com/microformats.org
#
aaronpk looks fine to me
#
[cjwillcock] it came back, just like that - thanks for checking
#
jmac wfm too (and DFEOJM syz it's up now)
#
[cjwillcock] seems to be some thrashing going on - microformats.org is down again now
[kim_landwehr], [kevinmarks], [manton], jackjamieson and [jgarber] joined the channel
#
[jgarber] aaronpk: Semi-related, but I’ve been doing similar cleanup on the microformats Ruby gem with the goal of making it easier to work on.
#
[jgarber] I’m not sure who’s got admin rights to the repo, though, so progress has been slow.
#
[jgarber] aaronpk: Is there a public test suite (similar to https://webmention.rocks) for Microformats?
#
aaronpk kinda, there's a github repo with a bunch of test cases
#
aaronpk some of the test cases are wrong tho 😂
#
aaronpk https://github.com/microformats/tests
#
Loqi [microformats] tests: Microformats test suite
#
[jgarber] _right_ 🙃
#
aaronpk most of the simple ones are right tho, it's still a good start
#
[jgarber] I may be able to devote some time to cleanup on that gem this week that should help with future improvements.
#
aaronpk that'd be amazing
#
[jgarber] I’ll see where I left off. Not sure how active [ben_thatmustbeme] and [shaners] are on that repo, though.
#
[jgarber] I 100% wanna make this better: https://codeclimate.com/github/indieweb/microformats-ruby 😄
#
@marinintim @aaronpk Is http://microformats.org down? (twitter.com/_/status/1013838053427875840)
#
aaronpk that poor server
#
ben_thatmustbeme i'm around, just super busy
#
ben_thatmustbeme [jgarber]: if you want to work from my code-cleanup branch, I started adding a bunch more tests / coverage
#
ben_thatmustbeme but i know the hold-up was the ruby version thing
#
ben_thatmustbeme i'm fine moving 2.4 as a requirement
#
ben_thatmustbeme i don't really see a good reason for it though unless we are actually using something that requires it
#
ben_thatmustbeme otherwise you are just needlessly breaking support for legacy code
#
aaronpk okay, rebooting the server is no longer actually fixing the problem
#
aaronpk adminhelp: does anyone know the current root password on the server so I can go in and actually look at what's going on? If not, I am happy to reset it.
#
[jgarber] [ben_thatmustbeme] Agreed. I’ve come around on that one. Authoring in 2.4.x (2.4.4 being the most current) and running Travis, etc. against 2.4.x, 2.5.x seems like the wiser approach.
#
[jgarber] [ben_thatmustbeme] Would you be hip to add me as an admin on the indieweb/microformats-ruby repo?
#
ben_thatmustbeme [jgarber]: invite sent
[kim_landwehr] joined the channel
#
[jgarber] [ben_thatmustbeme] Thanks!
[eddie] joined the channel
#
[jgarber] [ben_thatmustbeme] Did you invite `jgarber623` (my GitHub username) ?
#
ben_thatmustbeme yes
#
ben_thatmustbeme [jgarber]: https://github.com/indieweb/microformats-ruby/invitations
#
ben_thatmustbeme i believe you need to go there
#
[jgarber] Hrm, that redirects me back to the main page of the repo.
[cleverdevil] joined the channel
#
ben_thatmustbeme its not actually showing it as an invite, more like you are just added actually
#
[jgarber] Ah, right. Okay. So I may have Read or Write permissions. I forget which is the default.
#
[jgarber] https://github.com/indieweb/microformats-ruby/settings/collaboration would show collaborator permissions.
#
ben_thatmustbeme i think you already had it anyway from being in the indieweb group
#
[jgarber] Mind flipping me to an Admin?
#
[jgarber] Yeah, org permissions are gnarly on GitHub…
#
ben_thatmustbeme org that is
#
ben_thatmustbeme what would you need admin for exactly?
#
[jgarber] Only useful bit would be adding/modifying/removing integrations (e.g. Travis, CodeClimate, etc.)
#
[jgarber] But that’s not 100% necessary if you’d rather leave me as a “Write”
#
ben_thatmustbeme i'd rather just leave it for now
#
[jgarber] Not a problem! 👍
#
ben_thatmustbeme also, by the way, the code smell score, is mostly based on the fact that functions are large, which actually was intentional to make them match the parsing spec as I remember
#
ben_thatmustbeme i need to look at all that code again, I would hold off on a new version release if we want to look at a full refactor like that
#
ben_thatmustbeme also, updated the code-coverage branch just now to 2.4.4
#
[jgarber] I saw! 🎉
#
[jgarber] I’ll close out #85 (the Ruby version tracking issue).
#
ben_thatmustbeme i tried playing with #83 the other week and if I try to force it to work as the test suggests it should, it breaks a lot of other tests
#
ben_thatmustbeme so not entirely sure where to go on it
#
[jgarber] Yeah, that’s an interesting one…
#
ben_thatmustbeme as for #86, i need to review the spec changes
#
[jgarber] I’d be very much in favor of putting together a `microformats.rocks` test suite like we have with Micropub and Webmention (and a few other things, if memory serves…)
#
@dwhly ↩️ Or, you could just use the std client, and pull from the API in order to post the microformats. (twitter.com/_/status/1013853850095120384)
#
[jgarber] [ben_thatmustbeme] With the Ruby version changes, we’re introducing a breaking change which means the next version of the gem would be 5.0.0.
#
[jgarber] Should we create a milestone for 5.0.0 and add issues to the milestone?
#
[jgarber] Does that seem reasonable to you?
[Vanessa] joined the channel
#
ben_thatmustbeme sure
#
ben_thatmustbeme #78 can be resolved as well
#
[jgarber] Oh, goodness. Forgot about that. What’d we decide? I’m inclined to ditch the logo and references to it in the `README.md`.
#
[jgarber] Looks like #79 is rocking and rolling, too!
#
ben_thatmustbeme i think we said the licensing was fine, just go ahead with it
#
[jgarber] Rock and roll. I’ll get on that tonight.
[dougbeal], KartikPrabhu, tantek__, [manton] and [cleverdevil] joined the channel