#wordpress 2018-02-25

2018-02-25 UTC
tantek and [mrkrndvs] joined the channel
#
[mrkrndvs] Miklb this is what Chris and I got to https://github.com/mrkrndvs/ZenChild
#
Loqi [mrkrndvs] ZenChild: A child theme for ZenPress developed by Chris Aldrich
#
GWG Hello, [mrkrndvs]
[miklb] joined the channel
#
[miklb] [mrkrndvs] I see. There’s a lot I like with ZenPress, contemplating now if I want to do the work to get it where I’d like or keep going forward with my own. I seem to be at this cross road a lot, and always go back to my own.
tantek, brokaw and [mrkrndvs] joined the channel
#
[mrkrndvs] Hello GWG. I tried the url directly in the browser and it didn't work🤔 Will do some more tinkering later
brokaw joined the channel
#
[mrkrndvs] [miklb] I am using Independent Publisher for my main site, but I really like Zen. If I can get it working, it's my preferred Indie option.
brokaw, tantek, jeremycherfas, spaceoyster and [kevinmarks] joined the channel
#
jeremycherfas !tell mrkrndvs aaronpk the link loqi provided at https://chat.indieweb.org/wordpress/2018-02-24/1519502290049200 seems wrong.
#
Loqi Ok, I'll tell them that when I see them next
#
Loqi [Loqi] [Aaron Davis] 📑 ZenPress WordPress Theme https://collect.readwriterespond.com/wp-content/plugins/cookies-for-comments/css.php?k=bf97b0e7210983af1d52ab01832c0002&o=i&t=1231427737
voxpelli joined the channel
#
jeremycherfas I decided to share my working child theme for ZenPress in case it can help mrkrndvs and chrisaldrich https://github.com/jeremycherfas/zenpress-child.git
[mrkrndvs] joined the channel
#
[mrkrndvs] Thank you [jeremycherfas] I will have a look. Definitely keen on using ZenPress ...
#
Loqi [mrkrndvs]: jeremycherfas left you a message 1 hour, 14 minutes ago: aaronpk the link loqi provided at https://chat.indieweb.org/wordpress/2018-02-24/1519502290049200 seems wrong.
#
[mrkrndvs] Not sure what happened to my link too [jeremycherfas] https://collect.readwriterespond.com/zenpress/
#
Loqi [Aaron Davis] 📑 ZenPress WordPress Theme https://collect.readwriterespond.com/wp-content/plugins/cookies-for-comments/css.php?k=bf97b0e7210983af1d52ab01832c0002&o=i&t=879055261
#
[mrkrndvs] There is obviously an issue with the 'Cookies for Comments' plugin that Reclaim ship with their standard WP install.
#
jeremycherfas I wouldn't know :)
[mrkrndvs] joined the channel
#
[mrkrndvs] Hmmm, tried your child [jeremycherfas] but still not bringing in span information 🤔 will leave it for now
#
jeremycherfas Not sure I understand what you mean by "span information".
#
[mrkrndvs] I replied to your comment with screenshots. Not sure it makes anymore sense https://collect.readwriterespond.com/zenpress/#comment-751
#
[mrkrndvs] Oh and [jeremycherfas] I like the adjustments that you made to the theme for Fornacalia
#
jeremycherfas Ah. That explains it just fine. You're talking about the CSS governing the spacing around the entry. Which browser are you using? Are you familiar with using the Dev options to paly around with CSS? This is one I really may be able to help with.
#
[mrkrndvs] I'm using Chrome. Past midnight here. I will crack open Dev tomorrow. Just thought it strange that the stylesheets don't all come across 🤔
#
GWG Greetings all
#
jeremycherfas No probs. I'll be here all day tomorrow, CEST, so feel free to get in touch. I've a vague feeling it may be a setting in Customiser, rather than stylesheets. We can fix this one.
#
aaronpk jeremycherfas: that link is the photo URL in the post
#
aaronpk something is adding u-photo to the 1px image there
#
aaronpk ooh wait nevermind it's not u-photo, it's a microformats implied photo
#
jeremycherfas aaronpk I see it linked somewhere in the content but I can't quite see where exactly in the page it is coming from.
#
jeremycherfas I mean, I see it is comming from Cookies for Comments, but I don't know why. I always figure 1x1 pixel images are trackers of some sort.
#
aaronpk yeah looks like it's adding it into the content
#
aaronpk I think this is a parser bug kind of like the implied name stuff we've been talking about
#
jeremycherfas Just before the scripts at the bottom of the page. With display: none; So why do you think it is being given out in the feed?
#
aaronpk because the parser thinks it's a photo of the post
#
aaronpk https://github.com/microformats/microformats2-parsing/issues/21
#
Loqi [aaronpk] #21 reduce instances where photo is implied
#
aaronpk that image isn't even set to display:none, it's just 1x1 pixels so you don't really see it
#
jeremycherfas https://collect.readwriterespond.com/zenpress/:591:<img alt='css.php' src="https://collect.readwriterespond.com/wp-content/plugins/cookies-for-comments/css.php?k=bf97b0e7210983af1d52ab01832c0002&amp;o=i&amp;t=631041427" width='1' height='1' /> <div style="display:none">
#
jeremycherfas Is what I see
#
jeremycherfas Oh no, sorry. I was looking in the wrong place. In the rendered page it just sits there after the site and the display: none; is for the subsequent div.
#
sknebel kind of surprising we haven't hit (or noticed) that one a lot more
brokaw joined the channel
#
aaronpk the implied rules are sneaky, I can never keep them straight
#
aaronpk I think it's partly because the h-entry class is on the <body> tag which has only one child element, the <div id="page"
#
aaronpk and immediately after that div is the img tag
#
sknebel yeah. still, having one top-level image in an h-entry should happen all the time I would have thought
#
aaronpk it has to also have only one child element of the h-entry
#
sknebel no
#
sknebel else if .h-x>img[src]:only-of-type:not[.h-*] then use that img src for photo
#
sknebel that's the rule triggering here
#
aaronpk oh I see, it's only if there is exactly one img that is a direct child of the h-entry element
#
GWG aaronpk, I am thinking of tackling the authorization Endpoint in the coming weeks. You up for a review?
#
aaronpk nevermind, I can't read those selectors
#
aaronpk anyway this is way deep into #microformats syntax
#
aaronpk point is I think it's a parser bug and we should look at the implied photo cases again
tantek, [eddie] and [jeremycherfas] joined the channel