#wordpress 2018-05-28

2018-05-28 UTC
#
aaronpk GWG: the null scope error is the thing [miklb] has been talking about this whole time and i've been trying to reproduce
#
GWG I made some changes and released 1.4.3
#
GWG Still null? Odd
#
aaronpk well I haven't been able to reproduce that, but miklb says it's still happening
#
[miklb] I am using micropub master
#
[miklb] I just got the error again testing in Omnibear. Doesn’t happen in Quill. That’s with that return empty json fix
#
[miklb] GWG there are commits after 1.4.3
#
[miklb] should I test against that tag instead?
#
GWG No.
#
GWG That was an error regarding the push
#
GWG I just merged the body fix
#
[miklb] there isn’t a tag for 1.4.3 anyway
#
GWG There should be.
#
GWG I will address that
#
GWG [miklb]: There is on snarfed's repo
#
[miklb] oh, I see, some are tagged v4.1.1 and some are tagged 4.1.3
#
[miklb] so sorting it in the GUI I didn’t see the newer tags
#
GWG I took over and I don't do v
#
[miklb] sure
#
[miklb] personally I don’t either
#
GWG Sometimes, I think about rewriting the Micropub server using the REST API
#
GWG The ?micropub=endpoint bothers me
#
GWG Although not sure how much more it would add.
#
[miklb] well, progress today!
#
[miklb] I can at least post micropub from the desktop
#
[miklb] though I suspect the iOS quill issue is browser caching issue
#
GWG I like progress
#
GWG What do you think I should do?
#
[miklb] we should figure out how to best get a few other people to test your branch with master of micropub
#
Loqi I agree
#
GWG Well, pfefferle will do the review
#
[miklb] sure, a code review, but does that mean it gets released right away?
#
[miklb] I do wonder if we can do what aaronpk suggested and try to surface any other errors if the array is null
#
GWG I will look at that
#
GWG What line was it again?
#
[miklb] 266, 269
#
[miklb] 265, 268
#
[miklb] https://miklb-images.s3.amazonaws.com/Firefox_Nightly_2018-05-27_21-14-26.png
gRegorLove joined the channel
#
GWG Not sure why it is null
#
GWG But I wrote the scope code
#
[miklb] what’s weird is the error went away last night when I applied the fix in the one place. Switching to the changes in master, it came back
[quinnvinlove] joined the channel
#
GWG The same changes?
#
[miklb] I applied that first /fix manually and the error went away. I switched to master and it’s back. ¯\_(ツ)_/¯
#
[miklb] https://github.com/snarfed/wordpress-micropub/commit/5c86a008db8afd7017c13e5a77354737e2714e7d that’s what I applied manually
#
GWG I switched from null to the variable. I think maybe I should set it to empty array.
[cleverdevil], [Natris1979], [tantek], [jeremycherfas], tantek_, [quinnvinlove], petermolnar_, ben2 and [jgmac1106] joined the channel
#
[jgmac1106] thx all for the work on micropub
#
GWG Does it work for you?
[miklb] and [jgmac1106] joined the channel
#
[jgmac1106] nope
[miklb] joined the channel
#
[miklb] were you able to test it with GWG’s hooks branch though?
#
[jgmac1106] I tested with 1.4.3 micropub, 2.0.3 indieauth
#
[jgmac1106] micropub errors in both omnibear and quill
#
[miklb] right, the fixes are in GitHub. Latest master branch of micropub and branch in GWG’s fork of indieauth. There’s a PR for it in the main repo. That’s what needs testing. We need to find a way to make that easier.
#
[jgmac1106] okay I can try that
#
[jgmac1106] can you post link?
#
[miklb] if you don’t have git on your server, but can do SFTP, I believe you can download a zip of the branch and master and upload them.
#
[jgmac1106] yeah I can manually update plug-ins from Git,
#
[miklb] https://github.com/dshanske/wordpress-indieauth/tree/hooks
#
[miklb] https://github.com/snarfed/wordpress-micropub <- master
#
Loqi [snarfed] wordpress-micropub: A Micropub server plugin for WordPress
#
[jgmac1106] changed the name to built-in endpoint I see
#
[jgmac1106] Adding Micrpub now
#
[miklb] I still get errors in WP using Omnibear when attempting to post, but successfully authenticated and posted with Quill using those 2 versions
#
[miklb] as well as passed tests in micropub.rocks
#
[jgmac1106] trying now, I can't believe how hard you three worked all weekend
#
[jgmac1106] and........Your endpoint did not return a Location header.
#
[jgmac1106] are there any other plug ins I should turn off besides mf2 when using an indieweb theme?
#
[jgmac1106] <https://jgregorymcverry.com/wp-json/indieauth/1.0/token>; rel="token_endpoint", <https://jgregorymcverry.com/?micropub=endpoint>; rel="micropub", <https://jgregorymcverry.com/wp-json/webmention/1.0/endpoint>; rel="webmention", <https://jgregorymcverry.com/wp-json/webmention/1.0/endpoint>; rel="http://webmention.org/"
#
sknebel doesn't quill show more details when it gives ".Your endpoint did not return a Location header"?
#
[jgmac1106] yeah but I didn;t wnt to cut and paste a bunch of lines into Slack looks bad on irc
#
[jgmac1106] https://files.slack.com/files-pri/T03QR2B2T-FAXBYV6PL/screenshot_2018-05-28_11.38.20.png?pub_secret=518a79233e&name=Screenshot 2018-05-28 11.38.20.png
jackjamieson joined the channel
#
[miklb] did you log out of both your WP site & Quill and reauthorize everything? Also aaronpk did some changes with the JS on Quill and you might need to do a hard refresh.
#
[jgmac1106] okay, one sec
dougbeal|imac joined the channel
#
dougbeal Were any of the problems traced back to Jetpack?
#
[miklb] I do not use Jetpack so not sure if that’s been tested against
#
[jgmac1106] I don't JetPack
#
[jgmac1106] Now Quill isn;t recognizing my authorization endpoints
#
[jgmac1106] OmniBear did
#
[miklb] do you have debug logging on? Can you check what the micropub logs say?
[snarfed] joined the channel
#
[miklb] here’s a handy plugin my buddy norcross built to make it easier to view your logs
#
[miklb] https://github.com/norcross/debug-quick-look
#
[jgmac1106] wait different in FF than Chrome
#
Loqi [norcross] debug-quick-look: Adds a link to view or purge the debug.log file in WordPress
#
[jgmac1106] ohh cool
#
[jgmac1106] where do I find this: The WP_DEBUG_LOG constant must be set to true.
#
[miklb] wp-config.php
#
[jgmac1106] So I can log into Quill on FF (not chrome) and it does not throw error anymore but nothing postd
#
[jgmac1106] posts*
tantek joined the channel
#
[jgmac1106] got a strabge one: <br /> <b>Deprecated</b>: Methods with the same name as their class will not be constructors in a future version of PHP; html_javascript_adder_widget has a deprecated constructor in <b>/home/jgregory/public_html/wp-content/plugins/html-javascript-adder/html-javascript-adder.php</b>maybe I figured out what plug in I need to remove
#
[jgmac1106] except I deleted that plug in some time ago...hmmmmm
#
[jgmac1106] Same thing on OmniBear: he called constructor method for WP_Widget in html_javascript_adder_widget is deprecated since version 4.3.0! Use __construct() instead. in /home/jgregory/public_html/wp-includes/functions.php on line 3903
#
[miklb] deprecation notices are one thing, you want to be on the eye out for warnings and fatal errors
#
[jgmac1106] yeah but not I get that everywhere and can't log in
#
[jgmac1106] going to delete the plug in you had me instaall
[pfefferle] joined the channel
#
[pfefferle] Then deactivate the plugin
#
[jgmac1106] Trying just need to do delete in manually as I can't log in to deactivate and delete
#
[pfefferle] Oh
#
[pfefferle] Deadlock 😔
#
[miklb] ?
tantek joined the channel
#
[miklb] logging debug shouldn’t lock you out of your site
#
[jgmac1106] no not sure what it is but debug still saying I didn't set logs but I did do this: define('WP_DEBUG', true);
#
dougbeal Need to verify I have the right combination of plugins activated, but when I try to post from Quill in FF I get - PHP Fatal error: Using $this when not in object context in /home/dougbeal/dougbeal.com/wp-content/plugins/wordpress-indieweb-hook-branch/includes/class-indieauth-authenticate.php on line 42
#
[miklb] I’m going to suggest comment on the PR with the issues we’re seeing for indieauth
#
dougbeal indieauth PR?
#
[miklb] https://github.com/indieweb/wordpress-indieauth/pull/59
#
Loqi [dshanske] #59 Refactor in Search of Fixes
#
[miklb] if you are testing that branch with master of micropub
#
[jgmac1106] no matter what plug ins i deactivate, indieauth, micropub, I am stuck with the error, will roll back to a backup, thx for trying. Sorry I couldn't be more help
#
[jgmac1106] I need to learn more about debugging
#
[miklb] just remove that line from your wp-config
#
[jgmac1106] okay thx
#
[jgmac1106] that did it, thx
#
[jgmac1106] luckily micropub and indieauth are nice haves, not requirements
#
[jgmac1106] for me'
#
[miklb] I would say, Indieweb stuff aside, if you’re WP site breaks by turning on debug, you’ve got a few problems you may want to address.
#
[miklb] *your
jeremycherfas joined the channel
#
[jgmac1106] Yeah, maybe I just need to export all my posts and start with a fresh install, I hate my file structure
#
GWG I feel like I am missing something with these issues
#
GWG I will try to figure out the this issue, that is probably my mistake
#
GWG Maybe I should take a break
#
[jgmac1106] @gwg I figured out what plug in caused the debugger issue and deleted it. the error went away. Take a break you worked like crazy all weekend
#
GWG I am breaking
#
GWG But people keep finding things for me to fix
#
GWG I have a bunch of things
#
GWG I want to demo something at IWS
#
dougbeal GWG: I'm can work on it today if you want?
#
GWG Work on what?
#
dougbeal GWG These bugs?
#
GWG There are issues in many of my plugins
#
GWG An unknown privacy issue in Simple Location
#
GWG People having trouble still with IndieAuth
#
GWG Micropub scope
#
GWG Overreaching default avatars
#
dougbeal Are the indieauth/micropub scope releated?
#
GWG Not sure
#
GWG Scope is new
#
GWG I added it as the plugin wasn't respecting it precisely
#
dougbeal What is scope
#
Loqi In OAuth terminology, scope is a way to limit what parts of your account are accessible by third-party applications https://indieweb.org/scope
#
dougbeal What is class-indie-authenticate.php:get_indieauth_scopes trying to do? Because I'm getting log messages that you can't use $this in a static function
#
Loqi It looks like we don't have a page for "class-indie-authenticate.php:get_indieauth_scopes trying to do" yet. Would you like to create it? (Or just say "class-indie-authenticate.php:get_indieauth_scopes trying to do is ____", a sentence describing the term)
#
dougbeal No thanks Loqi ;)
#
GWG dougbeal, I can fix that
jeremycherfas joined the channel
#
GWG It's an issue with the term static
#
dougbeal Does wordpress have different log levels for more detail?
#
GWG Not exactly
#
GWG I know how to fix it
#
dougbeal I wonder if the HTTP_AUTHORIZATION workaround broke?
#
GWG I just fixed one
#
GWG Other than that, any issues?
#
dougbeal Something goes wrong with the authentication flow/verification. Nothing shows up in the access log or WP log when using indieauth.com (trying micropub.rocks)
#
dougbeal I have been meaning to move to linode anyway, so maybe I will move my blog there to get more debuging options
#
GWG I use Linode
#
GWG dougbeal, coming to IWS?
#
dougbeal Yep
[miklb] joined the channel
#
[miklb] another vote for linode 👋
#
[miklb] they just upped my storage from 30 -> 50 GB
#
[miklb] not that I”m using that much in first place, but it’s a good value nonetheless
#
dougbeal My other thought is getting a Docker container with a whole ecosystem, great for instrospection of any part (and maybe automated integration testing?)
#
dougbeal Hurm, would WP store indieauth tokens in the database?
#
GWG I store them in user meta
#
GWG dougbeal, worst case, we'll chat there
#
dougbeal GWG: would that be session_tokens? Seeing if Omnibear's token is actually there.
#
dougbeal Oh, no, that looks like a web login
#
GWG Go under user and manage tokens
sebsel and [tantek] joined the channel
#
dougbeal Under Users?
#
GWG Yes
#
dougbeal hurm, not showing up
#
dougbeal let me switch back to the release plugin
#
GWG It does if you are using the local endpoint
#
dougbeal oh, have indieauth set
#
GWG Then no way to check tokens, they are stored on indieauth.com
#
dougbeal Ah, that makes sense.
#
dougbeal If I turn on local indieauth, I get Missing Parameter: redirect_uri. Is the webserver stripping it out?
#
GWG It shouldn't
#
GWG That is odd, because I see one other person with that, but can't reproduce it
#
dougbeal same error with quill
#
dougbeal Oh, [28-May-2018 18:14:49 UTC] REST request: /indieauth/1.0/auth: []
#
dougbeal so wp/php isn't getting the headers
#
dougbeal would that be rest_api_init filter?
[cleverdevil] joined the channel
#
dougbeal Could something else be incorrectly clearing the headers? Or does it use the rest route to determine which are called?
#
GWG dougbeal: If it is saying that...
[jeremycherfas], [tantek], [chrisaldrich] and [keithjgrant] joined the channel
#
[keithjgrant] Omnibear only saves errors in the log when the logging option is turned off in Settings. Would it be more worthwhile to log everything, and make it all available upon enabling the setting?
#
dougbeal I think so, easier debugging is good in my book.