#wordpress 2018-09-09

2018-09-09 UTC
#
GWG This is getting complicated.
#
GWG The Parsing is better integrated than ever. But I had to do some minor hacks to get it to work properly with the existing code, which I will now need to clean up
#
miklb GWG any suggestions on how I can move the syndicate-to function in micropub to fire later in the chain? It seems like it is being sent before the `wp_insert_post with args` does
#
GWG miklb: Interesting thought.
#
GWG I'll have to have a look
#
GWG I was deep in mf2 and jf2
#
GWG I'll take a moment.
#
miklb I confirmed with snarfed that bridgy isn't getting the mf2 when it gets the webmention. So reading through the code and my debug log, that is what I've come up with
#
GWG May I make an observation?
#
miklb sure
#
GWG To my recollection, I never fixed Bridgy Publish to use the new hook because I planned on deprecating it
#
miklb interesting. I was curious about that but since it does send the webmention, just not with the post fully rendered I stopped
#
miklb what hook should it use?
#
miklb `micropub_syndication` instead of `micropub_syndicate_to` ?
#
GWG One is a filter, the other a hook
#
GWG That's one of the reasons I added the hook. To trigger the syndication rather than what I was doing.
#
miklb so this `add_action( 'micropub_syndication', array( $this, 'syndicate_to' ), 10, 2 );` instead ?
#
miklb no, I wouldn't have priorities there, right?
#
GWG Wait, let me relook at the code.
#
GWG That would work. However, the signature of syndicate_to is different.
#
miklb Ok. I'll reading the part of readme.txt for micropub_syndication` now
#
GWG It should be easy to convert.
#
GWG The new Syndication Links I stopped work on would have had a similar hook for triggering for the classic editor
#
miklb wait, I don't want to replace the filter I just need to add the action
#
miklb "Called to generate the list of `syndicate-to` targets to return in response to a query" that is different than the action, yes?
#
GWG Yes.
#
GWG You can't double-send a tweet
#
miklb no idea what that has to do with what I'm looking at
#
miklb so there is no example in the wild of using that action is that correct?
#
GWG No.
#
GWG Not yet implemented
#
GWG I will get to it.
#
GWG Too much to do, too little time
#
miklb I'll figure it out
#
miklb what is confusing is the webmention gets sent just too early. Adding the action didn't alter that
#
miklb assuming I was passing the correct thing to it. At least it didn't error
#
miklb also starting to feel like I'm only person using micropub/post-kinds/bridgy
#
GWG miklb: I built it, but I've moved away from POSSE of late
#
GWG The fac tthings are coming together may encourage me more.
[tantek], [kevinmarks], tantek__ and [keithjgrant] joined the channel
#
[keithjgrant] Is the new omnibear working for anyone on WordPress?
#
GWG I only tested with stable and got it working
#
miklb we should probably remove the bridgy plugin then from the recommended IW plugins
#
Loqi yea!
#
miklb I understand scratching itches but rewriting a plugin and leaving it as "works for me" and moving onto something else seems counterproductive. Which is how I feel this whole micropub situation stands
#
miklb unless you want to back burner micorpub 2.0 and which case I'll switch to 1.4.3 and work out my kinks there
#
GWG miklb I am not back burnering Micropub. I am still trying to figure out how to isolate the problems. Some people have them and some don't.
#
GWG It is an auth problem, but where?
#
GWG I am waiting for more data, that's why I haven't pushed it out.
#
[keithjgrant] @GWG 🎉
#
GWG The next question is how to add better error output
#
GWG I wish I knew what the problem was to be honest.
#
miklb ok, so there are some isolated auth issues that we havent' tracked down, but the IndieWeb WordPress community has a plugin that recommends a suite of plugins. A user installing that and the suite of plugins is going to expect interoperability. Getting those plugins ready too is as important IMO. I get that you and pferrele don't use all of the plugins, but they still should be tested and updated. That's what I'm doing,
#
miklb but you don't seem as interested in those issues.
#
GWG The new version integrates better into WordPress, but that doesn't mean anything if I doesn't work
#
GWG miklb, you mean the Bridgy issue or the markup issues?
#
miklb bridgy and post-kinds are two
#
miklb what more data do you need?
#
miklb I mean, what additional data would help?
#
miklb I haven't been able to auth with Omnibear with any version of micropub/indieauth so for me it's an outlier, but seeing almost identical error coming from chrisaldrich and OYS does concern me
#
miklb but I wonder considering how micropub issues were still sporadic with the 1.x version if releasing 2.0 would get more data for those fringe issues and also help by having the media endpoint out there. I know aaronpk has been anxious for the new version for a while.
#
miklb but I wouldn't want to release 2.0 until it was interoperable with the recommended plugins, what ever that list is.
#
GWG Well, for Post Kinds, I would release a filter change concurrent with the Micropub push or before
[eddie] joined the channel
#
miklb we are asking peolpe to test 2.0, it would be nice to also provide beta versions of any plugins that interact with micropub to be functional. Telling folks they need to checkout my fork or a PR is a barrier.
#
miklb I mean, I'm cool breaking my site testing. I'm not normal though
#
miklb but truth is, right now, for what I have working, all of my IW plugins are installed from github repo with multiple remotes and hotfix branches.
#
miklb and again, I'm all about scratching itches. That's ultimately what I'm doing. I want to be able to reply to a note in Indigenous and it syndicate back to Twitter. That's broken, and what I'm trying to get working on my site.
#
GWG Good point. Since I merged some new code into Master in Post Kinds, let me finish some fixes, merge what I am working on, do a release with that and the filter change that will work with both versions and release a new intermediate version.
#
GWG I had that itch and the Twitter part got less itchy.
#
miklb which is cool. If you said you weren't going to update the bridgy plugin and was removing it from the IW plugin, I'd totally understand and would work on a new plugin.
#
GWG I am only doing bugfixes till I remove it
#
miklb would you consider not working with 2.0 beta of micropub a bugfix?
#
miklb truth is, when I can reply via micropub to a tweet I'll actually use Twitter less. There are just some folks that I have on a private list that I've turned into a feed that is already hooked up to microsub. I'd like to be able to still interact with them as they aren't leaving Twitter.
#
miklb and our we sure the problem is in bridgy and not in micropub firing the syndicate-to too early?
#
miklb bridgy plugin, not service
#
GWG No, but I am willing to look. I have a test account
#
miklb thanks
#
GWG I don't think I ever tested replying though, to be honest
[chrisaldrich] joined the channel
#
[chrisaldrich] [keithjgrant] I've just tested the newest version of Omnibear with micropub's stable v1.4.3 and it works (though I'll also say I'm using the master branch of IndieAuth from github, which may possibly be a factor for some testing things).
#
GWG I didn't think of it at the time.
#
[chrisaldrich] [keithjgrant]++ for some nice UI changes and authentication workflow in the new Omnibear version!
#
Loqi [keithjgrant] has 1 karma in this channel over the last year (22 in all channels)
#
GWG Hello, chrisaldrich
#
[chrisaldrich] good morning GWG!
#
[chrisaldrich] [keithjgrant] one UI piece that is quirky for me is the space separated tags, as in WordPress I have several tags/categories that use multiple words (and thus have spaces). Comma separated tags would thus be more useful.
[keithjgrant] joined the channel
#
[keithjgrant] Good to know. I've considered making that input a little more intelligent than a simple text input
#
[chrisaldrich] I also love the fact that there's a bookmark now!
#
GWG I am working on making bookmark better
#
miklb the parsing?
[eddie] and jeremych_ joined the channel
#
GWG miklb, the parsing is just part of it
#
GWG The real bug I was fixing was that I wasn't using mf2 or jf2 strictly so it wasn't consistent with Micropub and the agreed standard
#
GWG Contributing to all those php notices.
#
GWG I still need to remove all sorts of extraneous pieces.
#
GWG Also, jackjamieson is using the code for his Yarns project. So two birds one stone
#
GWG Enhanced post type discovery
#
GWG Should reduce the cases of Micropub reporting the wrong post kind
#
GWG It also fixes a bug filed about storage by pfefferle when he was trying to do mf2 feed.
#
miklb understood
#
GWG As well as the comments made about issues with Micropub posting bookmarks
#
GWG But I will release a version before getting to any of the post kind additions I had planned in order to have a version that includes the filter change.
#
GWG There may be one breaking view template issue
#
miklb lol
#
GWG Specifically, the figuring out what is the correct property based on Kind
#
miklb back to whack-a-mole
#
GWG I am trying to move where that happens
#
GWG Out of the mf2 post class because it isn't part of the post object.
#
GWG I am trying to build in post type discovery to address it.
#
GWG Worst case, the fetch function moves to Kind View so it isn't inside the mf2 post class
#
GWG I don't want kinds to be a dependency of mf2 post because I am trying to make it part of the Parse This piece I want to be able to separate and include someday in other projects.
#
GWG As the most extensive user of Post Kind templates I know, I would want to ensure yours was working.
#
GWG Beyond that, this version sees the retirement as announced of the Kind Meta class
#
miklb I am using the default templates currently save for adding a reply kind and changing to using `u-url`
#
miklb those are in my fork of the plugin right now.
#
miklb I'm still testing out 2016 and the fork of uf2 plugin.
#
GWG I will be fixing the default templates. Enhancing in next version
#
miklb but that gets to my point GWG. We need a stable base line before introducing new features which invariably lead to new issues. All the parsing improvements in the world don't help if we do discover the the syndicate-to is firing too soon and not sending the data.
#
GWG That's why I am stopping what I am doing in enhancements to work on compatibility
#
miklb all of the plugins are tied together. So everything being in alpha/beta all the time we never even are sure what version anyone is running when reporting issues
#
GWG I need to get data storage fixed l, which is why I am still finishing the parsing work
#
GWG Before anyone creates any new data
#
miklb ok
#
GWG I don't intend to add any new parsing features beyond what I have already written yet.
#
GWG miklb, I have an idea. If I write up a temporary branch, would you be able to test it?
#
GWG To gather Data on the forbidden issue for Micropubm
#
GWG ?
#
miklb yep. I have everything installed from GitHub
#
miklb it would be easier if it was a branch of the IW repo, but I can add another remote if I need to
#
GWG I should be able to.
#
GWG miklb: Preparing to merge what I have and then do testing and bug checks toward a 3.1.0 release of Post Kinds
#
GWG That should finish this work for a bit
[keithjgrant] and testt joined the channel
#
GWG miklb: What did you do when you were testing functionality? what testing scenarios with Post Kinds?
#
miklb I'm not specifically testing anything. I just post until something isn't right. At this point, it was just down to the micropub reply.
#
miklb I see you just merged that work into master so I'll switch over to it on my site.
#
miklb but I suspect the micropub reply issue would affect anything that gets heavily modified with the parsing.
[Niklas] joined the channel
#
miklb and you try to syndicate it via bridgy
#
miklb just tested on a GitHub repo, very nice!
#
GWG It isn't just the parsing. It is the storage.
#
GWG That means the Micropub query stuff will work right
#
GWG So, I found one template bug so far.
#
GWG Looking for more
#
miklb which one?
#
miklb `Undefined variable: kind`
#
GWG $kind variable in the kind.php template
#
GWG Yes
#
GWG already fixed
#
GWG It is loaded later. I mixed up the load order
#
GWG I'm going to check for anything else
#
GWG Also, posted with the new Omnibear
#
GWG Though bookmark isn't working for me, oddly
#
GWG But, trying a variety of different techniques to look for errors.
#
GWG I think may need better automated testing
#
GWG I only have a small amount
#
miklb in the kind template, need to switch the `p-` with `u-`
#
miklb oh, looks like modified that function https://github.com/dshanske/indieweb-post-kinds/blob/master/views/kind.php#L34
#
GWG I see the mistake I made
#
GWG Thanks. Adding to the 3.1.0fixes branch
#
miklb let me know when you push that branch so I can switch to it please.
#
GWG I'll be pushing pretty quickly
#
GWG Pushed.
#
GWG Merging the two fixes
#
GWG Will continue bug hunting
#
miklb same. testing a micorpub reply right now
#
miklb same result
#
GWG Which result? p instead of u?
#
GWG Just merged
#
GWG It says u-in-reply-to now
#
GWG And I posted using Omnibear
#
boffosocko.com edited /Getting_Started_on_WordPress (+171) "see also: WP Glossary site" (view diff)
#
miklb no, fail to syndicate correctly.
#
GWG Okay.
#
GWG Haven't gotten to that problem yet
#
GWG That was next.
#
GWG This was fixing Post Kinds to be ready to push a stable version.
#
miklb sure, just wanted to confirm that it wasn't on the parsing side somehow.
#
miklb fwiw I still have the 403 issue with Omnibear retrieving syndicate-to links
#
GWG That is still the auth problem
#
GWG I am going to do that branch soon for testing
#
miklb ok, just mentioned it as you noted posting from Omnibear