#wordpress 2023-04-09

2023-04-09 UTC
RasAlGhoul, bob1, RasAlGhoul_, Retro, antranigv, fef and [pfefferle] joined the channel
#
[pfefferle]
the webmention plugin shows the wrong URL for brid.gy for example
#
GWG
[pfefferle]: ?
fef joined the channel
#
[pfefferle]
We show the brid.gy url instead of the twitter url
#
[pfefferle]
For example
#
GWG
I saw that...but I lacked context for you mentioning it now.
#
GWG
But I know we have things to fix
#
[pfefferle]
I hope he have not messed up the migration
#
[pfefferle]
the brid.gy url should never be used as author url
#
[pfefferle]
and I get an 500 error if I try to use the internal parser 😞 `/webmention/1.0/parse/`
#
GWG
Add it to the list?
#
GWG
I intend to work on some of these
#
[pfefferle]
and the mf parser seems broken for your site 😳
#
GWG
Can you document in an issue?
#
GWG
I'm looking, and some of the bridgy webmentions on my site didn't migrate to other types.
#
GWG
Also, since the links are down, I can't try reparsing. May have to put in something to allow people to fix.
#
GWG
I fixed it.
#
GWG
I actually pushed that into the repo, but forgot to release a new version.
#
GWG
It was a S instead of s somewhere
#
[pfefferle]
ok, fixed the tools page
#
GWG
The issue was what?
IWDiscord, Gremblo[d], Silicon[d], steinaech[d], Tuck[d], shaunix[d], marksuth[d], Hazel_[d], Bainstor[d], singlequbit[d], Grayson[d], indieweb-irc-bri, FoondyChop[d], DJ_[dj_je][d], IndieWebCamp_IRC, who[d], Nezteb[d], fernandolguevara, hollie[d] and aaronpk[d] joined the channel
#
[pfefferle]
why have we deleted `semantic_linkbacks_author_url`???
#
[pfefferle]
now we have A LOT of broken URLs because of abandoned brid.gy URLs
#
[snarfed]
I can look into serving them from storage instead of the API
#
[pfefferle]
that would help us re-parse some of the urls
#
[pfefferle]
but I will also have a look, to use the permalink of the tweet in the meantime
#
[snarfed]
Did you not always store the parsed mf2?
#
[pfefferle]
I hope we kept that at least
#
[pfefferle]
we do not store it, because it would mess up the db with a lot of unused data
#
GWG
[pfefferle]: We were supposed to move the author url into the Author url field
#
GWG
[snarfed]: Can you keep them up from storage for a bit at least?
#
[pfefferle]
but we haven't, because it is not how the old code worked
#
[pfefferle]
we use the author URL to check if it is an update or an insert
#
[pfefferle]
I will re-think the db design and make a doc, to not do this again!
#
GWG
[pfefferle]: Document it and we'll figure out a solution
#
[snarfed]
disk is cheap, databases are good at storing lots of data, in general I lean toward storing data in case I need it in the future
#
[snarfed]
I'll look at serving Bridgy Twitter URLs from storage now
#
[pfefferle]
we also messed up the update process I think
#
[pfefferle]
I can not find a point where we check if a new webmention is an update or not 😳
#
[pfefferle]
but is the check correct?
#
[pfefferle]
comment_author_url ???
#
GWG
No, Webmention source url
#
GWG
It uses author url as a fallback only
#
[pfefferle]
it is very misleading
#
[pfefferle]
it includes the source at this point, but it we should use `$commentdata['comment_meta']['webmention_source_url']` or `$commentdata['source']` instead
#
GWG
I agree.
#
GWG
I think I should push off [chrisbergr]'s PR until we work on some of the other issues, then come back to it. I've been looking at that problem,. but better to work on fixes for people's issues before enhancements
#
GWG
[chrisbergr]: I want to get a version into the next major release, but I think this takes precedence
RasAlGhoul_ joined the channel
#
[snarfed]
ok [pfefferle] GWG, Bridgy Twitter URLs are now serving from storage
#
[snarfed]
(only from the last 18 months or so, since I don't keep them in storage forever)
#
[pfefferle]
[snarfed]++
#
Loqi
[snarfed] has 3 karma in this channel over the last year (135 in all channels)
#
GWG
[pfefferle]: Now the work begins
#
GWG
[pfefferle]: Suggest we look for things that aren't needed anymore and for places we can add comments for future versions of ourselves
#
GWG
[snarfed]: And I thought it would be smooth sailing post 5.0
#
[snarfed]
hah, no way, there are always bugs and issues to fix with a change this big
#
[snarfed]
and they often show up slowly after a while, not just immediately
#
[snarfed]
GWG++ pfefferle++ again, thank you for landing the merge and fixing these issues!
#
Loqi
GWG has 17 karma in this channel over the last year (60 in all channels)
#
GWG
I thought it would be about adding in features like avatar caching and finer control of the templates... maybe parsing reviews...
#
GWG
I didn't think there would be no bugs, but...
#
[snarfed]
the bigger the change, the bigger the bugs and issues
#
[snarfed]
always 😁
#
GWG
[snarfed]: Do the stored Twitter Bridgy pages have non broken avatar URLs in them?
#
GWG
I am still wondering if I could add in the code to store them before they vanish.
#
GWG
I know [pfefferle] wants to use avatar privacy, but it doesn't store Webmention avatars, only gravatars.
#
GWG
I think the Author of that plugin is willing to work with us though
#
GWG
We just have a solution ready to go now.
#
[snarfed]
GWG Bridgy Twitter's avatar URLs are Twitter's own URLs. Bridgy doesn't store or re-serve images
#
[snarfed]
so yes they generally work, but not all, eg I think if someone changed their profile picture, URLs to their old profile pictures may not work
#
GWG
[snarfed]: I know.. just wondering how many are broken
#
[snarfed]
no way to know
#
[snarfed]
and yes! I've been talking with that plugin's author about backfilling avatar images, https://github.com/mundschenk-at/avatar-privacy/issues/269
#
[snarfed]
ah that issue is probably what you're thinking about
#
GWG
Yes.
#
Loqi
[preview] [snarfed] #269 Backfill avatars on old comments
#
GWG
[snarfed]: Maybe I should do a new PR that Avatar Privacy could trigger or I could use the local code we wrote for same..
#
GWG
But the trigger for refreshing old avatars can be on the Webmention sode
#
GWG
side
#
[snarfed]
I'd recommend putting it in a WP-CLI command or standalone script. for big sites, doing it in background cron seems like a recipe for pain
#
[snarfed]
eg I have ~15k comments on my site, and it's probably only small to medium, I expect other people have way more
#
GWG
[snarfed]: We support multiple ways for migration now
#
[snarfed]
you all are the pros 🤷
#
GWG
No, we just had time to discuss and rediscuss
#
GWG
But that's why I have moved to advocating for simple structures easy to hang different methodologies on
#
GWG
So we can build a nice default and let others enhance it if they want
#
GWG
So... opinions with ways to make options
#
GWG
Although some things have to be as settings
#
capjamesg
GWG++ for the WP webmention 5.0 release!
#
Loqi
GWG has 18 karma in this channel over the last year (61 in all channels)
#
capjamesg
[pfefferle]++
#
Loqi
[pfefferle] has 16 karma in this channel over the last year (30 in all channels)
RasAlGhoul and RasAlGhoul_ joined the channel
#
[chrisbergr]
Is avatar caching really a feature that belongs in the webmention plugin instead of its own?
#
[snarfed]
discussed here on Fri, [pfefferle] agrees, the Avatar Privacy plugin seems like a good existing one, not sure if it fully works yet with webmention avatars though?
#
GWG
I'm happy to go my own way if majority feels differently. Thus the statement about making it flexible
#
[pfefferle]
It works with webmentions for me
#
GWG
[pfefferle]: How?
#
[pfefferle]
Avatar privacy
#
GWG
I tried turning it in and all my avatars vanished
#
[pfefferle]
Recently?
#
GWG
Yesterday
#
[pfefferle]
You can see it running on notiz.blog
#
GWG
The developer admitted it doesn't store Webmention avatars as recently as today. https://github.com/mundschenk-at/avatar-privacy/issues/269
#
GWG
At least, it doesn't work retroactively
#
GWG
If you didn't have it on...
#
GWG
Where on your site is it storing a Webmention avatar as opposed to a gravatar?
#
[snarfed]
specifically, If I understand him right, he said it works with existing webmention avatars, just on demand. it doesn't proactively go fetch and store them as soon as you install it
#
[pfefferle]
Ah, now I get it... no, you can't restore images if you haven't used it before
#
GWG
It is hard to tell what is a Webmention on notiz.blog. Can you show me one that is being stored?
#
[pfefferle]
every facepile
#
Loqi
[preview] Vor zwei Jahren wollte Twitter in das „Dezentrale Netzwerke“-Business einsteigen und gründete eigens dafür das Projekt Bluesky. In den folgenden zwei Jahren wurde viel evaluiert und diskutiert, was wohl die beste Lösung für Twitter sei und wi...
#
GWG
That's what I was looking for
#
[pfefferle]
every facepile on my site is a webmention
#
[pfefferle]
and in the comments there are also activitypubs
#
[pfefferle]
(a second raison why I would love to use a separate plugin instead of a webmention one)
#
GWG
[pfefferle]: I am looking at the code
#
[pfefferle]
blackbox!
#
[pfefferle]
it works 😉
#
[snarfed]
[pfefferle]++
#
Loqi
[pfefferle] has 17 karma in this channel over the last year (31 in all channels)
#
GWG
[pfefferle]: If we want to trigger it retroactively... I have to figure out how it works
#
[pfefferle]
you still want to build your own solution?
#
GWG
[pfefferle]: I would at least have to address retroactive. I'm looking for how to do that.
#
GWG
So many files
#
[snarfed]
GWG on that issue, the Avatar Privacy author said to just use an existing cache warming plugin, or write a script to do it by fetching all posts
#
[snarfed]
seems fine
#
GWG
I still want to know how it saves it
#
GWG
A cache warming plugin would reload every post to address the issue, which I suppose is fine
#
GWG
[snarfed]: I turned it on.. it doesn't like you. https://david.shanske.com/2022/10/26/5665/
#
Loqi
[preview] [David Shanske] Why don’t people wear hats outdoors anymore in large numbers? In the past, it was considered inappropriate to go bareheaded in some contexts.
#
GWG
Or specifically, Webmentions with gravatars
#
[snarfed]
Oh the avatar privacy plugin? 🤷‍♂️ I haven't actually tried it
#
Loqi
[preview] [dshanske] #270 Does Not Cache Gravatars received via Webmention
#
GWG
That's why when I tried it...the last Webmention avatars disappeared...they used Gravatar
#
GWG
I also need to see the cache time
#
[snarfed]
I don't follow though. my h-card profile picture (which is therefore the one in the webmention on your site) isn't a gravatar
#
GWG
Hmm...it only stores it for a day or t6
#
[snarfed]
That's configurable
#
GWG
Yes it is, I just checked
#
GWG
[snarfed]: But we have an issue with avatar images no longer being available... which I suppose is fine because it would now replace it with a mystery image... better than a blank space, I suppose
#
GWG
I'm just thinking how s bunch of silhouettes will look
#
[snarfed]
Right. They're unavailable *_now_.* This might change them, but it wouldn't make them worse
#
GWG
This is why I'm tempted to run a parallel solution that stores them forever.
#
[snarfed]
And individual sites would opt into avatar privacy themselves. you all wouldn't be imposing this on anyone, you'd just help make it compatible
#
[snarfed]
But this _is_ that solution
#
[snarfed]
Eh, this us the same conversation you had with [pfefferle] earlier
#
GWG
[snarfed]: I don't see an option to turn off the cache invalidation.
#
GWG
I intend to work with the developer, but I still might not choose it for myself
#
[snarfed]
Cache invalidation?
#
[snarfed]
There are so many other webmention plugin bugs and improvements to be done, I don't see why you'd prioritize reinventing the wheel here, but up to you all
#
GWG
[snarfed]: I'm not prioritizing it, we already wrote it.. I'd just take the PR and put it into a separate file.
#
GWG
And remove the Gravatar caching code from the plugin entirely
[tantek] joined the channel
#
[snarfed]
The initial implementation is only the first 20% of the work; the next 80% is maintaining it 😎
#
GWG
It just means we'd remove the Gravatar and the local mystery silhouette from the code and let avatar privacy or something handle it
#
GWG
I know... my intention is to remove the Gravatar code for now
#
[snarfed]
Up to you all!
#
GWG
For now, as you said, lots to do
#
GWG
Like filing my taxes