#dev 2023-11-11

2023-11-11 UTC
[KevinMarks] joined the channel
#
[jacky] Maybe logging in from a unexpected location?
#
[jacky] I'm considering keeping track of user agents for token verification attempts
#
[jacky] And things like that to at least pipe to some service that could do detection
#
GWG I'm just going to build something extensible...
#
[jacky] Ha, I have to show you what I have planned for Sele lol
#
[jacky] I just want to simplify hosting a bit
geoffo, Xe, corlaez and [jeremycherfas] joined the channel
#
[jeremycherfas] Tell [Zegnat] thanks for the PR. I will check as soon as Saturday chores have been done.
#
Loqi [jeremycherfas]: Zegnat left you a message 9 hours, 56 minutes ago: What I would propose as a fix is to wrap the contents of that <script> in a function. Then change all the variable names to not include the object ID at all. They only do that so they will not conflict incase multiple checkins have to be rendered on the same page. Happy to explain if you are interested!
#
Loqi [jeremycherfas]: Zegnat left you a message 9 hours, 31 minutes ago: actually, that whole thing was like a minute worth of work, so I just used the on-GitHub code-editor to file a PR. Let me know if it fixes it. Happy to explain the code change more if you want for learning! https://github.com/idno/known/pull/3162
ludovicchabant and jeremycherfas joined the channel
#
[jeremycherfas] [Zegnat] It works perfectly. Thank you (and [sknebel]) very much. I hope [benatwork] reviews and merges i soon so others can benefit. Next, pursue a different map tile provider.
#
[jeremycherfas] Makes me think, the work [sebsel] put in at IWC Nuremberg might have worked and the reason we did not see results was that this error was preventing it, while I thought it was the tile provider that was the underlying problem.
sebbu2 joined the channel
#
Zegnat That could very well be the case. I haven’t given the tile provider settings any look yet.
#
Zegnat This PR was just a low hanging fruit after you all already identified the error cause :)
#
[jeremycherfas] Low hanging for a programming giant like you; out of reach for me. I am happy to stand on the shoulders of giants.
neceve, jonnybarnes, sebbu, geoffo, barnaby and [Paul_Robert_Ll] joined the channel
#
[Paul_Robert_Ll] Seeking some clarification. My understanding of the `type` value in JF2 is that it takes the vocabulary name from microformats2, but minus the `h-*` prefix. So in mf2 you would have `type: ["h-card"]` but in JF2 you would have `type: "card"`. Is that correct?
#
GWG Yes, to my understanding
#
Zegnat !tell [jeremycherfas] not sure where you and sebsel left off re Known Stamen maps. But from a look, I wonder what would happen if you were to update /IdnoPlugins/Checkin/external/stamen-maps/tile.stamen.js with the one that was updated this summer in the original repo https://github.com/stamen/maps.stamen.com/blob/master/js/tile.stamen.js (this now points at Stadia)
#
Loqi Ok, I'll tell them that when I see them next
#
Zegnat Also, hey, looks like benwerd has already merged the PR! :D
geoffo joined the channel
#
[jeremycherfas] That was my plan as a first next step, because iirc there is a min.JS too. Ought to be able to use it with minimal changes by referring back to the Known version. Maybe tomorrow …
#
[jeremycherfas] @benwerd++
#
Loqi @benwerd has 1 karma in this channel over the last year (5 in all channels)
neceve, bret, GWG, pharalia and petermolnar joined the channel; petermolnar left the channel