snarfedlooks like a recent mf2py change started doing that when there are inner tags, eg <div class="p-name">foo <span>bar</span></div> parses to name: ['foobar']
sknebelI'd guess with the whitespace changes the mf2-testsuite wasn't run (since it'll conflict with that all the time) and the tests outside it don't cover that?
aaronpkI realize this is something that's just assumed to have been done correctly, but I'm surprised that literally none of the tests happened to have that case in them
gRegorLovesnarfed, php-mf2 uses microformats/tests as a secondary test suite, still has local tests. Agreed, I think there should always be a lib-based test suite.
sknebelnever said there shouldn't be one, just wondering if we can't cover basics better if we collect them collectively instead of each lib on their own breaking something and adding a test for it
sknebelI think Zegnat implemented his algorithm "correctly" 2 times, but his writeup of it doesn't match, so if the writeup was followed trusting it'd do the same as the 2 implementations. gotta check that precisely though, since regex
KartikPrabhu3 criteria 1) don't break existing tests 2) don't use values that are all spacesi.e. <span>\t\n </span> should not count right? 3) fix this issue by snarfed ;)
Loqisknebel has 17 karma in this channel (114 overall)
tantek__, snarfed, [chrisaldrich], chrisaldrich, [ryan339], [cleverdevil], [matpacker], [Chris_Lott] and tantek joined the channel; snarfed left the channel
Loqi[tantek__] aaronpk, re: X-Forwarded-For and the whole mnot RFC about disliking x-, all the examples that drove that conclusion were x- that hung around "too long", or rather, with too slow a process for actually assessing x- experiments and then either rejectin...
jmac, bradenslen and KartikPrabhu joined the channel