#microformats 2020-04-25

2020-04-25 UTC
[tantek] joined the channel
#
gRegorLove Updated php-mf2 milestones: https://github.com/microformats/php-mf2/milestones
#
gRegorLove 0.5.0 just needs those 4 PRs merged then I think it's ready for release
#
[tantek] woohoo!
#
gRegorLove First 3 have been approved but not merged, last one is bumping PHP to 5.6
#
Loqi 😊
#
gRegorLove (My PRs so would prefer someone else merge :)
[TimApple], Sajesajama__, [tantek], [LewisCowles], Dianalondon, [KevinMarks], mauz555, CandyWendy and joshghent joined the channel
#
GWG !tell gRegorLove I tried a different take on PHP5.6
#
Loqi Ok, I'll tell them that when I see them next
#
Zegnat !tell gRegorLove any thoughts on merging the test-suite PR and rebasing the 0.5.0 milestones PRs on that first? Might make it easier to review those backcompat fixes?
#
Loqi Ok, I'll tell them that when I see them next
#
GWG Why is phpdocumenter a dev dependency of PHP-MF2? We don't seem to generate documentation
[TimApple] joined the channel
#
Zegnat Hmm, I don’t actually know. Something neccesary for PHPUnit?
#
GWG Nope
#
GWG I checked
#
GWG Maybe we should generate documentation
#
Zegnat GWG: https://github.com/microformats/php-mf2/commit/1de78fcca9fc793aac6b9579ecb7caecad7b3dc3 - apparently a dependency problem with PHPUnit
#
Zegnat Without it, PHPUnit grabs a newer version of phpdocumentor and the build will start failing
#
GWG Interesting
#
Zegnat Though we could take it away if we bump PHP support
#
GWG Just put in a PR to bump the support, as did gRegorLove
#
Zegnat So in your PR for PHP 5.6, you could probably drop it!
#
GWG However, I am wondering if we shouldn't consider generating the documentation
#
Zegnat Hmm, maybe? But I would split that to a separate PR then, don’t do too much in a PR that is supposed to be about deprecating a PHP version
#
Zegnat GWG do we really need PHP_CS to do the compatibility check? Hadn’t seen that before.
#
GWG Zegnat: Why not?
#
GWG I would split it
#
Zegnat I just didn’t think PHP_CS would be neccessary, isn’t there a stand-alone compatibility checker, is my question
#
GWG Zegnat: Something should be checking, so I added a compatibility checker.
#
Zegnat I love the automated checking, just surprised to see 3 dependencies for it
#
GWG Zegnat: We may wish to add more rules in future. Also, dev dependencies
#
Zegnat I wouldn’t mind getting a code style check in there too, so I do not mind, was just surprising :)
#
Zegnat This is more something that may be worth changing: you do not need to define `./vendor/bin/` within scripts in the composer.json file. Composer will always look in that folder first, so just writing `phpunit` will default to a local installation and not the global one. (See https://getcomposer.org/doc/articles/scripts.md#writing-custom-commands)
#
GWG https://github.com/microformats/php-mf2/issues/188
#
Loqi [gRegorLove] #188 Specify coding standard
#
GWG Zegnat, good to know, either way, I thought adding a script was easier than always remembering
#
Zegnat Adding script is great! `composer test` is always a nice one that we may consider making available. I am a huge fan of not depending on globally installed tooling because you cannot guarantee versions that way.
#
GWG I have been on a testing improvement kick of late.
#
GWG But I am thinking of adding docblock checking to my code to force me not to forget to do it
#
Zegnat Interesting. Yeah, I am bad at docblocks too. I do these days include code style checking on mostly everything
#
GWG For php-mf2 we'd have to pick a standard
#
Zegnat I would like to just go with whatever the most developers are familiar with. Mine is mostly just Symfony default: https://github.com/Zegnat/php-website-starter/blob/develop/.php_cs.dist
[jgmac1106], desmondrivet, globbot, vesper11, MylesBraithwaite, reidab, Sajesajama__, [tantek], Verlf, chrisaldrich, twMat, brunow, doubleloop1, [prtksxna], [chrisaldrich], BillSeitz, BadHotLady, theianjones, gRegorLove, [KevinMarks], [christophe194], [snarfed], gRegorLove_, KartikPrabhu and mauz555 joined the channel