#microformats 2020-04-26

2020-04-26 UTC
#
gRegorLove Not sure what you mean Zegnat
#
Loqi gRegorLove: GWG left you a message 10 hours, 49 minutes ago: I tried a different take on PHP5.6
#
Loqi gRegorLove: Zegnat left you a message 10 hours, 46 minutes ago: any thoughts on merging the test-suite PR and rebasing the 0.5.0 milestones PRs on that first? Might make it easier to review those backcompat fixes?
#
gRegorLove oh, this one? https://github.com/microformats/php-mf2/pull/163
#
Loqi [Zegnat] #163 Run mf2/tests test suite with PHPUnit during default testing
#
gRegorLove Yeah, including that with 0.5 sgtm
#
GWG gRegorLove: Sorry about the issues with my PR.
#
gRegorLove I'm still catching up, which one?
#
GWG gRegorLove: I did an alternate version of the PHP5.6 and ended up in a composer.lock dependency problem
#
gRegorLove What does the config.platform.php 5.6.1 do?
#
gRegorLove Only thing on PR 220 is we might switch order of "Make your changes" and "Add PHPunit tests" to encourage TDD
#
gRegorLove otherwise looks good. haven't used phpcs before but look forward to it
#
gRegorLove hm, looks like that platform will pin all dependencies to 5.6.1 even if running a newer version?
#
GWG gRegorLove: That was where the Travis Tests kept failing. It kept giving dependencies for later versions.
#
GWG The alternative solution is to not ship a composer.lock
#
gRegorLove what change caused travis to start failing?
#
GWG gRegorLove: The updated composer.lock
[chrisaldrich] and gRegorLove joined the channel
#
gRegorLove shouldn't the lock have 5.6 compatible libs?
#
gRegorLove then if someone is on 7 and runs composer update, they'd update as appropriate
#
GWG So, the platform makes sense
[chrisaldrich] joined the channel
#
gRegorLove I'm confused. it doesn't make sense if there's php7-only dependencies in the lock file
#
GWG gRegorLove: Yes, correct
#
gRegorLove correct it doesn't make sense? Haha
[jeremycherfas], mauz555, [LewisCowles], [KevinMarks], [chrisaldrich], [tantek], [jgmac1106], [mapkyca], omz13, jamietanna, vesper11, indier, ClaudiaSamp, GWG, [grantcodes], gRegorLove, KartikPrabhu, manificattion10 and gRegorLove_ joined the channel
#
[KevinMarks] Thoughts on this polymorphism? https://adactio.com/journal/16803
#
Loqi [Jeremy Keith] Reading
gRegorLove_ joined the channel