#wordpress 2017-06-26

2017-06-26 UTC
#
[chrisaldrich] GWG++ for integrating bridgy signup into wordpress!
#
Loqi gwg has 3 karma in this channel (244 overall)
#
GWG [chrisaldrich]: What are the 10?
ricmac joined the channel
#
[chrisaldrich] Most of the list is at home. Lots of updated documentation though... I think I'm going to write an indieweb book for WordPress though....
#
GWG [chrisaldrich]: https://etherpad.indieweb.org/indieweb-wordpress
ricmac, [jeanmacdonald], tantek and tantek_ joined the channel
#
GWG I am trying to figure out what next
[miklb] joined the channel
#
[miklb] I found the filter I need to add a radio buttons to image attachment screen to choose u-featured, u-photo or neither.
#
GWG [miklb], for Microformats 2?
#
[miklb] I was thinking it would be more useful in IndieWeb plugin. If you have a mf2 theme, you wouldn’t have the MF 2 plugin, but the image class would be useful still.
#
GWG I made the Microformats 2 plugin able to coexist
#
[miklb] coexist with?
#
GWG Any theme
#
GWG It doesn't call any functionality if the theme declares microformats 2 support
#
GWG By the way, I was looking at the checkin property
#
[miklb] that’s less a coexists and more a disables it sounds like.
#
[miklb] I don’t think I knew to declare mf2 support in my personal theme.
#
GWG miklb, the idea being a theme could use the classes inside itself
ricmac and [asteres] joined the channel
#
[miklb] I’ll work on it as a standalone plugin for now and I opened an issue to discuss best home for it on the IndieWeb plugin issues. https://github.com/indieweb/wordpress-indieweb/issues/71
#
Loqi [miklb] #71 MF2 image support
ricmac joined the channel
#
[miklb] and by standalone plugin I probably really mean just sticking the code in my theme’s functions file.
#
GWG We were discussing why so many things start as separate plugins
#
GWG The question was why not branches.
#
[miklb] yeah, I have no plan to release it as a standalone, just not sure which plugin to branch off of.
#
GWG Can I ask a quick favor?
#
[miklb] sure
#
GWG Can you look at the dev branch of Simple Location and tell me if the new location meta box is easy to follow? Still playing with it.
#
[miklb] I looked at it earlier today, and noticed it moved and if you click details you get an extended set if fields. Anything new? That seemed logical to me.
#
GWG miklb, no. I think it is better than the pop-up
#
[miklb] Agreed.
#
GWG So, next is check-in
ricmac joined the channel
#
[miklb] what are you thinking there?
#
GWG I want to display the property and then I'll work on the rest.
#
GWG There are a few questions on how I've thought of.
ricmac joined the channel
#
[miklb] can a plugin provide a template for post-kinds? Could simple-location offer an advanced template and keep the one in the plugin generalized?
#
GWG [miklb]: I was thinking of both.
#
GWG Post Kinds will handle URL checkins and Simple Location will handle 'local' check-ins and map display.
tantek joined the channel
#
[miklb] well, it’s been a long day for me, safe travels and good night.
#
GWG Onward to NRT/MNL
ricmac, dougbeal|iOS, tantek and [pfefferle] joined the channel
#
[pfefferle] !tell GWG "We were discussing why so many things start as separate plugins" can you make an example?
#
Loqi Ok, I'll tell them that when I see them next
#
[pfefferle] oh... no loqi?
#
[pfefferle] ah, there he is ?
ricmac, [cleverdevil] and [kevinmarks] joined the channel
#
GWG pfefferle, I explained my opinion. Where else would you start something until it was mature enough?
#
Loqi GWG: [pfefferle] left you a message 44 minutes ago: "We were discussing why so many things start as separate plugins" can you make an example?
[markmhendrickso, ricmac and [pfefferle] joined the channel
#
[pfefferle] GWG are you referencing the discussion I attended remotely?
#
[pfefferle] GWG btw. this was not meant offensive in any way! only curious... and perhaps some misinterpretations because of language...
ricmac joined the channel
#
[pfefferle] GWG perhaps we should document that branch/feature-plugin discussion on the WordPress wiki page
ricmac and [apatters] joined the channel
#
[apatters] Was just testing today and the issue I experienced yesterday with thumbnails getting attached to posts syndicated from my blog to FB is still present.
#
[apatters] Still super new to everything, but thinking about what we discussed yesterday, could it be because the post author info on Independent Publisher's single post template isn't an hCard? Someone suggested a lack of an hCard might be the issue yesterday.
#
[apatters] http://aaroncommand.com/2017/06/25/a-rough-sketch-for-an-indieweb-plugin-ux-update/ <-- no hCard
#
Loqi [apatters] A rough sketch for an Indieweb plugin UX update http://0.gravatar.com/avatar/6f59d6d0e764122279116308b751511f?s=100&d=mm&r=g
#
[apatters] And there's Loqi repro'ing the bug ?
#
[apatters] I can log a Github issue on Independent Publisher for this, but am trying to get some certainty that the issue is actually with IP before I do it
[grantcodes] and [pfefferle] joined the channel
#
[pfefferle] how does the post look like in facebook and what tool do you use to post to facebook... I ask, because facebook does not support microfortmats at all...
#
[pfefferle] ...but you are right with the missing h-card and this may cause problems when sending webmentions, to other indieweb sites...
ricmac and [pfefferle] joined the channel
#
[pfefferle] GWG we should re-think the comment-metas... either we switch the semantic-linkbacks to mf2_* or we use a more generic one like indie_*
#
[pfefferle] GWG using mf2_* and semantic_linkbacks_* is to much overhead I think
#
GWG [pfefferle]: I'd go with mf2 because of the adoption
#
GWG There is a way to have requests for the old properties redirected to the new and vice versa.
[miklb] joined the channel
#
[miklb] Doesn't micropub set mf2_* ?
#
GWG [miklb]: It does. So does Post Kinds, Syndication Links..
[apatters] joined the channel
#
[apatters] pfefferle I'm using Bridgy to syndicate to Facebook. The thumbnail appears directly under the text of the post.
#
[miklb] pfefferle if you have any thoughts on this I'd love your opinion https://github.com/indieweb/wordpress-indieweb/issues/71
#
Loqi [miklb] #71 MF2 image support
#
GWG [apatters]: https://pin13.net/mf2/?url=http%3A%2F%2Faaroncommand.com%2F2017%2F06%2F25%2Fa-rough-sketch-for-an-indieweb-plugin-ux-update%2F
#
GWG Something is definitely marking photo as a top level property there
#
GWG IT should be nested
ricmac joined the channel
#
GWG https://github.com/raamdev/independent-publisher/blob/129a25035db92c73bba830b69a9978872c734919/inc/template-tags.php#L459 - There is the code
#
GWG Excuse me...clicked the wrong line
#
GWG https://github.com/raamdev/independent-publisher/blob/129a25035db92c73bba830b69a9978872c734919/inc/template-tags.php#L497
#
GWG The theme needs its h-cards deduplicated
#
GWG There are three h-cards on the page.
#
GWG Definitely need to see if I can do a PR. None of them wrap around the image, which is the perfect h-card
#
[apatters] Bridgy is picking up more than one h-card for that post, and ends up including one of them in the body of the post when it syndicates to FB? Do I understand that correctly?
#
GWG [apatters]: There is more than one h-card in the page. There should't be.
#
GWG I'll see what I can do about a PR. I was going to send some one of these days anyway for other things.
dougbeal|iOS joined the channel
#
[apatters] Oh yeah I see them. One in the page's main <header> and then two at the top and bottom of the article.
#
[apatters] Thanks @GWG!
#
[apatters] So, for a bit of context, when I set up the theme I uploaded my photo and some text for the site description, and then I also set up a Gravatar attached to the user account that I made the posts under, and gave it the same photo. Without the Gravatar the single post template was showing a stick man. So it looks like it might be pulling both of those things
[markmhendrickso joined the channel
#
GWG [apatters]: We don't have enough MF2 themes. We need to make sure the ones we have work well
#
[apatters] Why are they implemented in a theme as opposed to a plugin?
[chrisaldrich] joined the channel
#
GWG [apatters]: Style is the job of a theme
#
GWG [chrisaldrich]: I'm going to be doing PRs to Independent Publisher. Any thoughts?
tantek and ricmac joined the channel
#
[apatters] @GWG I thought microformats were intended to standardize semantic metadata about a piece of content. And then it is up to whoever consumes that metadata to style as they wish.
#
[apatters] So the theme is the consumer and should own the styling, but not sure about it being responsible for authoring.
#
[miklb] apatters also, there are some limitations as to what a plugin can do due to limitations by core. Though, recent improvements in the mf2 parsers where mf2 properties take precedence over older mf1 I think will improve what can be done in a plugin
#
[miklb] I intend to put it to the test by using the mf2 plugin with a core theme this week.
#
tantek [apatters]: the key is to discourage use of mf2 for styling, as use of "hentry" (mf1) for styling from core is what has caused a lot of backcompat problems
#
GWG miklb, when I suggested that additional places to add classes be built in, it didn't get traction
#
[apatters] miklb I see. What does your plugin do, does it hook into wp's save post action and add markup?
#
[miklb] GWG in core?
#
GWG I wanted a standardized e-content filter
#
[miklb] apatters no, the mf2 plugin in the indieweb repo uses filters.
#
[miklb] GWG maybe that’s something @bjkraft can help get some traction on.
#
GWG miklb, I need to write a patch to get real consideration, I think
#
[apatters] miklb Why doesn't it save the mf2 markup along with the object? Just curious
#
[miklb] apatters I don’t follow
#
GWG Which object?
#
[apatters] So microformats allow me to designate semantic meaning to a post right? E.g. that it is a quotation or something?
#
GWG Yes. But how does a plug-in know the structure of a theme?
#
[apatters] Ah, so here was how I actually had assumed it worked: suppose you want to post an event. Some plugin/theme code throws up a metabox in your post editor with various microformats to select from, one is the event format. When you save your post the markup for that microformat is written along with it.
#
[apatters] You could do that without the theme ever knowing or caring about microformats, I think, though there might be other drawbacks.
ricmac joined the channel
#
[miklb] it’s saving properties as postmeta not the markup.
#
GWG You just explained how the Post Kinds plug-in works
#
[miklb] post-kinds uses templates with the mf2 and pulls in the postmeta for appropriate type. Themes can over ride those templates
#
[apatters] Does the Post Kinds plugin use microformat for all those post types?
#
[apatters] Got it
#
[apatters] Webmentions and microformats seem like the sort of things to me which should be in the wp core
#
GWG But the issue is that some things are hard coded by the theme so therefore can't be modified outside of it.
#
GWG Amen to that
#
[miklb] core does have mf1. The problem there is that a lot of theme devs used those classes for styling (bad!) so last I read, core was hesitant to change that up (sad!)
#
tantek good summary [miklb]
#
GWG There has to be a compromise
#
[apatters] If mf1 classes were used for styling, why won't mf2 classes be used for the same purpose? Even if it's a bad practice, it's probably tempting to do
#
[miklb] Biggest hope is for 4.0 because I think they are aiming for some other breaking changes
#
[apatters] And this is WP. 20% of the internet or whatever
#
GWG Big target
#
[apatters] Someone's gonna do it (thousands of someones)
#
[miklb] apatters well, I don't think a mf3 is in works any time soon ?
#
[apatters] lol
#
[apatters] Too late for mf2 to include a namespace in the classnames I guess. e.g. mf2-h-event
#
tantek [apatters] because 1 we mistakenly encouraged people to use mf1 classes for styling (have since reversed that), 2 because mf2 classes are now more distinctive so at least it is easier to tell them apart from classes for styling. not guaranteed, but better chances
#
tantek [apatters]: they already a few several prefixes h-,p-,u-,dt-,e-
#
[miklb] Wait, I said 4.0 I mean 5.0 it's 4.8 now
#
GWG I haven't given up though
#
[apatters] If it could break some themes then it's probably more appropriate for 5.0
#
[miklb] Break is relative, but I agree might be best argument to get it included
#
GWG They'll never do anything to 'break' a lot of sites
#
[miklb] I do think the improvements in parsers to give mf2 precedence over existing mf1 classes helps
#
[miklb] That seems like a fairly recent change
#
GWG [miklb]: It is and it does.
[anomalily] and ricmac joined the channel
#
[chrisaldrich] GWG: To my knowledge the extra u-photo and lack of a true h-card are the only things I think are obviously missing from Independent Publisher.
#
GWG [chrisaldrich]: That u-photo should be wrapped in an h-card and the other h-cards removed.
#
[miklb] what’s a true h-card?
#
[chrisaldrich] He's also got a small bug he may have been having difficulty tracking down with respect to webmentions: https://github.com/raamdev/independent-publisher/issues/254
#
Loqi [raamdev] #254 IndieWeb Facebook "Loves" break webmention integration
#
GWG It's not a bug
#
GWG It's a missing feature on Semantic Linkbacks
#
GWG Reacji are classified as replies. Replies = comments. Solution. Support Reacji. https://github.com/pfefferle/wordpress-semantic-linkbacks/issues/60
#
Loqi [dshanske] #60 Reacji
#
[chrisaldrich] Oh, I hadn't heard that, but also hadn't seen the issue he describes in other themes. So part missing feature/part bug perhaps?
#
[chrisaldrich] It seemed like he was missing a piece of html then and all of the webmentions beyond those he indicated were being wrapped with the same URL.
[cleverdevil] joined the channel
#
GWG I'm thinking of fixing Independent Publisher so I can adopt it. My site is in need of a visual refresh.
[pfefferle] joined the channel
#
[pfefferle] GWG I have a way more interesting theme you can contribute to https://github.com/pfefferle/ZenPress ?
#
Loqi [pfefferle] ZenPress: Pure Zen for WordPress
#
GWG [pfefferle]: I'm still going to fix Independent Publisher because so many use it. But I will also contribute to ZenPress. I want to have more themes that work with my plugins. May be selfish, but good in the long run.
#
[miklb] pfefferle are you using zenpress or is there a demo?
#
[pfefferle] https://notizblog.org
#
[pfefferle] ups old url https://notiz.blog
#
[pfefferle] miklb but it is still in dev!
ricmac joined the channel
#
[pfefferle] GWG just joking
#
GWG [pfefferle]: I'll contribute to anything.
#
GWG If I think it will help
#
[pfefferle] ?
#
GWG But I do need a new theme, and my design skills are such I'd rather add features to someone else's.
#
GWG [pfefferle]: I may even send PRs to SemPress someday
#
GWG Does no one like the time on their posts?
#
[miklb] I show the time in my timeline on the home page, but not permalinks
#
GWG [miklb]: I am in Pacific time. I want to show that I was on my posts made here
#
[miklb] fair. Might get more feedback on that in #indieweb
#
GWG Good point
#
GWG So much to do, so little time
#
GWG I'm releasing 3.1.0 of Simple Location. More features to come, but there are a lot of things in there I want to get out while I work on it.
#
[miklb] seems like a good idea. Especially the option to set maps as public. I have the dev branch on my live site for it now.
#
GWG [miklb]: It's done.
#
[miklb] cool, I switch to master branch later.
#
GWG It also fixes an OYS problem
#
GWG It sets any post created outside the Post UI to the default
#
[miklb] default of?
#
GWG System default
#
GWG The new checkbox.
#
GWG get_option( 'geo_public')
#
[miklb] ah
#
GWG If it isn't set, it defaults to WordPress default, which is public
#
[miklb] Still need to sort out the problem of OYS not getting a post-kind set since it uses mf2_checkin though
#
GWG [miklb]: Told you my plan on that
#
GWG Going to support URL checkin in Post Kinds and local in Simple Location
ricmac joined the channel
#
[miklb] OK. I’ll continue with my branch/PR for that then.
#
[miklb] Just had a thought GWG, if the MF2 plugin can co-exist with themes, why not just make it part of the IW plugin? cc/pfefferle
#
GWG miklb, might work
#
[miklb] just thinking out loud, but combining them would be as soon as you activate the IW plugin, you immediately have some basic mf2 support, and we could keep building on that.
#
[miklb] opened an issue in MF2 repo.
#
[pfefferle] will answer both of your question when i am home from work
#
GWG What was my question?
#
GWG This time, at least
[cleverdevil] joined the channel
#
[pfefferle] I meant miklb
#
[pfefferle] he opened two issues and asked for feedback
#
GWG Oh
#
[miklb] no worries. thanks pfefferle
[chrisaldrich], [kiai], ricmac, dougbeal|mb1, [apatters] and [pfefferle] joined the channel
#
[pfefferle] miklb so, one comment done ?
ricmac, [kevinmarks] and [miklb] joined the channel
#
GWG Well, free coding day, I guess
#
[pfefferle] ok, miklb thanks for the help... commited a new version!
#
[miklb] ?
#
GWG pfefferle, do you have any instructions on how you automated deployment?
#
GWG I would like to do that
#
[pfefferle] for what plugin?
#
[pfefferle] I used this one https://github.com/miya0001/travis2wpplugin
#
Loqi [miya0001] travis2wpplugin: Automated deploy to WordPress plugin repository from Travis CI
#
[pfefferle] It has a typo, but works really well ?
#
[pfefferle] and .svnignore https://github.com/miya0001/travis2wpplugin
#
Loqi [miya0001] travis2wpplugin: Automated deploy to WordPress plugin repository from Travis CI
#
GWG pfefferle, what typo?
#
[pfefferle] WP_PULUGIN_DEPLOY=1
#
GWG pfefferle, for my plugins...all of them. I like convenience
#
[pfefferle] no, the travis2wpplugin ?
#
[pfefferle] GWG let me know if I can help
#
[miklb] auto-deploy all the things
#
[pfefferle] yes! it is so much easier
#
[pfefferle] simply make a tag and thats it
#
[pfefferle] release fast, release often
dougbeal|iOS joined the channel
#
[miklb] I’ll do the featured/u-photo thing in a branch for wp-uf2. I like the idea too of themes being able to selectively pick what to declare support for too.
#
[pfefferle] :thumbsup:
#
[pfefferle] do you have access to the wp-uf plugin?
#
[miklb] yes, it’s in the indieweb repo, and I’m a member of the WP team of which that is part of.
#
[pfefferle] :thumbsup:
[cleverdevil] and ricmac joined the channel
#
[pfefferle] GWG added pull request for post-kinds
#
[pfefferle] GWG please let me contribute!
#
[pfefferle] ?
#
[pfefferle] GWG the PHP 5.2 support seems no longer working...
ricmac joined the channel
#
GWG pfefferle, I need to do testing for versions
#
[pfefferle] but 5.2?
#
[pfefferle] if so, you have to fix phpunit
#
[miklb] heh, 5.2, I just put 7.1 on my local dev environment
#
[pfefferle] ^^
ricmac joined the channel
#
[pfefferle] btw I can recomment composer if you want to test your GitHub WordPress plugin version live on your server, before deploying it to WP.org
#
GWG pfefferle, there is a phpcs script for versions of php
#
[pfefferle] not that I know...
#
[pfefferle] indieweb composer example https://github.com/indiewordpress/composer
#
Loqi [indiewordpress] composer: A composer version of the IndieWeb WordPress plugin
[kevinmarks] and ricmac joined the channel
#
GWG https://github.com/wimg/PHPCompatibility
#
Loqi [wimg] PHPCompatibility: PHP Compatibility check for PHP_CodeSniffer
#
GWG I need to learn more about Composer.
#
[miklb] speaking of phpcs, I can’t wait for the WP cs library to update to 3.0
ricmac joined the channel
#
GWG [miklb]: Oh?
#
[miklb] yep, phpcs 3.0.1 is out, but the WP sniffs aren’t compatible with it. There’s a lot of work going on in that repo, but no release yet.
#
[miklb] And I use homebrew for all of my local packages/dev environment, and they only have the latest version (no way to go back unless you have a cached version of previous release) so I’m dead in water with WP sniffs unless I were to try and manually install older package.
#
[miklb] I deleted homebrew and rebuilt my local nginx webserver/dev environment over the weekend, thus loosing my cached older version ?
ricmac, [chrisaldrich], dougbeal|mb1 and [davidized] joined the channel
#
[davidized] @gwg: Simple Location 3.1.0 is throwing a fatal error on activation. Looks like you’re requiring a file that doesn’t exist. https://github.com/dshanske/simple-location/issues/27
#
Loqi [davidized] #27 Fatal Error on Activation
#
GWG [davidized]: It shouldn't be doing that. I tested the update on my site. Odd. That file doesn't exist anymore.
#
GWG Standby
#
GWG [davidized]: I can't reproduce that
#
[davidized] I thought my update was botched so I tried deleting and re-downloading and had the same problem. Let me try it again.
#
GWG Very odd, I checked the repo and it doesn't even try to load geo meta any longer
#
[davidized] Just tried it again, same problem
#
[davidized] Looks like it’s trying to load it on line 26 https://github.com/dshanske/simple-location/blob/master/simple-location.php#L26
#
GWG Will remove. I had to rename because the class is geo data
#
GWG One second, going to a computer
#
GWG Pushed to Github.
#
GWG Pushing to SVN next
#
[davidized] Tested the new version on github, success ?
#
GWG [davidized]: Tell me what you think of the plugin now that it activates
#
GWG I'd like a review. Uploading to wordpress.org, but not bumping the version number
#
GWG [davidized]: This is an intermediate point. A lot of the changes were under the hood, but I have more features to add.
ricmac joined the channel
#
[davidized] I’ll take a look shortly, looking forward to the changes
#
GWG [davidized]: Do you want me to highlight them while you are here?
#
[davidized] No, I’ll dig around when I get the chance
#
GWG Ok
#
[davidized] Thanks though
#
[davidized] Locations are the next thing I want to add into the theme I made for my site
#
GWG [davidized]: The next features are check-ins and venues.
#
[davidized] Awesome! looking forward to it
ricmac, dougbeal|mb1 and [eddie] joined the channel