#wordpress 2017-07-03

2017-07-03 UTC
ricmac, davidmead, [miklb] and tantek joined the channel
#
GWG miklb, I have been working on PRs for Independent Publisher
ricmac joined the channel
#
ben_thatmustbeme Wonder how much work it would be to sell WordPress on adding jf2feed support
#
GWG ben_thatmustbeme: Start with a plugin?
#
ben_thatmustbeme Yeah, unfortunately I'm spread this enough with projects I work on
#
GWG ben_thatmustbeme: What's the sales pitch?
#
ben_thatmustbeme To WordPress: Newer format that is much simpler than RSS/atom. Very similar to jsonfeed, but actually has an official mime type, w3c recognition, and extensible by a living spec of vocabulary (microformats)
#
GWG And who is consuming t?
#
GWG it?
#
ben_thatmustbeme To indieweb devs : it's a way to get mf2 vocab into all templates, not just one or two
#
ben_thatmustbeme That's the issue I have yet to work on. Bc filing issues with as many feed
#
ben_thatmustbeme Readers as I can very shortly
#
ben_thatmustbeme That's the next step, but it's always a chicken and egg situation
ricmac, tantek and [miklb] joined the channel
#
[miklb] GWG oh yeah? I haven’t looked at the code in that theme, only glanced at the demo.
#
GWG [miklb]: I sent a PR last year for basic MF2. Time for an upgrade
ricmac and tantek joined the channel
#
[miklb] actually, I do recall that.
#
GWG It was basic. But a lot of people like the theme, so it's a good time.
#
GWG And I've learned a lot since then
#
ben_thatmustbeme Hmm actually, I'd imagine it will be pretty much a copy of this code base https://github.com/manton/jsonfeed-wp
#
Loqi [manton] jsonfeed-wp: WordPress plugin to add a JSON Feed to your site.
ricmac, tantek and [cleverdevil] joined the channel
#
petermolnar (should I write a YAMLFeed for WP? I don't think I should, people would think it's a real thing.)
[pfefferle] joined the channel
#
[pfefferle] !tell aaronpk just wanted to ask if you have generated the wordpress@indieweb.org email address?
#
Loqi Ok, I'll tell them that when I see them next
pfefferle and ricmac joined the channel
#
GWG Good morning, IndieWebPress types
ricmac, davidmead and [pfefferle] joined the channel
#
[pfefferle] moin moin
#
GWG pfefferle, how are things?
#
[pfefferle] good, sorry for not answering your merge request, but I had a free weekend
#
[pfefferle] will have a look hopefully later today
ricmac joined the channel
#
GWG pfefferle, I am out of town on a business trip. Nothing to do outside of work but writing PRs
#
[pfefferle] ?
#
[pfefferle] europe?
#
GWG Manila. Although I am eating in a German restaurant
Kaja joined the channel
#
GWG pfefferle, ironically, right after I pushed the changes, Core finally merged my patch for updating Comment Meta using that filter we advocated for
ricmac and Kaja joined the channel
#
GWG Either way, I have moved into theme PRs. Writing one up for Independent Publisher. Did an update of my one for _s. And may try to send one for your themes
#
[pfefferle] I've read that one...
#
[pfefferle] what have you eaten
#
[pfefferle] ?
ricmac joined the channel
#
GWG Salmon.
ricmac joined the channel
#
[pfefferle] lachs
#
[pfefferle] (the german word)
ricmac joined the channel
#
[pfefferle] GWG btw. https://github.com/dshanske/indieweb-post-kinds/pulls
ricmac, tantek, [jeremycherfas] and [miklb] joined the channel
#
[miklb] hmm. I got a reply webmention on a post, and it shows as a comment in the WP admin, but isn’t displaying on front end, though marked as approved.
ricmac joined the channel
#
GWG Odd.
[chrisaldrich] joined the channel
#
[miklb] Yeah. Happened one other time & I thought it wasn't displaying due to threading issue, but this isn't a reply to a reply.
#
[miklb] Will dig into the db soon
ricmac joined the channel
#
GWG Keep me posted
#
[miklb] what is the meta key mf2_content--webmentions
#
Loqi It looks like we don't have a page for "meta key mf2_content--webmentions" yet. Would you like to create it?
#
[miklb] this is a little weird https://gist.github.com/miklb/9429596c7f2521a1d6678e1691a23bc5
ricmac joined the channel
#
[miklb] GWG, pfefferle ^^ if you have any ideas what’s up with that
#
[miklb] that’s the serialized array for the mf2_content--webmentions meta key
[pfefferle] joined the channel
#
[pfefferle] what is the key?
#
[pfefferle] woops
#
Loqi It looks like we don't have a page for "key" yet. Would you like to create it?
#
[miklb] pfefferle mf2_content--webmention I’ve never seen that one before. Not sure where it’s coming from
#
[pfefferle] hmmm me too ?
#
[miklb] from micropub possible?
#
[miklb] I have been running master of a lot of the plugins, but didn’t think there was anything experimental going on.
#
[pfefferle] might be https://github.com/snarfed/wordpress-micropub/issues/52
#
Loqi [dshanske] #52 Query Should Use WordPress Properties
#
[miklb] I’m also seeing a mf2_html-lang meta_key with just a value of “e”
#
[pfefferle] it is not part of semantic-linkbacks or webmentions as far as I can see
#
[pfefferle] yes, seems to be micropub https://github.com/snarfed/wordpress-micropub/blob/ef13c0877af51bd390fce7b6f63c82c3f403db5c/micropub.php#L691
#
[miklb] so I’ve got 2 things going on, the mention not displaying even though it’s an approved comment and some funky meta_keys
#
[pfefferle] is it comment meta
#
[pfefferle] or post meta
#
[pfefferle] oops, seems that semantic-linkbacks is also setting meta-keys https://github.com/pfefferle/wordpress-semantic-linkbacks/blob/b070f615485af7eb6176a9f237b2adfd478d8c29/includes/class-linkbacks-mf2-handler.php#L253
#
[miklb] commentmeta https://cdn.miklb.com/miklb_commentmeta.png
#
[miklb] micropub shouldn’t be setting any properties though for a webmention
#
[miklb] wondering if it’s not displaying because it’s a “mention” type and not a reply
#
[miklb] oh, weird, it’s coming from calumryan http://pin13.net/mf2/?url=https%3A%2F%2Fcalumryan.com%2Fnote%2F834
#
[miklb] the mf2_content--webmentions that is
#
[miklb] are there no checks what gets stored as an mf2_property ??
#
[miklb] at first glance, this looks…bad.
tantek joined the channel
#
[miklb] am I reading this wrong? could anything be passed by e-content--something and stored in the db?
ricmac and [cleverdevil] joined the channel
#
[pfefferle] I have to admit that i am not sure... it was a change of GWG... have to have a look later... would be very spammy if so...
ricmac joined the channel
#
GWG I am responsible. Semantic Linkbacks stores mf2 properties in comment meta.
#
GWG There is a blacklist though, and content is on it
#
[pfefferle] then it seems to be a bug
#
[pfefferle] and perhaps we should whitelist instead
#
GWG pfefferle, I was just about to say that.
#
tantek is a little confused by how people are referring to e-content here
#
tantek e-content is not about "what you want to send to Twitter"
#
GWG I'll prepare the whitelist and filter. I also will add sanitizing
#
tantek e-content is literally the content of the post, the same thing you would put into an RSS <item>, or an Atom entry content
#
tantek so if there is extra "junk" in there, that's the site/template's fault, and presumably the same as if such extra junk showed up in the RSS or Atom feed entry contents as well
ricmac and doubleloop[m] joined the channel
#
GWG tantek, the issue here is a custom class that calumryan put in, and my code storing it. miklb saw it when troubleshooting an unrelated issue
#
GWG tantek, Bridgy uses a class to specify POSSE text if not e-content
#
tantek sure, that's a Bridgy extension, and that's fine
#
tantek but what's not fine is saying "e-content is how you say what to send to Twitter"
#
tantek that's confusing default behavior with purpose / meaning
#
tantek confusing / conflating
#
GWG I agree on that point
#
GWG pfefferle, miklb, any thoughts on what properties should be stored as parsed mf2 from a Webmention by default?
#
GWG I know I want to store location, syndication...
#
tantek GWG, why not all h-entry properties?
#
GWG Not sure about like-of, bookmark-of, etc.
#
tantek instead of having to (re)debate each one
#
GWG tantek, I had it as a blacklist, which meant it stored most properties, we were just discussing switching to a whitelist.
#
GWG What would all entail if not the blacklist code that I originally implemented m
ricmac joined the channel
#
GWG I have already started to implement features that use the data
ricmac, tantek, [kiai] and [pfefferle] joined the channel
#
[pfefferle] GWG I would start with the data you really need
#
tantek [pfefferle]++ agreed. use-case -> data need
#
Loqi pfefferle has 2 karma in this channel (29 overall)
ricmac joined the channel
#
[pfefferle] hey tantek nice to see you in the wordpress channel
#
[pfefferle] GWG have you seen my merge requests?
#
tantek [pfefferle]: I was super-happy with all the WordPress discussions and coding and hacks and demos at IndieWebSummit.
#
tantek really grateful for all the work you and GWG and others here did in the previous few months to make it easier to get setup and update IndieWeb support in WordPress
#
[pfefferle] sad, that I am so far away ?
#
tantek [pfefferle]: but the sessions are all captured online and with video! check it out: https://indieweb.org/2017/Schedule lots Saturday and one session on Sunday too (plus the demos obviously :) )
#
[pfefferle] yes, I saw most of them and participated to the WP session online
#
[pfefferle] but it is not really the same
#
[pfefferle] ?
[miklb] joined the channel
#
[miklb] I guess my concern was with the arbitrary data stored. I assume it’s being sanitized just disconcerting to see php in my db this morning.
#
[pfefferle] miklb yes, It was serialized
#
[miklb] my pre-coffee thoughts that were someone could put some hanky sql in a class and send a webmention that injects it into my db
#
[pfefferle] miklb yes, thats why we should whitelist and escape attribs
#
[pfefferle] we already do that for the webmention plugin and for the classic semantic-linkback metas
#
[miklb] nods
#
[pfefferle] but you are right, there are some fields missing
#
[pfefferle] we should really fix them
#
Loqi yea
#
GWG pfefferle, which fields are missing?
#
GWG I will escape and sanitize, although the remote html is sanitize
#
[pfefferle] https://github.com/pfefferle/wordpress-semantic-linkbacks/blob/b070f615485af7eb6176a9f237b2adfd478d8c29/includes/class-linkbacks-mf2-handler.php#L195
#
[pfefferle] https://github.com/pfefferle/wordpress-semantic-linkbacks/blob/b070f615485af7eb6176a9f237b2adfd478d8c29/includes/class-linkbacks-mf2-handler.php#L199
#
[pfefferle] should be esc_url
#
[pfefferle] and all comment-meta
#
[pfefferle] hey GWG, do you have some minutes to talk about your merge request?
ricmac joined the channel
#
[pfefferle] GWG I added some comments... I don't think that your changes will work and I do not understand why to replace the `wp_update_comment_data`
#
[pfefferle] I would also like to change the action name in the Webmention plugin to `webmention_edit_post` to be more compatible to `webmention_post`
#
[pfefferle] to be more consistent
[kevinmarks] and [miklb] joined the channel
#
[miklb] how bizarre. Just saw that the post that calumryan sent a webmention for POSSE to Twitter. A year old post. Wonder what triggered an update on the post to fire bridgy-publish.
pfefferl_ joined the channel
#
[pfefferle] miklb can you PM aaronpk your email, to add you to wordpress@indieweb.or
#
[miklb] done
tantek joined the channel
#
[pfefferle] ok, I created an WordPress.org account for the autodeployments and I will add the email to this account if it works
#
[miklb] does receiving a webmention fire a post update?
#
tantek what is deployment
#
Loqi deployment is the both the act (to deploy), process, and specific instances (a deployment) of updating (and sometimes installing) software on a server, like a web server https://indieweb.org/deployment
#
tantek what is autodeployment?
#
Loqi It looks like we don't have a page for "autodeployment" yet. Would you like to create it?
#
[miklb] pfefferle what’s the wp.com account for? Gravatar?
#
[pfefferle] yes
#
[miklb] ?
#
[pfefferle] https://profiles.wordpress.org/indieweb
#
tantek whoa very cool!
#
tantek what is the wordpress outreach club?
#
Loqi The WordPress Outreach Club is a group of active IndieWebCamp participants who reach out to individuals already running WordPress to add IndieWeb functionality to their existing sites https://indieweb.org/WordPress_Outreach_Club
#
tantek wordpress outreach club << https://profiles.wordpress.org/indieweb
#
Loqi ok, I added "https://profiles.wordpress.org/indieweb" to the "See Also" section of /WordPress_Outreach_Club
#
loqi.me edited /WordPress_Outreach_Club (+42) "tantek added "https://profiles.wordpress.org/indieweb" to "See Also"" (view diff)
[cleverdevil] joined the channel
#
[miklb] pfefferle that reminds me, I’ve been meaning to set up some watches for the IW plugins in the support forums.
#
GWG pfefferle, I have time now. Done with work
#
GWG pfefferle, edit_webmention is consistent with edit_comment.
#
[pfefferle] hey GWG
#
[pfefferle] what about the rest
#
[pfefferle] I do not understand why these changes and I think they will not work
#
GWG pfefferle, sometimes I do things and the next day ask myself why I did them.
#
GWG Either way, I think we need a webmention unit test for updates.
#
GWG pfefferle, I will revisit the PR.
#
[pfefferle] GWG ?
#
[pfefferle] that means you don't know it either?
#
[miklb] I’m determined to learn unit tests from watching you guys use them in WP plugins. I’ve avoided them to this point.
#
GWG pfefferle, I mean it seemed like a good idea then
#
GWG miklb, I stink at them
#
[pfefferle] GWG no problem ?
#
GWG pfefferle, at the least, I will close and do a new PR with the whitelist changes and anything else I feel comfortable with
#
[pfefferle] GWG ok... for example the avatar changes
#
GWG pfefferle, I think that is a good refinement
#
[miklb] stink at them > no clue about how to get started with them
#
GWG Ditto
#
[pfefferle] Is there a more understandable version of it?
#
[miklb] I just need to do some research. I’ve not actually looked at how to get started using them.
#
GWG pfefferle, I have been thinking about storage again. But changing that would be a pain.
#
[pfefferle] GWG no problem! let's do it anyway!
#
[pfefferle] if we have a migration concept i am fine with anything
#
GWG pfefferle, I am going to tread slowly on that
#
[pfefferle] should we start a wiki page on that?
#
GWG First, I need a proposal for how we'll handle custom comment types.
#
GWG Until there is more formalized support in Core
#
[miklb] anymore thoughts on https://github.com/indieweb/wordpress-uf2/issues/30#issuecomment-312375228
#
Loqi [kraftbj] I apologize for the delay. Headed out of town for a vacation next week so trying to get everything at work packaged up. I meant to draw a diagram of how this all fits together. If I'm not making sense after this comment, I'll do that for when I'm bac...
#
[pfefferle] GWG I would love to start with some more unittests for the SL plugin, that makes it easier for us to add such fundamental changes
#
GWG I have trouble thinking them up. But will try.
#
GWG We need an update one.
#
GWG What other cases do we need to test?
#
[pfefferle] I think we should start with create and update
#
[pfefferle] miklb added a new comment
#
GWG pfefferle, does that belong in SL or webmention?
#
[pfefferle] miklb but I am not sure that I am the correct person to discuss this issue... I see it only from the theme developer perspective...
#
[pfefferle] GWG i think in both
#
GWG Okay
#
[miklb] pfefferle it may have been lost in the conversation that you were looking for a solution that didn’t include the mf2 plugin. I didn’t get that out of the thread or discussion until just now.
#
[pfefferle] sorry, sometimes it's hard to find the right words in a foreign language ?
#
[miklb] happens in primary language all the time
#
[pfefferle] I think uf2 is the correct place to discuss it, because the uf2 plugin should also be disabled if another plugin or theme already supports the semantic
#
[miklb] my wife doesn’t get what I’m saying most days ?
#
[pfefferle] ?
#
[pfefferle] so I see uf2 not as a manager, but as another participant, like semantic-linkbacks, micropub and indie post kinds
#
[miklb] ah. OK
#
[pfefferle] If I always need uf2, I can directly implement it into my theme...
#
[pfefferle] thats way easier
#
[pfefferle] and that's why I prefer a very simple version, like the proposed theme_support
#
[miklb] “so I see uf2 not as a manager, but as another participant, like semantic-linkbacks, micropub and indie post kinds” I would add that to the issue
davidmead joined the channel
#
[pfefferle] will you or should I?
#
doubleloop[m] Is there a nice way to post to my indieweb wordpress site from my android phone?
#
GWG I wish there was
#
GWG There are Micropub clients, but none native Android
#
doubleloop[m] The wordpress app is good, but doesn't include any interface for plugins you add
#
doubleloop[m] So you can't do indieweb stuff with it
#
doubleloop[m] I've just been using the web interface, but it's clunky on mobile
#
GWG What sort of posts?
#
[miklb] Quill?
#
doubleloop[m] Mainly notes. And notes with photos
#
[miklb] doubleloop I would use Quill for those. You could save it to your home screen.
#
GWG It works on mobile, but there is no perfect experience yet
#
[miklb] same can be said for iOS
#
[miklb] I thought micro.blog supported micropub, but when I tried to set up it up w/my site, it was prompting me for username/password. I haven’t tried recently to see if that’s changed.
#
[miklb] So maybe it detects WP and tries defaults to xmlrpc?
#
GWG I should get liking/bookmarking working from phone to site in one step
#
Loqi yea
#
GWG I never set up autoparse
#
doubleloop[m] [miklb]: thanks
#
doubleloop[m] I just tried it, but it doesn't seem to have posse'd to Twitter. I'll have a play around with it.
#
GWG doubleloop, you are using Bridgy Publish for that?
#
[miklb] doubleloop, I use the bridgy-publish plugin and have it default to post to Twitter.
#
doubleloop[m] Yeah
#
GWG The option should be selectable in the Micropub interface
#
[miklb] oh, right!
#
doubleloop[m] GWG: bookmarks would be great
#
doubleloop[m] GWG: yea it was there - I selected it but hasn't posted
#
GWG Bookmarks are just s small enhancement to Post Kinds
#
doubleloop[m] That's cool though, quill! - would the process also then add the link into semantic linkbacks?
#
GWG I don't understand the question
#
GWG Semantic Linkbacks handles incoming Webmentions and displaying them
#
doubleloop[m] Sorry - syndicated links.
#
[miklb] I confuse post-kinds doing the autoparse & semantic-linkbacks all the time
#
GWG miklb, they both have parsers
#
[miklb] “linkback” makes me think that’s what is pulling in the info from a URL
#
GWG Syndication Links works with Bridgy Publish
#
[miklb] maybe “autoparse” isn’t what you call it. When you paste in a URL and click “retrieve” to get the mf2 properties for the url.
#
GWG Miklb, to have it go automatically so you could bypass the post UI is next.
#
[miklb] cool. I still confuse which plugin does that though ?
#
GWG Post Kinds will.
#
GWG [miklb]: I wrote the code that does the parsing originally in Indie-WebActions and then moved it. It has been rewritten three times since.
ricmac_ joined the channel