2018-04-04 UTC
[kaushal_modi], [jgmac1106], [kevinmarks] and [xavierroy] joined the channel
# 02:56 [xavierroy] Is there an option to post a single post PESOS ? I want to tag a couple of people who are on FB only. But I want a copy of that post on my site too? Is it possible?
# 02:57 GWG It should be, if you do so manually. Not sure if there is an automated option.
j12t, tantek, jeremycherfas, [kevinmarks], jeremych_, GWG-, [joewillmott], dougbeal|mb1, kaushalmodi, ben_thatmustbeme and [miklb] joined the channel
# 15:06 [miklb] a low volume email newsletter run from your own account & WP might not be an issue, but higher volume and people eventually marking it as spam if they forgot they subscribed can cause issues real fast.
# 15:20 sknebel my understanding was that it's status like "draft", "published"
# 15:20 aaronpk I don't understand why there isn't a simple fix for the plugin for this
# 15:20 sknebel has there been no new release yet, or did that not fix it?
# 15:21 aaronpk the micropub plugin returns {"error":"invalid_request","error_description":"Invalid Post Status"}
# 15:22 [miklb] ah, there’s an issue open on the plugin for that, and I think they attempted a fix in the master branch
# 15:22 [miklb] GWG can’t seem to replicate the error and all tests are passing.
j12t joined the channel
# 15:34 sknebel hm, not clear from the issue if that fix has been tested or not by someone with the issue
[snarfed] and [joewillmott] joined the channel
# 16:01 GWG I have tried everything to figure out that error.
[tantek], j12t and [jgmac1106] joined the channel
# 16:13 sknebel did someone confirm to you that the fix didn't help?
# 16:23 GWG The feature has a unit test that keeps passing. I had three people try their installation
# 16:24 aaronpk it's getting too annoying having everyone complain that ownyourgram is broken
# 16:25 GWG aaronpk: The only thing I haven't tried is removing the feature entirely.
kaushalmodi joined the channel
# 16:25 GWG The error message comes if the post status is null.
# 16:26 GWG If neither post-status or visibility is set, it should automatically return the correct one.
# 16:26 GWG I've tried fiddling with it a few times.
# 16:27 GWG I can't figure out a scenario where it would hit a null
# 16:30 aaronpk "This will add several common social media site fields to your "Edit User" page"
# 16:33 aaronpk does the wp_remote_retrieve function do its own ssl cert checking?
# 16:35 aaronpk that's unfortunate that it doesn't use my system root CA list
# 16:36 aaronpk I went through all this trouble setting up a local dev environment with an ssl cert that my browser and everything else trusts, but wordpress has its own list apparently
# 16:40 GWG aaronpk, that drives pfefferle crazy too
tantek joined the channel
# 16:40 aaronpk there are lots of bugs with the current released micropub plugin
# 16:40 aaronpk it can't even create a simple post out of the box
# 16:41 [jgmac1106] I don't use the wordpress mail and instead run it through gmail smtp, I don't run into any rate limits, but I only have a few hundred subscribers
# 16:43 GWG What happens when you create a post?
# 16:44 aaronpk out of the box there are no syndication targets defined but the code apparently assumes there will always be something
ben_thatmustbeme joined the channel
# 16:48 GWG aaronpk: snarfed just accepted a PR I did that fixed a lot of error notices
# 16:48 GWG But syndication targets are still messed up
# 16:48 aaronpk i'm trying to reproduce this error in the current release
# 16:49 GWG The code included assumes both sides are a uid where one side is an array
# 16:54 GWG snarfed maintains the plugin, but doesn't actually use it, if I remember correctly.
# 16:54 GWG I use it, but sparingly. I want to up my usage.
j12t joined the channel
# 17:01 tantek GWG, do you have tests for releases of the WP Micropub plugin? Or should I ask snarfed? E.g. does it have to pass the entire Micropub server test suite before being released?
# 17:02 aaronpk oh crap what happened, my rel=me links disappeared
# 17:05 aaronpk hacks around this problem by adding custom html to the sidebar widget
# 17:06 aaronpk why would the indieweb plugin suddenly not include the rel=me links on my home page?
# 17:07 GWG tantek: I'm not sure if he reruns it before versions. We do rerun the unit tests every time
# 17:07 GWG aaronpk: Suddenly? Not sure. There are two versions of the rel me links.
# 17:07 tantek that is very odd aaronpk, what version of the indieweb plugin are you running?
# 17:07 GWG The hidden ones or the visible ones. The visible ones require you add a widget
# 17:07 GWG The hidden ones should work automatically if you set the configuration.
# 17:07 aaronpk I *just* installed the latest from the plugin store
# 17:08 aaronpk the other thing that changed between it working and not working is now I have a bunch of posts on my home page
# 17:10 GWG aaronpk: I think I should give the Indieweb plugin some love then.
# 17:10 GWG Can you try a temporary measure? Add the rel-me widget.
# 17:10 aaronpk I just added custom html for now since this is not the problem i'm trying to track down
# 17:10 GWG If the hidden option isn't working, I will go debug that.
# 17:11 GWG Hmmm, I have a license issue pfefferle held up my last PR on. I totally forgot.
chrisaldrich joined the channel
# 17:17 GWG aaronpk: Will spend some time on it. I have icons to refresh anyway
# 17:19 aaronpk is the micropub_default_post_status setting visible in the UI anywhere?
[miklb] joined the channel
# 17:22 [miklb] if while you’re in there aaronpk and you figure out how to hook into syndication targets tag me 😂
tantek left the channel
# 17:26 GWG [miklb]: I need to fix part of that. I found it the other night. The verification code is wrong.
# 17:26 GWG Maybe that should be the next PR I send snarfed, adding a setting UI
# 17:30 aaronpk if the register_setting function isn't run then I get that invalid post status error
# 17:35 GWG It should be running. It is called
# 17:36 Loqi [andrewgribben] It gets entered into the wp_options table automatically with a blank status type when you save the Writing page.
You're right about 'status' I got momentarily confused with post kind when testing, so that makes sense. Point is without the option p...
# 17:36 aaronpk when you save the writing settings, it writes a blank value for micropub_default_post_status to the database
# 17:40 Loqi [aaronpk] > `return get_option( 'micropub_default_post_status', MICROPUB_DRAFT_MODE ? 'draft' : 'publish' );`
This doesn't work because the problem is not that `micropub_default_post_status` doesn't exist, it's that it does exist in the database and the val...
# 17:40 GWG aaronpk, I will write the configuration page today
# 17:41 aaronpk this works: return get_option( 'micropub_default_post_status' ) ?: (MICROPUB_DRAFT_MODE ? 'draft' : 'publish');
# 17:41 aaronpk i'm going to install the master branch now and see if it still happens
# 17:42 aaronpk it'll still fail with what's in the current master
# 17:42 aaronpk you did get_option( 'micropub_default_post_status', MICROPUB_DRAFT_MODE ? 'draft' : 'publish' )
# 17:42 aaronpk needs to be get_option( 'micropub_default_post_status' ) ?: (MICROPUB_DRAFT_MODE ? 'draft' : 'publish')
[kevinmarks] joined the channel
# 17:44 GWG I think I will add the settings box anyway.
j12t joined the channel
# 17:45 GWG So, registering the option but not configuring it sets it to blank. Good to know
# 17:47 aaronpk I don't understand why wordpress allows a blank value to be written in the first place but oh well
# 17:48 aaronpk seems like since it knows the default, it should have written that
# 17:48 aaronpk so are you going to add a form picker to choose the default value in the writing page?
# 17:48 GWG aaronpk, this is why I couldn't figure it out. It makes no sense
# 17:49 aaronpk okay seems like you might also want to add a fallback again just in case get_option ever returns a blank value too
# 17:50 aaronpk how quick can you publish a fix and prepare the next release?
# 17:51 aaronpk i'd really like to get this out to people since it's causing so many problems
tomwolf joined the channel
# 17:52 GWG aaronpk: The fix...this afternoon
# 17:52 GWG But I bet he'd rush it. He hates this bug too
# 17:53 aaronpk looks like there are some other unrelated changes in master but nothing too major
# 17:54 Loqi aaronpk has 7 karma in this channel (1608 overall)
# 17:54 GWG aaronpk: You'll find a lot of issues there, I know
# 17:56 aaronpk how far have you gotten with the indieauth plugin so far? what am I looking for?
# 17:56 aaronpk it looks like there's a token endpoint but no authorization server yet?
# 17:59 aaronpk looks like it's still linking to indieauth.com as its authorization endpoint
# 18:04 GWG aaronpk: I forgot to change the default.
# 18:04 GWG IT is still defaulting to Indieauth. You can change it under general
# 18:08 aaronpk I can do inline comments on the code if it's a PR
# 18:09 Loqi [dshanske] #20 Add Authorization Endpoint and More
j12t joined the channel
# 18:19 GWG aaronpk: Only ignore what WordPress has for that, which I shy away from
# 18:19 GWG Default already fixed but not yet pushed
# 18:21 GWG They are stored in user meta, with the hashed token or code as the key with the prefix _indieauth_token_ or _indieauth_code_
# 18:21 GWG The hashing and the base64 encoding was what we did in Baltimore
# 18:27 GWG I just moved the code out of the token endpoint class to reuse it
# 18:30 GWG is hoping that the default issue is the only one but doesn't think so
# 18:31 GWG That search code predates me, but it should fall back
# 18:31 GWG By the way, site/author/username should work
# 18:31 aaronpk I shouldn't have to set my website URL for this to work
# 18:32 GWG It was the only way that snarfed, pfefferle and myself could think of to map a URL to a username.
# 18:32 aaronpk how about if there is only one user, or if the indieweb plugin single-author mode is set, use that user
# 18:32 GWG I was commenting in -dev this week that multi-user sites and Micropub are something that I needed to think of.
# 18:32 GWG aaronpk: That is a good idea I can work with
# 18:33 GWG The single author setting didn't exist originally
# 18:36 aaronpk this was still from the indieauth.com auth server
# 18:36 GWG So, the token endpoint is still working, good
[stefp] joined the channel
# 18:38 [stefp] [aaronpk] I just made that change you suggested for the micropub plugin and it works.
# 18:39 aaronpk GWG: hm, why am I presented with the wordpress login screen before the authorization UI if i'm already logged in?
# 18:40 aaronpk if i'm already logged in to wordpress it should jump straight to the authorization screen
# 18:40 [stefp] Thanks. And thanks to GWG for trying to fix it.
# 18:40 GWG [stefp]: I'm going to fix it permanently.
# 18:40 GWG Thanks to aaronpk for finally figuring out what the problem was
# 18:41 GWG aaronpk: I thought an affirmative reentering of credentials made sense. But...will have a look
# 18:41 aaronpk as long as you show the user the authorization screen you don't need the extra step of having them enter their password
# 18:41 GWG [stefp]: I'll draw up the PR and send it to snarfed for approval and pushing to stable.
# 18:41 GWG aaronpk: How does the authorization screen look?
[jgmac1106] joined the channel
# 18:42 aaronpk between the wordpress login page and the authorization screen
# 18:43 GWG aaronpk: Scopes are pretty much ignored anyway
# 18:43 GWG I haven't figured out how to actually enforce them, which is an issue I need to add to the plugin
[tantek] joined the channel
# 18:44 GWG I'm not sure that is the Indieauth plugin's job though. I think it is the Micropub plugin's job.
# 18:44 aaronpk it should check what scopes are granted to the token that's being used
# 18:45 GWG Right now, it gives you all permissions for the specific user
# 18:45 GWG As for the scope stripping, urlencode?
# 18:46 aaronpk I don't quite understand all the wordpress redirect-to parameters going on
# 18:46 GWG aaronpk: That took me a week to figure out
# 18:52 aaronpk what does the "login with your domain" checkbox do?
chrisaldrich joined the channel
# 18:54 GWG Only useful if you are using a remote server
# 18:55 GWG Only if you aren't using the built-in Endpoint
# 18:55 aaronpk so if you're using the built-in endpoint then that checkbox shouldn't be visible right?
[gerwitz] joined the channel
# 19:25 aaronpk okay turns out there's a lot of things to be discussed about this. would you prefer if I file these as individual issues on your fork of the repo?
# 19:27 GWG You can put it on the PR or on the fork. Your choice
# 19:27 aaronpk i've been leaving comments on the PR but some of this will take some more discussion
# 19:27 aaronpk I have a stretch goal i'd love to see launched as part of this as well, which i'll describe in an issue
# 19:29 GWG As I said in Baltimore, because this could affect a lot of sites, I feel better having a lot of eyes on it
# 19:30 GWG I am excited to try and refine it
# 19:32 Loqi [aaronpk] #2 visual updates for the authorization form
# 19:34 GWG I figured I'd work on the visual a bit after I got the thing working.
# 19:36 GWG I will see about the code changes you suggested.
# 19:41 [jgmac1106] sorry to step into your work with my problem but it has to be the tiniest thing messing me up
# 19:51 GWG jgmac1106, interested in self hosted Indieauth?
# 19:51 aaronpk GWG: people installing this plugin shouldn't even be told there is a non-self-hosted version unless they dig reaaaallly hard
# 19:52 aaronpk the default should be that wordpress handles its own indieauth
# 19:52 GWG aaronpk: Once it is finished, that will be the default.
# 19:53 GWG [jgmac1106]: Set the Website URL in your user profile to the URL of the site and it will work.
# 19:53 GWG aaronpk just gave me an idea to fix it
# 19:54 GWG aaronpk: pfefferle designed the login functionality as a temporary measure. Temporary ended up being 3.5 years
# 19:54 GWG I first fixed that functionality, then started working on the self-hosted stuff.
# 19:55 GWG aaronpk: So, if I fix all of those, you think it will be ready to go?
# 19:55 GWG First I have the Micropub thing to do a PR for
# 19:55 aaronpk i'm almost done, still checking out a few more cases
# 20:04 aaronpk what's the expected behavior of multi-user websites with this right now?
# 20:04 GWG aaronpk: I'm not sure. I never tested multi-site.
# 20:04 aaronpk are you pushing off that use case until later? just treating it as a single-user site as far as indieauth clients are concerned?
# 20:05 aaronpk you shouldn't not test it, but it's fine to make a decision that it's unsupported
# 20:07 aaronpk full multi-user support would mean returning the author's profile URL as the `me` value returned
# 20:07 GWG aaronpk: Yes. I honestly think the user to url mapping issue could be improved.
# 20:08 aaronpk for now let's get it out the door as a single-user feature. for multi-user sites it just means that everyone logging in to micropub/indieauth apps will appear to be the same user, which is fine
[sdepolo] joined the channel
# 20:11 GWG That's why I didn't worry much about the authorization screen appearance. I just mocked something up quickly.
# 20:13 aaronpk as we know from past experience, things have a tendency to stick around longer than we expect
# 20:13 GWG Considering we started this idea in 2014.
# 20:19 Loqi [Aaron Parecki] Allow the user to set a default category for posts created by the application
# 20:19 GWG aaronpk: Wasn't that a anomalily IWS comment?
# 20:23 GWG aaronpk: Micropub stores the client_id in the post. It might be easier as a Micropub issue.
# 20:23 aaronpk cause then you need a separate management interface to create that mapping
# 20:24 GWG Anyway, I'm writing unit tests for the post status issue.
# 20:24 aaronpk oh? I wasn't sure how to do that since the bug happened when the writing settings were saved. is that something you can tell the test suite to mimic?
# 20:24 GWG aaronpk: I'm writing a test that sets the option to an empty string.
# 20:25 GWG Either way, I'm covering myself three ways
# 20:25 GWG First, I'm writing and submitting the test that checks for an empty string and corrects it.
# 20:29 GWG It's a game changer for a lot of people.
# 20:29 GWG And it solves the Indieauth being confused with rel-me-auth for some people.
# 20:37 GWG aaronpk: I'll mention you in the readme
# 20:56 Loqi [dshanske] #117 Add Post Status Configuration Option
tantek joined the channel
[joewillmott] and [chrisaldrich] joined the channel
# 21:49 GWG aaronpk: Knocking these down one by one. The hardest is adding another redirect to get the authorization code.
# 21:49 aaronpk i don't really understand how plugins end up getting run from requests
# 21:49 GWG aaronpk: Figuring out the redirects took me longer than anything else.
[sdepolo] and [kevinmarks] joined the channel
# 22:02 Loqi [aaronpk] #27 use alternative text for response_type=id
# 22:03 aaronpk when issuing an access token, the wordpress user that the token belongs to is set to the author of the post in wordpress
# 22:03 aaronpk for response_type=id, there is no access token, so nothing needs to be associated with the wordpress user later
# 22:03 aaronpk from the indieauth client's perspective, it gets back a `me` URL of the site's home page, regardless of which wordpress user logged in
# 22:04 sknebel ah, not a profile url. right, saw you mention that earlier and wasn't sure if that's "now" or intended to stay like that for now
# 22:06 aaronpk yeah with multi-user support, the client would get back a profile URL for the specific wordpress user that logged in. but it sounds like that won't be part of v1
[cleverdevil] joined the channel
# 22:06 sknebel yeah, makes sense given how prevalent single-user is
# 22:07 aaronpk yeah and single-user mode is even okay for multi-user sites for many use cases
# 22:18 GWG I am going to knock all of these issues out tonight
# 22:25 GWG I am on vacation. Coding is better than matzah
# 22:26 GWG But I don't know if I will succeed, but I am going to try.
[jgmac1106] joined the channel