#GWGJust a link to edit-post with the query string kind=___
#[miklb]code wise, sure, UX wise I’ll want to investigate best way to implement.
#[pfefferle]perhaps we should make a weekly meeting here, to discuss changes we have planned, like WordPress is doing…
#[miklb]anyway, I’m back from my conference and will be focusing on my website(s) this week so I’ll be testing and hoping to push a bunch of code. Hope everyone had a good week.
#[pfefferle]GWG It was not my intention to “kill” your productive weekend!
#GWG[miklb]: It's just an enhancement of the emails that you would get otherwise. If you turned off email notification of new comments, you'd never see it
#GWG[miklb]: Even on reply/comments, it doesn't pick up the Semantic Linkback enhancements.
#[pfefferle]Ah I see… As I said, I would like to add it, but in a more structured way…
#GWG[pfefferle]: I need to figure out what that is. Maybe it is the Core Ticket
#[pfefferle]perhaps as integration class or a seperate email class or…
#GWG[pfefferle]: I'm happy to split it into a separate class.
#[miklb]ok, well I’m catching up on exactly what you’re discussing, but my vote would be for any kind of new notifications be an opt-in
#GWGBut, maybe I should get them to use get_comment_text rather than directly pulling comment_text in the Core function
#GWG[miklb]: I think there's still some confusion. It's just changing the existing notifications built into wordpress to recognize webmentions look different than comments.
#[miklb]I misunderstood and thought you were creating separate new notifications for each type of webmention.
#GWG[miklb]: Allowing you to filter by type wouldn't necessarily be a bad idea, but no.
#GWGI linked into three things. All of them have an enable/disable settiing
#[miklb]but if the ability to more granularly only notify for replies, that would be a great feature
#GWGOne is the built in email system, the second and third were the Pushover/Pushbullet plugins for WordPress, so you could install that and its option to send messages on new comments would be enhanced. No settings because all three things have an on/off function
#[miklb]interesting. I have comment emails off, but use a Slack integration for receiving my notifications. But granular control over type would be cool. I’ll keep thinking about that.
#GWGEither way, I'll split the feature into its own separate loadable class.
#GWG[pfefferle]: I've already made some changes. I'm just going a bit farther. Every time I add a new thing, I have to repeat the facepile setting entry. I'm just going to use a for loop that uses get_comment_type_strings
#[pfefferle]are we still discussion the settings page?
#GWGThere was a serious implementation bug in settings I have to fix
#GWG[pfefferle]: register_setting was being called in admin_init, not in init. When I fixed that, any time there wasn't an option, it defaulted to 1...meaning the settings wouldn't work.
#GWGI think I may just invert it. To a single array of types to show over one setting per type. If this thing grows longer, it's going to get insane.