#wordpress 2018-06-03

2018-06-03 UTC
[tantek], j12t, [snarfed], [kevinmarks] and [dgold] joined the channel
#
david.shanske.com
edited /Getting_Started_on_WordPress (-136) "/* Indieweb Plugin */"
(view diff)
#
david.shanske.com
edited /Getting_Started_on_WordPress (+150) "/* Authentication */"
(view diff)
[kevinmarks] joined the channel
#
david.shanske.com
edited /Getting_Started_on_WordPress (+112) "/* Syndication Links */"
(view diff)
[grantcodes] and [pfefferle] joined the channel
#
[pfefferle]
why “the hard part”?
#
[pfefferle]
good morning
#
GWG
[pfefferle]: Emotionally.
#
GWG
Waiting is hard.
#
GWG
I was just responding to you, actually.
#
GWG
Re the avatar issue first
#
GWG
[pfefferle]: I agree with you about the question of whether the gravatar problem is something we want to solve.
#
GWG
[pfefferle]: Also, do you have a thought on https://github.com/indieweb/wordpress-indieweb/issues/104
#
Loqi
[dshanske] #104 Add Websub plugin
#
GWG
Either way, I was having such a productive weekend. I hate to walk it back
#
[pfefferle]
what does “walk it back” mean?
[miklb] joined the channel
#
[miklb]
howdy y’all. Random thought. We could probably add quick links for new post-kinds to the menu/menu bar yes?
#
[miklb]
reverse course
#
GWG
[miklb]: I've thought of it, yes
#
GWG
I was afraid it would be too long.
#
[miklb]
Just found myself wanting to quickly create a “like” and thought it a good idea. I’ll investigate what that will take.
#
GWG
[miklb]: It's a relatively easy add
#
GWG
Just a link to edit-post with the query string kind=___
#
[miklb]
code wise, sure, UX wise I’ll want to investigate best way to implement.
#
[pfefferle]
perhaps we should make a weekly meeting here, to discuss changes we have planned, like WordPress is doing…
#
[miklb]
anyway, I’m back from my conference and will be focusing on my website(s) this week so I’ll be testing and hoping to push a bunch of code. Hope everyone had a good week.
#
[pfefferle]
GWG It was not my intention to “kill” your productive weekend!
#
GWG
[pfefferle]: I wasn't suggesting it.
#
GWG
I just have to figure out how to address the response
#
GWG
[pfefferle]: Re notifications, I've been using a plugin I wrote for that for 3 years. I was trying to sort of roll it in
#
GWG
In June of 2015, I was posting a lot, and getting emails about likes I couldn't read.
#
[miklb]
please let that be an opt-in feature
#
GWG
[miklb]: Which?
#
[miklb]
anything related to notifications
#
GWG
[miklb]: It's just an enhancement of the emails that you would get otherwise. If you turned off email notification of new comments, you'd never see it
#
GWG
So, you already would have opted out of it.
#
[miklb]
reply/comment !== like/repost
#
GWG
[miklb]: Even on reply/comments, it doesn't pick up the Semantic Linkback enhancements.
#
[pfefferle]
Ah I see… As I said, I would like to add it, but in a more structured way…
#
GWG
[pfefferle]: I need to figure out what that is. Maybe it is the Core Ticket
#
[pfefferle]
perhaps as integration class or a seperate email class or…
#
GWG
[pfefferle]: I'm happy to split it into a separate class.
#
[miklb]
ok, well I’m catching up on exactly what you’re discussing, but my vote would be for any kind of new notifications be an opt-in
#
GWG
But, maybe I should get them to use get_comment_text rather than directly pulling comment_text in the Core function
#
GWG
[miklb]: I think there's still some confusion. It's just changing the existing notifications built into wordpress to recognize webmentions look different than comments.
#
GWG
But clearly, I need to rethink that too.
#
[miklb]
OK, that makes sense.
#
[miklb]
I misunderstood and thought you were creating separate new notifications for each type of webmention.
#
GWG
[miklb]: Allowing you to filter by type wouldn't necessarily be a bad idea, but no.
#
GWG
I linked into three things. All of them have an enable/disable settiing
#
[miklb]
but if the ability to more granularly only notify for replies, that would be a great feature
#
GWG
One is the built in email system, the second and third were the Pushover/Pushbullet plugins for WordPress, so you could install that and its option to send messages on new comments would be enhanced. No settings because all three things have an on/off function
#
[miklb]
interesting. I have comment emails off, but use a Slack integration for receiving my notifications. But granular control over type would be cool. I’ll keep thinking about that.
#
GWG
Either way, I'll split the feature into its own separate loadable class.
#
GWG
And try to simplify it.
#
GWG
I hope I understand [pfefferle]'s concerns.
#
GWG
I just saw an opportunity to cut another plugin out of my collection and extend it to other people.
#
Loqi
gwg has 64 karma in this channel (359 overall)
#
[pfefferle]
I hope I understand you!
#
GWG
[pfefferle]: As long as we keep working at it
#
GWG
[pfefferle]: If you ever attend an IWC in person, I'd be tempted to make an appearance.
#
[miklb]
GWG re: my custom kind-views, you are correct, they’re not fully thought out but will be one of my focuses this week.
#
GWG
[miklb]: I was more trying to point out that he didn't need to build something new unless he really wanted to
#
[miklb]
understood. Just agreeing though that mine could be better and I plan on tackling that. Having those templates are a really great feature.
#
GWG
[miklb]: If you remember, I completely redesigned them because I wanted more themes to support them optionally
#
[pfefferle]
Even if it is in Germany?
#
[miklb]
yes, and I fully support that. I’ve suggested it as a solution a few times.
#
GWG
[pfefferle]: No one in my family has been in Germany since my grandparents met there.
#
GWG
So, maybe
#
GWG
I never use my work benefits.
#
GWG
pfefferle, I still want to make some changes to the webmentions page. You are calling do_settings_fields directly. https://developer.wordpress.org/reference/functions/do_settings_fields/
#
GWG
I think you should set up each as a section, rather than a field.
#
[pfefferle]
I also added the section support
#
GWG
[pfefferle]: Yes, I just think I can make it easier to understand
#
GWG
I'm playing with it in Semantic Linkbacks now
#
[pfefferle]
I know what you are trying to do
#
GWG
[pfefferle]: Is that good or bad?
#
GWG
Thought I might adhere more closely to the settings API
#
[pfefferle]
try to change https://github.com/pfefferle/wordpress-semantic-linkbacks/blob/cc2968033ee7f8e736fad4a5fec226c44b1e3be6/semantic-linkbacks.php#L58 to `add_settings_field( 'semantic_linkbacks_discussion_settings', __( 'Semantic Linkbacks Settings', 'semantic-linkbacks' ), array( 'Semantic_Linkbacks_Plugin', 'discussion_settings' ), 'webmention', 'receiver' );`
#
GWG
[pfefferle]: I've already made some changes. I'm just going a bit farther. Every time I add a new thing, I have to repeat the facepile setting entry. I'm just going to use a for loop that uses get_comment_type_strings
#
[pfefferle]
are we still discussion the settings page?
#
GWG
[pfefferle]: Yes.
#
GWG
Every check box is the same, just with a different type
#
[pfefferle]
but now we switched from the hooks to the functionality
#
GWG
I figured I'd just make my life easier next time I add a new type.
#
GWG
While I'm fixing the settings page
#
[pfefferle]
sure, let’s use them
#
GWG
[pfefferle]: You'll tell me if you like it when I finish.
Ironbeard joined the channel
#
GWG
[pfefferle]: Found a problem
#
GWG
There was a serious implementation bug in settings I have to fix
#
GWG
[pfefferle]: register_setting was being called in admin_init, not in init. When I fixed that, any time there wasn't an option, it defaulted to 1...meaning the settings wouldn't work.
#
GWG
I think I may just invert it. To a single array of types to show over one setting per type. If this thing grows longer, it's going to get insane.
[pfefferle] joined the channel
#
[pfefferle]
SL or Webmention
[kevinmarks] joined the channel
#
GWG
[pfefferle]: SL, but I think the same problem might be present in both
[grantcodes] joined the channel
#
jgmac1106
[gwg] Why would the 2016 “break” a gif when using a photo post kind?
#
GWG
Break?
#
Loqi
Getting close with @zegnat microformats citation tool. Just need to do the mark up for each type of source so he can add a drop down menu and let you select book, journal article, podcast, website, etc. https://jgregorymcverry.com/wp-content/uploads/2018/06/bibcite-1024x651.gif
#
jgmac1106
didn’t know what to call it as compared to https://twitter.com/jgmac1106/status/1003411845166850048
#
GWG
Click it?
#
jgmac1106
yes then it works, didn’t realize only thumbnail displays on photo posts
[kevinmarks] and [miklb] joined the channel
#
[miklb]
sounds to me it’s how it’s being inserted into the post, nothing to do with the plugin