#wordpress 2018-06-16

2018-06-16 UTC
[tantek], [cjwillcock], tantek__ and [mrkrndvs] joined the channel
#
[mrkrndvs]
GWG out of interest, what was the intent for removing the post kinds information when there is no content? Is it to support posting to micro.blog and / or social media? I am happy to add some content, just wondering.
#
GWG
None. It is a bug
#
GWG
I said that this morning. Not intentional
#
[mrkrndvs]
Ok, sorry. Thank you. FWIW, adding text did solve the trick
tantek__ joined the channel
#
GWG
I will be trying to fix it
#
GWG
I know I put in some code that may have caused this.
tantek_, chrisaldrich and [chrisaldrich] joined the channel
#
[chrisaldrich]
[mrkrndvs] did you see my note earlier? When you say you added text, where did you add it to fix the problem?
#
[mrkrndvs]
In the content box [chrisaldrich].
[sebsel] and [Vanessa] joined the channel
#
[Vanessa]
Any reason why the most recent update to the Indieauth plugin (3.0.0) should have stopped comments getting back to my blog?
#
[Vanessa]
After I updated I had some replies via Micro.blog but they didn't appear on my actual blog. I deactivated the Indieauth plugin and did a test post/reply from the Micro.blog app and it worked, reply showed up as a comment. Reactivated the plugin and tested again. Post, but no reply, which leads me to believe something about the plugin is causing the problem.
#
[Vanessa]
Is there something I need to do in relation to the latest plugin version - some settings I should change or is there an issue with it?
#
GWG
That is strange. No reason I know of. But will start looking
[kevinmarks], [jgmac1106], jeremych_, sebsel and [miklb] joined the channel
#
[miklb]
I’m seeing a slew of `PHP Warning: in_array() expects parameter 2 to be array, string given` in semantic-linkbacks
#
Loqi
[dshanske] #69 Fix issue with token error
#
GWG
I apparently made a big mistake
#
GWG
[miklb]: Re the errors, if this 3.7.7 or dev?
#
[miklb]
I wasn’t up to date so could be the problem.
#
[miklb]
I just pulled your latest master in indieauth. How should I test? Omnibear still throws same error
#
GWG
[miklb]: This isnt' about that
#
GWG
Send a POST request to your webmention endpoint and if it doesn't come back unauthorized, it's good
#
GWG
It was trying to authenticate webmention posts.
#
GWG
I need to fix that ASAP
#
[miklb]
still seeing the errors in semantic linkbacks using master of both fwiw
#
[miklb]
I’m still waking up, what’s easiest way to test my endpoint?
#
[miklb]
send the POST request
#
GWG
[miklb]: Send a POST request to /wp-json/webmention/1.0/endpoint
#
[miklb]
embarrassingly I’m not adept at doing that from the CLI
#
GWG
I've now added a constant to enable debugging and the instructions, but I can't break every other API endpoint to surface errors for ours.
#
GWG
[miklb]: What web browser?
#
[miklb]
FF or Safari
#
[miklb]
https://miklb.com/blog/2018/06/16/3963/ is the test post that succeeded with quill
#
Loqi
[Michael Bishop] test from Quill
#
GWG
[miklb]: Quill? What about Quill?
#
[miklb]
it worked posting
#
GWG
Yes.
#
GWG
But that wasn't what I was trying to fix.
#
GWG
I haven't tried to figure out the Omnibear problem.
#
GWG
Which works on mine, oddly enough.
#
GWG
Great!
#
GWG
It was returning a 401
#
GWG
It was rejecting everyone's webmentions, which is bad
#
[miklb]
wonders if [pfefferle] is at WCEU
#
GWG
Doubtful, but possible.
#
GWG
I've never heard of him attending
#
[miklb]
issue opened for the in_array errors in semantic linkbacks
#
GWG
I will be happy if by IWS I have everything working for everyone, even if nothing flashy comes.
#
[miklb]
stable is sexy™
#
GWG
[miklb]: There's a reason that there is a reviewer separate from the coder
#
[miklb]
stuff happens. If anything was mission critical, I could roll to previous stable tags and disable the indeauth plugin until someone gave the all clear.
#
[miklb]
But I think running master of all the plugins on my live site is useful for testing, and will help get us closer to stable.
#
[miklb]
I wonder if it would help to have a small checklist of things to test. Run through micropub.rocks/wm.rocks for instance
#
[miklb]
a release checklist with testing as part of it that is documented in a template that can be re-used.
#
[miklb]
but again, that gets back to the a couple of plugins are yours, a couple are community… so need to get a consensus on how to coordinate multiple plugins getting updates at same time.
#
GWG
[miklb]: I regrettably have my hands in everything
#
[miklb]
I should probably be brainstorming this in the wiki or a blog post.
#
GWG
[miklb]: Try going to the webmentions settings page, saving it, and tell me if you still get the same warning?
#
[miklb]
I do not.
#
GWG
Okay, so we have an issue with defaults.
#
[miklb]
not in semantic linkbacks, still in micropub
#
GWG
I meant in Semantic Linkbacks
#
[miklb]
just wanted to clarify because I’m getting similar error in both places.
#
[miklb]
but saving the page does remove the warnings
#
GWG
Yes, which means if the property isn't set, it isn't properly pulling the default.
[miklb] and [cleverdevil] joined the channel
#
GWG
Every time we mess something up I feel stupid
#
GWG
Or at the very least guilty
sebsel, [kevinmarks] and chrisaldrich joined the channel
#
chrisaldrich
GWG: I was just noticing I wasn't getting webmentions either and I'm running the most recent version of everything. The tip off was a pingback from Aaron instead of a wm.
#
chrisaldrich
So we should temporarily roll back Semantic Linkbacks is the current thought?
#
GWG
chrisaldrich: No
#
GWG
You should install the PR for IndieAuth
#
GWG
If someone approves it, I can push it now
#
Loqi
[dshanske] #69 Fix issue with token error
#
GWG
I was asked to make it respond when the token wasn't present
#
GWG
But that meant that it was trying to authenticate webmention requests
#
GWG
So I had to rollback that change
#
Loqi
totally
#
chrisaldrich
You're not helping Loqi...
#
GWG
chrisaldrich: Two things
#
GWG
1. Semantic Linkbacks 3.8.0 hasn't been released yet, only pfefferle can do that. I'll try to push a fix
#
GWG
2. You want to do a final pre-IWS podcast tomorrow
#
chrisaldrich
the other option is to temporarily disable IndieAuth as well; rolling it back can't be good for security reasons
#
chrisaldrich
I'm gave for a podcast tomorrow. Ideas on a broader topic?
#
GWG
chrisaldrich: The change involves removing three lines.
#
GWG
Easy enough to do.
#
chrisaldrich
Incidentally, manually imputting a webmention to my /wp-json/webmention/1.0/endpoint did work.
#
GWG
Yes. Because you have cookie authentication
gRegorLove joined the channel
#
GWG
Just comment out lines 86 through 93 in the class-indieauth-authorize file
#
GWG
The error about a missing bearer token
#
chrisaldrich
and then leave the replacement for when the plugin updates?
#
chrisaldrich
a ha! forgot about cookies...
#
GWG
chrisaldrich: The replacement is a flag that enables that. You can't leave it on or it tries to authenticate every REST API usage.
#
GWG
I'm hoping someone approves it and I'll push immediately.
#
GWG
IndieAuth has turned out to be a bigger job than I thought.
#
GWG
chrisaldrich: Topic for podcast...big showy thing for IWS?
#
chrisaldrich
I'll confirm that removing those lines and then refreshing the missed webmentions on Bridgy pushes them through.
#
GWG
I don't have one exactly.
#
GWG
But I've done a lot of tweaks of everything
#
GWG
chrisaldrich: By the way, not showing anything is there isn't anything in excerpt or content isn't a Post Kinds issue, it is a 2016-Indieweb issue
#
chrisaldrich
I'm not sure I follow what you mean there?
#
chrisaldrich
or I'm missing a referent/context...
#
GWG
Well, there was that comment yesterday that someone wasn't seeing anything when they posted bookmarks
#
GWG
It isn't Post Kinds, its the theme
#
GWG
I'm going to fix it though
#
GWG
chrisaldrich, so name a time tomorrow
#
chrisaldrich
Let me see what the plans are for "father's day" so I don't step on toes, but I suspect anything will be morning/early afternoon, so let's tenattively shoot for evening sometime.
#
chrisaldrich
Oh, yes the issue aaron davis was having. It just looked like something I'd seen when monkeying around with the mf2_ values before; without the right key, none of the post kinds portion shows.
#
chrisaldrich
Who was it that built the Ping me set up for manually sending webmentions? It was great for picking up a bunch of ones I'd missed from micro.blog yesterday.
#
GWG
Originally, pfefferle. Bunch of textual mods since
#
GWG
Most recently to try and cover privacy and deletes
#
GWG
The Endpoint form was me.
[chrisaldrich] joined the channel
#
[chrisaldrich]
pfefferle++
#
Loqi
pfefferle has 27 karma in this channel (59 overall)
#
Loqi
gwg has 69 karma in this channel (364 overall)
#
GWG
We keep iterating
#
GWG
I do have a recommendation for you if you are interested
[kevinmarks] and [Vanessa] joined the channel
#
[Vanessa]
Oops, sorry if I managed to ruin your Saturday by asking my question this morning. I do really appreciate all the things you guys do - without you I'd be nowhere!
#
GWG
Ruin my Saturday?
#
GWG
If you didn't, I wouldn't have realized we missed a rather large issue
#
GWG
I blame myself usually
#
GWG
So, please keep reporting issues
#
GWG
IndieAuth is the most sensitive plugin I have ever written
#
GWG
Because it grants access to your website.
#
chrisaldrich
[Vanessa] by reporting it, you've also saved the bacon for countless of other users who hadn't noticed it yet either.
#
chrisaldrich
I'll always take recommendations GWG.
#
GWG
I've been playing with a plugin called Avatar Privacy. It is the best avatar plugin I've investigated
#
GWG
And the developer is active and talkative
sebsel joined the channel
#
GWG
It supports gravatar caching, local avatars, local defaults, etc
#
GWG
It does add gravatar approval requirements also
#
GWG
He even commented on integration
#
Loqi
[dshanske] #6 Cache avatar images locally
#
chrisaldrich
Now that sounds pretty cool and could solve some issues.
#
GWG
Which?
#
chrisaldrich
the avatar privacy plugin...
#
GWG
It only caches for two days whereas I would want forever
[eddie] joined the channel