#wordpress 2018-06-17

2018-06-17 UTC
# 00:47 
aaronpk Uhoh what happened with the IndieAuth plugin?
Retsuko joined the channel
# 01:14 
GWG Bug, needs review approval for push
# 01:15 
GWG You
# 01:16 
GWG aaronpk, you wanted the error message surfaced. I discovered an unintended consequence I didn't think of
# 01:22 
GWG Basically, if it always returns an error message, that applies to all REST API functions. So, it shut down webmentions.
# 01:54 
aaronpk haha oops wow
# 01:55 
aaronpk How does that happen? I didn't know the IndieAuth plugin could hook into the entire system like that. I assumed it was only responsible for its own endpoints and the Micropub endpoint
# 01:58 
aaronpk GWG: how does your PR solve the problem? I don't understand why putting it behind that constant solves it
# 01:58 
aaronpk Is the constant somehow only defined when an IndieAuth or Micropub request is being made?
# 01:58 
GWG aaronpk: It basically disables that feature. It needs to be disabled.
# 01:59 
GWG It can't return an error because that short-circuits the entire REST API
# 02:00 
aaronpk Why not remove the code entirely then?
# 02:08 
GWG aaronpk: Because someone might need to troubleshoot.
# 02:09 
aaronpk Huh k
# 02:09 
GWG aaronpk: If the purpose of the code is to tell you when you aren't getting a token passed through, there needs to be a way to do that.
# 02:22 
GWG aaronpk: I am hoping in future to address more of those issues, but we can't leave that on.
# 02:34 
GWG I feel bad about the whole thing.
# 02:53 
aaronpk Don't feel bad
# 02:53 
aaronpk just add this case to the tests and move on
# 02:56 
GWG aaronpk: I'm going to have to write some more tests
# 02:56 
GWG I feel bad every time
[eddie] joined the channel
# 03:00 
aaronpk Doesn't even need to be automated tests. Even just a release checklist with a bunch of cases to run through manually would be useful
# 03:00 
GWG I intend to write one. I usually do testing, but this one didn't occur to me
tantek__, ben_thatmustbeme, tantek and [mrkrndvs] joined the channel
# 06:13 
[mrkrndvs] GWG I apologise if it has already been raised, but tags / categories seem to be broken in TwentySixteen IndieWeb. Working with Independent Reader, so I (naively) presume it might be the theme.
# 06:23 
GWG [mrkrndvs]: Define broken?
# 06:23 
GWG [mrkrndvs]: I just pushed a change to the theme to fix the excerpt issue.
# 06:36 
[mrkrndvs] Sorry, not showing any posts or a heading. I should know better than use the word 'broken'. Apologies. See for example https://collect.readwriterespond.com/tag/david-shanske/
# 06:37 
GWG [mrkrndvs]: Did you pull the latest version?
# 06:37 
GWG As of today?
# 06:37 
[mrkrndvs] Maybe I will try updating the theme and then reassessing.
# 06:37 
GWG [mrkrndvs]: I fixed the missing text issue this morning.
# 06:45 
[mrkrndvs] Of course that was it, going back to my hole again. Thank you for your patience
# 06:45 
GWG [mrkrndvs]: I just added some fixes today.
# 06:46 
[mrkrndvs] ++ GWG for his eternal patience
# 06:47 
[mrkrndvs] GWG++
# 06:47 
Loqi gwg has 70 karma in this channel (365 overall)
# 06:52 
GWG [mrkrndvs]: Just added another fun feature to the theme.
# 06:52 
GWG [mrkrndvs]: The archive page will show the icon
[mrkrndvs] joined the channel
# 08:06 
[mrkrndvs] Is that included in what I downloaded or is that another upgrade GWG?
# 08:06 
GWG [mrkrndvs]: I think you have to go back in.
# 08:06 
GWG I fiddle with the theme periodically.
# 08:07 
GWG I should take jgmac1106's thought and give it a different name.
# 08:07 
Loqi +1
# 08:16 
[mrkrndvs] 👍
# 08:20 
GWG [mrkrndvs]: Theme working out though?
jeremych_ and [mrkrndvs] joined the channel
# 10:03 
[mrkrndvs] Yep, all good GWG. Realised my problem, I had not subscribed to the GitHub repository. Thought I had. My next step is to scratch the itch that is personal customisations through my child theme
[kevinmarks] and jgmac1106_ joined the channel
# 12:46 
jgmac1106_ [mrkndvs] I forget to update theme from GitHub often, and forgot to start a child theme as well, need to go in and just copy my homepage and custom css then update
[grantcodes], sketchess, [kevinmarks] and [cleverdevil] joined the channel
# 17:59 
GWG I think I figured out how to trigger on a change in post kind, to solve an issue on my list.
[kevinmarks], j12t, gRegorLove, j12t_ and [jgmac1106] joined the channel
# 21:22 
[jgmac1106] So the webmention in the theme I was fooling around with ended up publishing but it went to my main blog and not the subdomain. I did delte the instance. How long should I wait when using webmention.rocks to test things?
[sebsel], tantek__ and [jgmac1106] joined the channel